Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp9175474rwl; Wed, 11 Jan 2023 02:25:04 -0800 (PST) X-Google-Smtp-Source: AMrXdXspc+qIpF2OnktOFflapzBst8xzIM20w971NWdnISxuPsddsWM2HPT/QsdABcSmookwRebQ X-Received: by 2002:a05:6a20:3ba7:b0:b2:3174:d2b2 with SMTP id b39-20020a056a203ba700b000b23174d2b2mr74825314pzh.28.1673432704429; Wed, 11 Jan 2023 02:25:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673432704; cv=none; d=google.com; s=arc-20160816; b=swx94CAHI8nmrHd7OCz3JRjBJSxfNS8avm/p+KXR0at+Pmlnab/5aermxfJBTNhpcQ TMunI1A1RMTc2nXUhRYkz1w0qj/KNJe1vcA+kN6PYCaXzfDKy1xUARg6iSTOHh9yKPTV SRE9gZkqj6DdaaDJCbe1prfHQGyuxoC4FD8Xvi5iOxu0GCLrUF3SPh1E5LpMnXKaoQUr VZJpBg4o+iPdddM8mjV7BirnjYoM4njozH49rkUhZ8PJTvQcgM7tPrLoiWHuRIsjpBVu fGGxjIfVDQBRIT9iIpiKb/5Dnd3Z9Nn5rQjRBN0Oc49cUcN3WhweCNNUrKdzjYqMU1y3 Z3OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=hJMN+0kVPp+vOM08lwMrdrmyGttmUlSZw+Wlnkrz/nI=; b=eDTsoiZ6cQda20UF9yLUjy7oAjtjrNg/oZDWjWU50gL2KvndHFXFR91ZB5N6i8zOTr hHXEIwn+aarK2a+2bxdeyxXFMUkwyAgEKyT/QQepy8THaggLayna6MozeJRPYIfoYri+ EohrnS3S8H8eyZzmdocSw0gm+7X8YMf+jc9zzL1EPuOIMxY7318DFzy57K8CXmRvo8ce ADSwVpWS8rzBQ+hQJKsC7B1UmUA8cGP08S0dUh7pBva6rTXdSFFbIAKltIOSxvuhEpsU GoKdN1ZGg8kwCvVV4TGOZZJCkXV+EbW8+7+nz761vnS61HbvDMWShkO0zllFYSHPCPj2 pxIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hlUjMxfx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 129-20020a630787000000b004b45781ea50si6309265pgh.813.2023.01.11.02.24.57; Wed, 11 Jan 2023 02:25:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hlUjMxfx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238877AbjAKJzu (ORCPT + 55 others); Wed, 11 Jan 2023 04:55:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236347AbjAKJzT (ORCPT ); Wed, 11 Jan 2023 04:55:19 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 384091AD89; Wed, 11 Jan 2023 01:52:15 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 24F1061B9A; Wed, 11 Jan 2023 09:52:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 827F6C433EF; Wed, 11 Jan 2023 09:52:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1673430733; bh=hkuo7qNDuli+lY95kty3I8u2gv4csLJIhFbudWsHe44=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hlUjMxfxt0z7KP7jhGBcW0mbvluD21ZU5AMs1exGjhcHCcNtCt2tujvNtHoCc84RR AZrGEOSQj9OQpn95tznKo4sX8isYo7p8QwqWycSgsIcnfk+WGrTzY3MMLiTZ8IqXpg 6a9zIgsqx4b3HroVDVYyjIDs5L+hk4EDNJSkmWUw= Date: Wed, 11 Jan 2023 10:52:10 +0100 From: Greg Kroah-Hartman To: Mika Westerberg Cc: linux-kernel@vger.kernel.org, Jens Axboe , "Rafael J. Wysocki" , Len Brown , Stefan Richter , Wolfram Sang , Alexandre Belloni , Dmitry Torokhov , Sean Young , Mauro Carvalho Chehab , Rob Herring , Frank Rowand , Maximilian Luz , Hans de Goede , Mark Gross , Vinod Koul , Bard Liao , Pierre-Louis Bossart , Sanyog Kale , Andreas Noever , Michael Jamet , Yehezkel Bernat , Jiri Slaby , Heikki Krogerus , "Matthew Wilcox (Oracle)" , "Martin K. Petersen" , Chaitanya Kulkarni , Ming Lei , Jilin Yuan , Alan Stern , Andy Shevchenko , Sakari Ailus , Jason Gunthorpe , Thomas Gleixner , Ira Weiny , Dan Williams , Won Chung , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-acpi@vger.kernel.org, linux-block@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux1394-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 3/5] driver core: make struct device_type.uevent() take a const * Message-ID: References: <20221123122523.1332370-1-gregkh@linuxfoundation.org> <20221123122523.1332370-3-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 23, 2022 at 03:56:54PM +0200, Mika Westerberg wrote: > On Wed, Nov 23, 2022 at 01:25:21PM +0100, Greg Kroah-Hartman wrote: > > The uevent() callback in struct device_type should not be modifying the > > device that is passed into it, so mark it as a const * and propagate the > > function signature changes out into all relevant subsystems that use > > this callback. > > > > Cc: Jens Axboe > > Cc: "Rafael J. Wysocki" > > Cc: Len Brown > > Cc: Stefan Richter > > Cc: Wolfram Sang > > Cc: Alexandre Belloni > > Cc: Dmitry Torokhov > > Cc: Sean Young > > Cc: Mauro Carvalho Chehab > > Cc: Rob Herring > > Cc: Frank Rowand > > Cc: Maximilian Luz > > Cc: Hans de Goede > > Cc: Mark Gross > > Cc: Vinod Koul > > Cc: Bard Liao > > Cc: Pierre-Louis Bossart > > Cc: Sanyog Kale > > Cc: Andreas Noever > > Cc: Michael Jamet > > Cc: Mika Westerberg > > Acked-by: Mika Westerberg # for Thunderbolt Thanks for the review.