Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp9207141rwl; Wed, 11 Jan 2023 02:57:09 -0800 (PST) X-Google-Smtp-Source: AMrXdXsZ/ndV43MyudG/K/bRcxoEDEY0DE/q/NtOO38BxL2DHGZVLMi3EtV1D9gVdHDvVW80++jS X-Received: by 2002:a05:6a20:8341:b0:ad:a5fd:b659 with SMTP id z1-20020a056a20834100b000ada5fdb659mr65172154pzc.7.1673434628857; Wed, 11 Jan 2023 02:57:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673434628; cv=none; d=google.com; s=arc-20160816; b=FUCfgbwVYJz9cLTXFWPM86awDkiwc5ti+jPhjJvnQoul+0bqQg+isDTPbU0J37gY2i qp2lj1hO76Pd47i6iDEq4OFzOpSd1nkYd/JE/MiQ1w7XmVgxOo0rjEkqwtUhVCYWD8Jb 1ioX4tomzW9Uj4J5onV0CNMH9IKjTNQfxddDfwGKgOAc6BiCOh2NBha7rKqFnSa9o6vh xUa1bAs/vMG7nJE2RZP5lRTwL/CW2VWm77AXCG6wBmOO5MbmZWo5bGjD7uSVgf0DsOYr hcfz/TQ2jERDKkZhMZM1VsoM5nGnzuDsp2vWhKlPnhtskTM3Lr96u2wT4hRZYVwLTj35 Q2aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=SlyGfvY841n17ZhvCyPuxwpt7koLnVwq33nHk8UbVfw=; b=odDmGFoMbJaS9qQXesWN44a8FQNfUXsJ3tioFRs5A+MxASZrRcIw2yl2ODrCZKNltS yI0hUEmtf0pcgr8SfqxVBiF4eyTPWB3Xa055N/yTAQhJcRy/p5WTilfnWQOCJ6t8zvOZ ibBszzXgMAd8LAtdKDpbbAxmMvL40xQnNeMX925C3YuT4wMzWaHiqV7XRC3hXfOwxNIF 7QV8ElN57+d5QpdB0TH2CXq1K3a3bVvK5c/ooplmfTFYSvVhnwBI1X2wlMub8ykOx9K8 yf9vU/jpEqhzLwHysufQvEYx9FETZxVPu4MDKpzdfTKR0CKjpKzfjiCs8elBfI5uZVae Pu7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=sntech.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k14-20020a170902c40e00b00186abd0c784si16343016plk.217.2023.01.11.02.57.01; Wed, 11 Jan 2023 02:57:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=sntech.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236052AbjAKKtW (ORCPT + 53 others); Wed, 11 Jan 2023 05:49:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238698AbjAKKsi (ORCPT ); Wed, 11 Jan 2023 05:48:38 -0500 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF0E513E85; Wed, 11 Jan 2023 02:48:34 -0800 (PST) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=phil.lan) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pFYem-0004Wz-VS; Wed, 11 Jan 2023 11:48:33 +0100 From: Heiko Stuebner To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Arnaud Ferraris , Caleb Connolly , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , Krzysztof Kozlowski Cc: Heiko Stuebner , kernel@collabora.com Subject: Re: [PATCH] arm64: dts: rockchip: fix input enable pinconf on rk3399 Date: Wed, 11 Jan 2023 11:48:25 +0100 Message-Id: <167343400179.2680857.5225762201628008377.b4-ty@sntech.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221215101947.254896-1-arnaud.ferraris@collabora.com> References: <20221215101947.254896-1-arnaud.ferraris@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS, T_SPF_HELO_TEMPERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Dec 2022 11:19:47 +0100, Arnaud Ferraris wrote: > When the input enable pinconf was introduced, a default drive-strength > value of 2 was set for the pull up/down configs. However, this parameter > is unneeded when configuring the pin as input, and having a single > hardcoded value here is actually harmful: GPIOs on the RK3399 have > various same drive-strength capabilities depending on the bank and port > they belong to. > > [...] Applied, thanks! [1/1] arm64: dts: rockchip: fix input enable pinconf on rk3399 commit: 6f515b663d49a14fb63f8c5d0a2a4ae53d44790a Best regards, -- Heiko Stuebner