Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e1a29bfd-7553-ec43-431e-0828191d2127@nvidia.com>
Date:   Wed, 11 Jan 2023 10:35:07 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] usb: gadget: u_ether: Don't warn in
 gether_setup_name_default()
Content-Language: en-US
To:     Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org
References: <20230106161759.66019-1-jonathanh@nvidia.com>
 <87cab5a1-a122-2b10-43b4-7a5819ff55ef@collabora.com>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <87cab5a1-a122-2b10-43b4-7a5819ff55ef@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YTRTT0UzSDBkUVptYWl2YXdZRU1ESjN6MndaWjhHMlo5cFgydEhyK0FnM2JP?=
 =?utf-8?B?WERYN3ZORXVta1l2UDZXVkdSVzRhcFh3cFRKMmczTGxpTDQ5bEVWOXJJdXFT?=
 =?utf-8?B?dEdwZG4vNEJKcGl2K0NFMUl0amZRdFJpMUJVQlZIVVNhaVRHZmUzMU5IMS8w?=
 =?utf-8?B?RytKWlBFSW1QUi96TmxabDhZK3VtMFdkbjc3U1lYeTlaTDM1Nk9ySXFYNEQw?=
 =?utf-8?B?RDZWd0EwNStPd3E4a0F3Z1krRzlURjl5RW5QQ2ltdFlmeVdTbUlzSTBkWmVi?=
 =?utf-8?B?VThlSDFUbWZoVEdvMDFsL0FYWklOQWRlU0ZJTmE4bFVGaWdXV2ZIeUZnOFo0?=
 =?utf-8?B?bWxkYWs1ajAyL0JVR3ZteUp6ZFVpcEVsSnFkZXZXKzhEL2ZqWGN4L3pmM25u?=
 =?utf-8?B?STR0MUtqVFY2ZEprNFZ3RjZja0hEbGlPVUpOSkFpYVFmbEVYR3JNMTVKeG5F?=
 =?utf-8?B?STZ0UDZEQ21DVDNNOXhCTkpaVU9hM25BVUF3K2JTVHQ2dXhlZk1NUGRBV2hp?=
 =?utf-8?B?K3R4Q0pBblBJeHlrTDRacGh6YzhYTUpXeDhQZ25YRmJNd0pjTzdVRm5TZkJZ?=
 =?utf-8?B?RVQ5dnF3eFl1Z1c2S1hTTlpWc21JOC9HdWdvRjcvNDV1NFRaOXV5YTBVNEkx?=
 =?utf-8?B?cGNNZVh2NFRndFVKL3plYmRtYWswVW1NSklmYTdYdTNzTWE4RDllNElJNHFp?=
 =?utf-8?B?K0Q3U2Mxd0JPMWZkYTBTN0svbjR3WnphaklOSllOUEVSc2FPNldwTTF2dGcy?=
 =?utf-8?B?N2pWUnlPT29UQ3MvZjhzQnB5TVRJY0t2WnhtNUJjRUNtYWlmQzhCSysrTkkv?=
 =?utf-8?B?V1VhSkxTejRXSEQ0cDJWSnlXZmZOWEN3Ti9Za2lvcjg0MEtpMTJqTTVDU3h1?=
 =?utf-8?B?L3k2OTZmK2lRYXcrdEN6THQ4L0t5RWkyUG1sMU1jNmQzeHdRdmVHTG5vR0hN?=
 =?utf-8?B?RXJwdlFDY214aFQ4UHZIMllUNEZrTDh0RkdGMFdvemhZaURla1M0M3JENnY4?=
 =?utf-8?B?TDgxRWk4UjJxVEhCZjQranlkWGpydU5QTVpBRFYwTE4zSWZ4UGp5L3MzdmVi?=
 =?utf-8?B?eEVoR3FRMU5JczhFcldQRWNmcHZYemFHaFdlZHF6b0pQblhlVGY4V3FlS09Q?=
 =?utf-8?B?T2FLMXN6Y2V5WlZKYjNiNGhiRWtKZE92Vll5ajRFVEZwOW9Hdm1obDJUeGE2?=
 =?utf-8?B?T3F5RDJ1ckNVc1FsL3ExSjJyYjNTN0ZIdkhyRnd0RldtOVlaTStVeHQ3Zmcz?=
 =?utf-8?B?NlE4VUgyL2xPcDFMTzRRdWRSWjFqejVaNVEzUFRsYzBkbXV4QW5lWEJPQVdJ?=
 =?utf-8?B?cHpqYXc4bDR4TjhCMUE2QzVBUjZXZkRhZHZqMUN3aDNVQ29TRHM0a1BTNXhX?=
 =?utf-8?B?YzJVT3g4YlFWRmduR3YrRXorL0l6UXV2ZURXZXllZXZCVnc4SmxnaTZNQ0Jr?=
 =?utf-8?B?TCtBcDREd2FvTDhSVGFZQ2RZbjlKR3pyMzlTUW9PUWIrSE1JWnAwV1ZmTElE?=
 =?utf-8?B?dmtlWUxmZjcweSs4ZEN3bGs2bWhDMEhSZVBVRFhZWjA3cnVmR3VRTHVzWlpi?=
 =?utf-8?B?Z3pEeEs5L1VrOVBERVdITlp5ZDFPaGVRNFhSeDB4T3Z2MGhyMGlhbEw5L2Jn?=
 =?utf-8?B?cmw5d3laMGZwbmVsdEtVSkFGajNuRGlaSTRxdnRvbjF5MDBwdGRHK1BFTnIx?=
 =?utf-8?B?aTU5Mk9pKzVDUkEra3FXcHVabzJVVWFvWWd5cml4MzRWYlJodXFkN2dJbmRs?=
 =?utf-8?B?MVVVNlUwanduNW1vMVFRNFU3dDJRUExRS202citNS2pqMWVxNHhtdExOczFT?=
 =?utf-8?B?U2R0ZE1KRGtDUkxQUnBvWWNBV1VvcWxla1pBTFJNSGNuYmZGblNXYVBwUHBp?=
 =?utf-8?B?VnRIeSt1NGNjcVVHWHNrMTk5djlhZjZnQTVyWlFVcmJKN0xRYkFmL2N0QnJS?=
 =?utf-8?B?YnYwQVBrQnlRUlhycURxNG9qRU1JRmp5c0c2ckdrRlJuMmFhRnR6ekRpVk1o?=
 =?utf-8?B?QVpCSCt3RE04a0lsWjdTYy8zS1ZHL1Z6aFBERmdsOUlCcDNIR3MxTUpaUXBy?=
 =?utf-8?B?d2ZYQkU4eU5kWkVubmpNNDhSaXI2d0JDc0JjMmRjVk5aV2lLSFppRHRsTHBp?=
 =?utf-8?B?RXdNcURiN3AzYnIyY0hSTFFiUlZ1Yi94eXpia3dRWldYWXFBQ0hncTZqaEF0?=
 =?utf-8?B?ZGc9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a6ad0752-5910-4ba4-d710-08daf3c02225
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 10:39:35.9928
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +P0T3tVX3BEB1F03OuX1PhdUqWfDl98NpCj/3DOzVrK7Ol6ikmnikRxXIRVk9M3pOyA1rP/rbTplj+WzT9qqvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4400
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/01/2023 16:31, Andrzej Pietrasiewicz wrote:
> Hi,
> 
> Hasn't there been a similar patch already?

There could be, but I was not aware. Do you happen to have a link to it?

> W dniu 6.01.2023 o 17:17, Jon Hunter pisze:
>> The function gether_setup_name_default() is called by various USB
>> ethernet gadget drivers. This function always generates the MAC address
>> for the ethernet gadget device and always prints a warning when
>> generating the MAC address. Given that these messages are expected, make
>> these prints informational instead of warnings.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>>   drivers/usb/gadget/function/u_ether.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/function/u_ether.c 
>> b/drivers/usb/gadget/function/u_ether.c
>> index 8f12f3f8f6ee..c19d66cd1446 100644
>> --- a/drivers/usb/gadget/function/u_ether.c
>> +++ b/drivers/usb/gadget/function/u_ether.c
>> @@ -845,13 +845,13 @@ struct net_device 
>> *gether_setup_name_default(const char *netname)
>>       snprintf(net->name, sizeof(net->name), "%s%%d", netname);
>>       eth_random_addr(dev->dev_mac);
>> -    pr_warn("using random %s ethernet address\n", "self");
>> +    pr_info("using random %s ethernet address\n", "self");
> 
> As far as I can tell this function is called by all Ethernet gadgets,
> and using random Ethernet addresses is the default behavior for all of 
> them,
> including legacy gadgets. Why to inform about the default situation 
> happening?
> So in fact maybe it would be better to eliminate the pr_warn() altogether,
> instead of replacing it with pr_info()? If the user does not care to
> explicitly set some non-default address(es), why would she care to know
> that a randomly selected address has been chosen? Note that learning
> _what_ specific address has been chosen is perfectly doable without
> these pr_info() calls.


That would be fine with me. This print has been there for a long time 
and so I figured people wanted some sort of message. I would be happy to 
remove.

Jon

-- 
nvpublic