Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 11 Jan 2023 13:11:27 +0100
From:   Heiko Carstens <hca@linux.ibm.com>
To:     Christian Borntraeger <borntraeger@linux.ibm.com>
Cc:     Janosch Frank <frankja@linux.ibm.com>,
        Claudio Imbrenda <imbrenda@linux.ibm.com>,
        David Hildenbrand <david@redhat.com>, kvm@vger.kernel.org,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] KVM: s390: interrupt: use READ_ONCE() before cmpxchg()
Message-ID: <Y76nb+2tTERSszfP@osiris>
References: <20230109145456.2895385-1-hca@linux.ibm.com>
 <f4203dea-93a9-6903-d635-c36ff47337c9@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f4203dea-93a9-6903-d635-c36ff47337c9@linux.ibm.com>
Precedence: bulk

On Tue, Jan 10, 2023 at 08:15:50PM +0100, Christian Borntraeger wrote:
> Am 09.01.23 um 15:54 schrieb Heiko Carstens:
> > Use READ_ONCE() before cmpxchg() to prevent that the compiler generates
> > code that fetches the to be compared old value several times from memory.
> > 
> > Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> 
> Looks sane.
> 
> Reviewed-by: Christian Borntraeger <borntraeger@linux.ibm.com>
> 
> In case you want to take it via the s390 tree:
> Acked-by: Christian Borntraeger <borntraeger@linux.ibm.com>

Given that there don't seem to be any pending s390 specific patches I
take it via the s390 tree.

Applied.