Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <59f19f5f-dcde-6042-cbc1-eee4b3d2469b@kernel.org>
Date:   Wed, 11 Jan 2023 21:25:51 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Content-Language: en-US
To:     Yangtao Li <frank.li@vivo.com>, jaegeuk@kernel.org
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
References: <20221222081855.81553-1-frank.li@vivo.com>
From:   Chao Yu <chao@kernel.org>
Subject: Re: [PATCH] f2fs: drop useless initializer and unneeded local
 variable
In-Reply-To: <20221222081855.81553-1-frank.li@vivo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/12/22 16:18, Yangtao Li wrote:
> No need to initialize idx twice. BTW, remove the unnecessary cnt variable.
> 
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
>   fs/f2fs/iostat.c | 10 ++++------
>   1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/f2fs/iostat.c b/fs/f2fs/iostat.c
> index 3166a8939ed4..335b055ffe7d 100644
> --- a/fs/f2fs/iostat.c
> +++ b/fs/f2fs/iostat.c
> @@ -97,8 +97,7 @@ int __maybe_unused iostat_info_seq_show(struct seq_file *seq, void *offset)
>   
>   static inline void __record_iostat_latency(struct f2fs_sb_info *sbi)
>   {
> -	int io, idx = 0;
> -	unsigned int cnt;
> +	int io, idx;
>   	struct f2fs_iostat_latency iostat_lat[MAX_IO_TYPE][NR_PAGE_TYPE];
>   	struct iostat_lat_info *io_lat = sbi->iostat_io_lat;
>   	unsigned long flags;
> @@ -106,12 +105,11 @@ static inline void __record_iostat_latency(struct f2fs_sb_info *sbi)
>   	spin_lock_irqsave(&sbi->iostat_lat_lock, flags);
>   	for (idx = 0; idx < MAX_IO_TYPE; idx++) {
>   		for (io = 0; io < NR_PAGE_TYPE; io++) {
> -			cnt = io_lat->bio_cnt[idx][io];
>   			iostat_lat[idx][io].peak_lat =
>   			   jiffies_to_msecs(io_lat->peak_lat[idx][io]);
> -			iostat_lat[idx][io].cnt = cnt;
> -			iostat_lat[idx][io].avg_lat = cnt ?
> -			   jiffies_to_msecs(io_lat->sum_lat[idx][io]) / cnt : 0;
> +			iostat_lat[idx][io].cnt = io_lat->bio_cnt[idx][io];
> +			iostat_lat[idx][io].avg_lat = iostat_lat[idx][io].cnt ?
> +			   jiffies_to_msecs(io_lat->sum_lat[idx][io]) / iostat_lat[idx][io].cnt : 0;

exceed 80 column?

Thanks,

>   			io_lat->sum_lat[idx][io] = 0;
>   			io_lat->peak_lat[idx][io] = 0;
>   			io_lat->bio_cnt[idx][io] = 0;