Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 11 Jan 2023 15:19:29 +0100
From:   Michal =?iso-8859-1?Q?Koutn=FD?= <mkoutny@suse.com>
To:     Yuanchu Xie <yuanchu@google.com>
Cc:     Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Yu Zhao <yuzhao@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Shakeel Butt <shakeelb@google.com>,
        Muchun Song <songmuchun@bytedance.com>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        cgroups@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] mm: multi-gen LRU: cgroup working set stats
Message-ID: <20230111141929.GB14685@blackbody.suse.cz>
References: <20221214225123.2770216-1-yuanchu@google.com>
 <20221214225123.2770216-3-yuanchu@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="s2ZSL+KKDSLx8OML"
Content-Disposition: inline
In-Reply-To: <20221214225123.2770216-3-yuanchu@google.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--s2ZSL+KKDSLx8OML
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Dec 14, 2022 at 02:51:23PM -0800, Yuanchu Xie <yuanchu@google.com> wrote:
> +static int memory_page_idle_age_format(struct mem_cgroup *root,
> +				       struct seq_file *m)
> +{
> +	struct mem_cgroup *memcg;
> +	unsigned long *table;
[...]
> +	table = kmalloc_array(PAGE_IDLE_AGE_NR_RANGES * nr_node_ids *
> +				      ANON_AND_FILE,
> +			      sizeof(*table), __GFP_ZERO | GFP_KERNEL);
> +
[...]
> +	memory_page_idle_age_print(m, table);
> +	return 0;

FTR, the table seems leaked here.


Michal

--s2ZSL+KKDSLx8OML
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----

iHUEARYIAB0WIQTrXXag4J0QvXXBmkMkDQmsBEOquQUCY77FbgAKCRAkDQmsBEOq
uYurAP9JGeUGRS6AfrMninhvfGTvmei8qAImveRp13FIRINKGwEAlYRvprpP/hbL
IvrnjwZQ0UVS9+oYjQTsbbZbJVGfhgE=
=qQ2L
-----END PGP SIGNATURE-----

--s2ZSL+KKDSLx8OML--