Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 11 Jan 2023 15:08:50 +0100
From:   Daniel Wagner <dwagner@suse.de>
To:     James Smart <jsmart2021@gmail.com>
Cc:     Dick Kennedy <dick.kennedy@broadcom.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] lpfc: Handle gracefully failed FLOGI attempts in
 devloss callback
Message-ID: <20230111140850.cww4xgq5vtvrt6kx@carbon.lan>
References: <20230111113841.108588-1-dwagner@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230111113841.108588-1-dwagner@suse.de>
Precedence: bulk

On Wed, Jan 11, 2023 at 12:38:41PM +0100, Daniel Wagner wrote:
> When FLOGI attempts fail, the vport can be released via
> lpfc_nlp_release() function. This function will set the pointer to NULL
> and the node state to NLP_STE_FREED_NODE. Though it wont stop the
> devloss timer in the upper SCSI layer.
> 
> Hence when the devloss timer eventually fires,
> lpfc_dev_loss_tmo_callbk() is called and it tries to operate on vport
> NULL pointer.
> 
> Just do nothing in this case. To be extra cautions also check for the
> state and issue a warning if we have an inconsistency.

Ignore this one. Just saw the proper fix:

https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?id=97f256913c5d