Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp9524461rwl; Wed, 11 Jan 2023 06:50:00 -0800 (PST) X-Google-Smtp-Source: AMrXdXsg3rilro1QnHCjbGwDtP0NACKJu5WZcuhv1xJxZUTEOgis5nYF1iAFwdwIFffERAnchaKp X-Received: by 2002:a05:6a20:4419:b0:b6:2bd6:a77e with SMTP id ce25-20020a056a20441900b000b62bd6a77emr7514764pzb.32.1673448600236; Wed, 11 Jan 2023 06:50:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673448600; cv=none; d=google.com; s=arc-20160816; b=M8tNh+gU8xEIIiSWMKlyY2CwcUIDoFsTx8TM20WTUnkq/bbeQ0Lvq6djlXZHwv+DO0 D7qADeWOqPSjdSLDrM2jnri1udDSrC7KNpYiU0TSrS1216Y3IM+9osVqQ1/ky71S125L KYw2UvNBhgWE1g/hj9ncU+ZU0+C2gqRg8OI/jRxFC6/6UNUAStLnoXs+clERhbuoGPCB fxmRp/Ow/woZw9pL2m6UmwHU2L+sdD0ZcCiWwBbJxJ448O++zcWy4kRUIgqGmu6Yj+UA TGxNWD/9rpbIUbVZznm0u5yrEHn61UHHOiBzQEud/iCyFJM9hYoEAz5ShVNvZVDVBbIj Zrgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=pjdCcJ1BZJN8dMIfJt/MdP9Wf8YPuH/4TBx+RnDc7BY=; b=SPIaFvHQDUaDkpHa6+nkJyGsznoSpCPAXYAfe3tX/hW9fTJrENW2vhi2ARgjRJ3mkv U9LDIFejVRbb4kdpggda0MR7wkZ7NmqFGaBBXx4n+6Yuw/hxM+WVRvZCHYeNt9XnYul/ f85N+kPPbyvFeklrMANvqUrNDvYNzHvs777NjJP4nqMVNA+WwWpEpUzCdMFUdFpKUtnB jxpqZoVaX8jLlH78JPXj5HijiajwVNfhc3VcPlhFrGR9zp9t3QmOuU2Qc2ecp6ZAzHn2 4NgV66NteXo9YN1YWQEw7Iplkn3RY6WvR295DRyZ5rDPvYnDBbPHoDpWDCFI9xdJVFTB zwow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=UILuiBo5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i190-20020a6387c7000000b004b752450972si1507457pge.38.2023.01.11.06.49.53; Wed, 11 Jan 2023 06:50:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=UILuiBo5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232149AbjAKOXs (ORCPT + 53 others); Wed, 11 Jan 2023 09:23:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232757AbjAKOXp (ORCPT ); Wed, 11 Jan 2023 09:23:45 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26EAA13F03; Wed, 11 Jan 2023 06:23:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673447024; x=1704983024; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=AmhnEiGab9Eaur3Fmk7nmA032oNYijkXIBqHp/6Omb0=; b=UILuiBo54grvsZ27vFQe3N7tTTHi7Dyw1TZfwgEEtgRzvp2GORUaYCi7 Gy2Ut/5h+jiRdFhuNMr8kQNldErhtsD7mKOdt+Xn6o2TznHxPT5IemAwA qU57CIMO11W60zecoluXwzJANOl+HlaBoyCMTfEPnwAeDRtPyhwrgdVHl XrhtBMKNMjYyFnCnlOcbEBfz4iwDhJsNV+OvJsDBiY93xSJu7a3aNJFKx ptHjCQ1oRMeiSGvv6u7J5hcaGlEXXb6td5YvYzRlYeuFzDCJDfba/yHQj I9LtEInmT1t0hWwF82wfe/tO8oQT53RE9EP0oG0o/PFk92Y3sZyIM0t5A w==; X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="303793407" X-IronPort-AV: E=Sophos;i="5.96,317,1665471600"; d="scan'208";a="303793407" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2023 06:23:43 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="607381759" X-IronPort-AV: E=Sophos;i="5.96,317,1665471600"; d="scan'208";a="607381759" Received: from mihaiana-mobl1.ger.corp.intel.com (HELO ijarvine-MOBL2.ger.corp.intel.com) ([10.251.222.62]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2023 06:23:40 -0800 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= To: linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Johan Hovold , =?UTF-8?q?Samuel=20Iglesias=20Gons=C3=A1lvez?= , Rodolfo Giometti Cc: linux-kernel@vger.kernel.org, =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Subject: [PATCH v3 00/13] tty/serial: bool conversions and cleanups Date: Wed, 11 Jan 2023 16:23:18 +0200 Message-Id: <20230111142331.34518-1-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There are number of functions in tty/serial which have arguments or return types that expect/behave like bool. Likely due to them existing before bool was available, other types are used. Make conversions to bool and cleanups. v3: - moxa: Fix function signature in comment - moxa: Rearrange comment (0: off, 1: on) removal from rename change to bool change (effect is internal to the series) v2: - Call dtr/rts parameters/variables consistently "active" - Don't chain one return statement with || - Don't change function signatures to >80 chars ("while at it") - moxa: differentiated dtr and status variables Ilpo Järvinen (13): tty: Cleanup tty_port_set_initialized() bool parameter tty: Cleamup tty_port_set_suspended() bool parameter tty: Cleanup tty_port_set_active() bool parameter tty: moxa: Make local var storing tty_port_initialized() bool serial: Convert uart_{,port_}startup() init_hw param to bool tty: Convert ->carrier_raised() and callchains to bool tty: Convert ->dtr_rts() to take bool argument tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool active serial: Make uart_handle_cts_change() status param bool active tty: Return bool from tty_termios_hw_change() tty/serial: Call ->dtr_rts() parameter active consistently tty: moxa: Rename dtr/rts parameters/variables to active usb/serial: Rename dtr/rts parameters/variables to active drivers/char/pcmcia/synclink_cs.c | 18 +++--- drivers/ipack/devices/ipoctal.c | 4 +- drivers/mmc/core/sdio_uart.c | 13 ++--- drivers/pps/clients/pps-ldisc.c | 6 +- drivers/s390/char/con3215.c | 4 +- drivers/staging/greybus/uart.c | 4 +- drivers/tty/amiserial.c | 12 ++-- drivers/tty/hvc/hvc_console.c | 4 +- drivers/tty/hvc/hvc_console.h | 2 +- drivers/tty/hvc/hvc_iucv.c | 6 +- drivers/tty/moxa.c | 82 ++++++++++++++-------------- drivers/tty/mxser.c | 11 ++-- drivers/tty/n_gsm.c | 16 +++--- drivers/tty/serial/imx.c | 2 +- drivers/tty/serial/max3100.c | 2 +- drivers/tty/serial/max310x.c | 3 +- drivers/tty/serial/serial_core.c | 65 +++++++++++----------- drivers/tty/serial/sunhv.c | 8 +-- drivers/tty/synclink_gt.c | 21 +++---- drivers/tty/tty_ioctl.c | 8 +-- drivers/tty/tty_port.c | 22 ++++---- drivers/usb/class/cdc-acm.c | 4 +- drivers/usb/serial/ch341.c | 11 ++-- drivers/usb/serial/console.c | 2 +- drivers/usb/serial/cp210x.c | 6 +- drivers/usb/serial/cypress_m8.c | 6 +- drivers/usb/serial/digi_acceleport.c | 6 +- drivers/usb/serial/f81232.c | 10 ++-- drivers/usb/serial/f81534.c | 4 +- drivers/usb/serial/ftdi_sio.c | 6 +- drivers/usb/serial/generic.c | 10 ++-- drivers/usb/serial/ipw.c | 8 +-- drivers/usb/serial/keyspan.c | 6 +- drivers/usb/serial/keyspan_pda.c | 4 +- drivers/usb/serial/mct_u232.c | 6 +- drivers/usb/serial/mxuport.c | 4 +- drivers/usb/serial/pl2303.c | 11 ++-- drivers/usb/serial/quatech2.c | 6 +- drivers/usb/serial/sierra.c | 6 +- drivers/usb/serial/spcp8x5.c | 11 ++-- drivers/usb/serial/ssu100.c | 6 +- drivers/usb/serial/upd78f0730.c | 8 +-- drivers/usb/serial/usb-serial.c | 8 +-- drivers/usb/serial/usb-wwan.h | 2 +- drivers/usb/serial/usb_wwan.c | 6 +- drivers/usb/serial/xr_serial.c | 8 +-- include/linux/serial_core.h | 6 +- include/linux/tty.h | 2 +- include/linux/tty_ldisc.h | 4 +- include/linux/tty_port.h | 10 ++-- include/linux/usb/serial.h | 6 +- net/bluetooth/rfcomm/tty.c | 2 +- 52 files changed, 248 insertions(+), 260 deletions(-) -- 2.30.2