Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp9537818rwl; Wed, 11 Jan 2023 07:00:32 -0800 (PST) X-Google-Smtp-Source: AMrXdXuVrjYVO1dJxHt5n0C6JB5jceMNc6/syxgmhsSkXMUS7RBUCeD8K5A6KWKM6nyHsGr7qenw X-Received: by 2002:a05:6a20:47c6:b0:b0:1e9b:e930 with SMTP id ey6-20020a056a2047c600b000b01e9be930mr77203205pzb.57.1673449232183; Wed, 11 Jan 2023 07:00:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673449232; cv=none; d=google.com; s=arc-20160816; b=mitQWMcPBxQ5uuENwSy2uluuV61xXYg76bDB0MIOQu5AR4e9olu7YG4Ia6RuFRNAHw ZvjFeGexvzw49LsLQoz1OWSqYMzCcL22bjOxz0Zkdy3ResNbds2E1l5pJ9RcUpiOIa97 2XKrJ9pkGy8KBkl2T85uRuHfwCBmbp0XColRWB1W9xerWZtNIznrASvu847iPEZjxPJO DuFJ+gY/1BjBRrk0wNFCF27k9JHc9W5wnbLPMkY/69c2uOXBcdrwF9SB6y7yaAdUUtqG 8Y1k3ScKYVyRlk+6k4lXi2zOTsHvoyZSIKhshEcHFx8fXacYgsu2eiQQ8KiAQ0GcThWW icUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Svga7SsiFsN5UXzPSuWC3QCdzpcdEqH2j+9/f+MZ4Lk=; b=TkOAaz/U/wqf/EgW0NjBKsBYRbl0BWIqLFaDAVjSh88TzUbIM1RT/ZcmYDjI6mjYAy Zh50KHmNhRBFr+nlsBXl6BKaAcSxDKuZDbqu64Im8tz2rfJSvmB5Srv7f3+9Ov18V+GQ gT69UI6OkD1RHfgpjDGa3kJFhxcKqcc01Sx0y2nEjW+tIGy8Z7X8tfkAdv3cvfGz0rY9 R4pohjZpqH8VcUrTz/DjcZL3uTuXQnESj4nZgCHOgWk0gu3YAPmXDg+mN1U19lAk7PJQ Ou71gdfqFwVifnvjzJTcIVzfc1smD3Jo6mLVioysVQHX2mGSPfhRPt4oYyf1c6c5831A 0FCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=bQ92uKsO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t203-20020a635fd4000000b00478701e57c8si14705748pgb.807.2023.01.11.07.00.24; Wed, 11 Jan 2023 07:00:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=bQ92uKsO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239288AbjAKOYt (ORCPT + 53 others); Wed, 11 Jan 2023 09:24:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239175AbjAKOYR (ORCPT ); Wed, 11 Jan 2023 09:24:17 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70DEF1A066; Wed, 11 Jan 2023 06:24:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673447048; x=1704983048; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0aHYPToS/jABucyxHBUjjp3ckI/iQBTA/kh5jyn5eAU=; b=bQ92uKsOT37n8E6obUNT7noQVBMmrfewEHoPtgCgg3o1ZP6zL4kRbFkC aJSkzKnn3cZDbNeNKi5fncyoTWPeR7b3Wpo0ls62kaXVhpoQZRMNB6a3k ikmUbD1tRfM0T91yvAE+dke7jRaPnOdSEZopw9BEHEKRxP/dnbiSastIK zrBRE90neL0n0HheVxFYB6lxQLMeUQRgnKXsPyE+3eFJxzN+PY/k/3OM5 8VrMvSakJTlZ8fthGxpMUDDWhamTRHuwEz0CVA9gSXPKKnMI/uxcnAfQb O/4YG9rLpnn4FWVjB/905avP/UZ1HaosJvT9NuLBzdUGXUfg4GjInRL6F A==; X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="303793524" X-IronPort-AV: E=Sophos;i="5.96,317,1665471600"; d="scan'208";a="303793524" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2023 06:24:07 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="607381853" X-IronPort-AV: E=Sophos;i="5.96,317,1665471600"; d="scan'208";a="607381853" Received: from mihaiana-mobl1.ger.corp.intel.com (HELO ijarvine-MOBL2.ger.corp.intel.com) ([10.251.222.62]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2023 06:24:04 -0800 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= To: linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Johan Hovold , =?UTF-8?q?Samuel=20Iglesias=20Gons=C3=A1lvez?= , Rodolfo Giometti , linux-kernel@vger.kernel.org Cc: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Subject: [PATCH v3 04/13] tty: moxa: Make local var storing tty_port_initialized() bool Date: Wed, 11 Jan 2023 16:23:22 +0200 Message-Id: <20230111142331.34518-5-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230111142331.34518-1-ilpo.jarvinen@linux.intel.com> References: <20230111142331.34518-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return type of tty_port_initialized() is bool, use matching type for the local variable. Also reorder the local vars to reverse-xmas-tree while at it. Reviewed-by: Jiri Slaby Signed-off-by: Ilpo Järvinen --- drivers/tty/moxa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c index bc474f3c3f8f..2d9635e14ded 100644 --- a/drivers/tty/moxa.c +++ b/drivers/tty/moxa.c @@ -1664,8 +1664,8 @@ static int moxa_poll_port(struct moxa_port *p, unsigned int handle, u16 __iomem *ip) { struct tty_struct *tty = tty_port_tty_get(&p->port); + bool inited = tty_port_initialized(&p->port); void __iomem *ofsAddr; - unsigned int inited = tty_port_initialized(&p->port); u16 intr; if (tty) { -- 2.30.2