Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Frank Li <frank.li@nxp.com>
To:     Chanh Nguyen <chanh@os.amperecomputing.com>,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Dan Vacura <w36195@motorola.com>,
        Jakob Koschel <jakobkoschel@gmail.com>,
        Alan Stern <stern@rowland.harvard.edu>,
        Vijayavardhan Vennapusa <vvreddy@codeaurora.org>,
        Rondreis <linhaoguo86@gmail.com>,
        Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Open Source Submission <patches@amperecomputing.com>
Subject: RE: [EXT] [PATCH v3] USB: gadget: Add ID numbers to configfs-gadget
 driver names
Thread-Topic: [EXT] [PATCH v3] USB: gadget: Add ID numbers to configfs-gadget
 driver names
Thread-Index: AQHZJYksvH6c0HvTAEK5rLNkYqGpX66ZVArg
Date:   Wed, 11 Jan 2023 15:16:05 +0000
Message-ID: <HE1PR0401MB2331CC8AE82C4DD96A1D398E88FC9@HE1PR0401MB2331.eurprd04.prod.outlook.com>
References: <20230111065105.29205-1-chanh@os.amperecomputing.com>
In-Reply-To: <20230111065105.29205-1-chanh@os.amperecomputing.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9zzRXAISxYUAhbk88zELLhjR4oU5hDM1uk5kAyi8Xa3pSyR4DrcQph+U9Hya?=
 =?us-ascii?Q?5GosXC795ZYBWV1gjBXk9tkrMzsV0PHQG8Lz0jyDFWZdIivhjuNqo8w8cTYj?=
 =?us-ascii?Q?JtVRcYSUgwIOn/FYWZEuVNglxOF7ce9LoF8vuGhcwSkzIQVjnI5wEeix1RC3?=
 =?us-ascii?Q?7G6Jp67XxXmYGAaWYhgJ80s0Bwx+5jKmTQhg9Od2XGQGwg7qnTmcN283Y3IT?=
 =?us-ascii?Q?DXVU41uQNI1QQrFFPk5FERV/syAHUTxQYfNdFbOR7+V29utHCslIlxgG/IZ1?=
 =?us-ascii?Q?bQMWakyU8w/mOjFctyIbgIgb5W6EMVvGveg17NAmGsRg+iqzfg3YbKBacgZi?=
 =?us-ascii?Q?V1Owt+vrJRsD6W7NIxNmbhRmWbDnwYEfvHc1hvu0OY86U1EvHQ725H1ybROV?=
 =?us-ascii?Q?Jq8IlhfuRmAr75nC036kQKJKt+fPgoCdjGWp9Ux9P1F7KipDXLtR4bMGZ7br?=
 =?us-ascii?Q?C/1XvSngSQlqoybgDF24irpQq4wqmXGnXNFNhcr/2yqkP2mrLbyNE/ILcVM/?=
 =?us-ascii?Q?cpMA15XmNdt8g/RZ45vCEo2J5RUyCc/s03+uSNylWfk1c/Xc+VIO6OZGbsjq?=
 =?us-ascii?Q?oKueDNwulk9S/Llg5AOctUALrEvEktsLZulaAyY03XmcM5qVx34oxEZk8yFk?=
 =?us-ascii?Q?1LL47r6kjy7v86Vx7Rz3ruA6ryGvSM9cERdcxme+gP57X6Ol3ZPu+HkYgNzV?=
 =?us-ascii?Q?oMuDIZoE9VjZuVOYIhHLJeRjVn7Dp57ZeSup0GkOqMScViRQhl6MLICorFpm?=
 =?us-ascii?Q?BfwRZEkSQ7G4SjS+ZLW7dwuTLwkSXnnIJHYCloYegpJQC3St+y6NWmVioCQO?=
 =?us-ascii?Q?qTI3R3adlxfIYRlMjEVCuJGKqXS6Qv3PtG7IMSZrKtmd8XY6ZBOwmKIMMQLx?=
 =?us-ascii?Q?g9VcHP9z3SnDYN6KBu7zM+W0m+RRuSaFU9j6J8I2wEMZbjMwH1ejw6Ji42VP?=
 =?us-ascii?Q?y0yeu2ZBKldsGUsfR/HKOgLw+1FiFOK4bwvccqon+s8bsbXQdhX0Uy4elJjs?=
 =?us-ascii?Q?WdGSz58pxXGbLgj+aqBRDZrHnb8K1Qu3vgJRiDbnDZzFk9lyyGz7B8HbTvNX?=
 =?us-ascii?Q?N6Mgckq2C49yfWyVA3P6XznIqMsm1zJqBveDJSj5TnNg1qeg8IOA4WFmooHN?=
 =?us-ascii?Q?qSqPsJzN/tjsGrX5y49swu7nxw2zCZpNBNoPNNfcb2L8fH7/3jBCD2x0BksK?=
 =?us-ascii?Q?DkpP4nYlhyS66L+0CvrtxAo+tMi810EIr/VQZjGQfrZ3VVm0Dj4wIsvo1hbZ?=
 =?us-ascii?Q?LRNNNTvqyZ7BVYBGmVVqtkZfK6OrDXMGDMRHnsWMhxOiwnSsfghSsJ6PygQT?=
 =?us-ascii?Q?x1nYSa3+cqDa5JhOAE60mIo1RtJhCyLDP31G48enTY4gxFIHdMVt7KDbHaq7?=
 =?us-ascii?Q?Ujr9qYA77jpFz3ZbsDZ23lP0jDdt18TEhs+3N36eYEY1BLTEh8aj8A5yCMpy?=
 =?us-ascii?Q?cyvqmiK0+XMxU6ShzPSIyNkgDHxwgIKuAtebBxUTUyAqnt9vrHwYRuotms1Z?=
 =?us-ascii?Q?ZILCOmMKQglzgTaeTEs3hDpy4TfmFQo8D5EDq9tvGHMH9Zn1DxxUVMO4TAjJ?=
 =?us-ascii?Q?g/lP/SXsOLVJZAFWQU0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HE1PR0401MB2331.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 12b89057-80b6-4bd2-84c8-08daf3e6c26a
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2023 15:16:05.5735
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gQ/qpRxjV9wPu2Jo+CChvGH6sn6LA7n0xRp2BpY3ftuC2EzqeXzUsHchLMuSh3272/O4uOTK2CLK5AupGN9HtA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7306
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Chanh Nguyen <chanh@os.amperecomputing.com>
> Sent: Wednesday, January 11, 2023 12:51 AM
> To: OpenBMC Maillist <openbmc@lists.ozlabs.org>; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>; Frank Li <frank.li@nxp.com>; Christophe
> JAILLET <christophe.jaillet@wanadoo.fr>; Dan Vacura
> <w36195@motorola.com>; Jakob Koschel <jakobkoschel@gmail.com>; Alan
> Stern <stern@rowland.harvard.edu>; Vijayavardhan Vennapusa
> <vvreddy@codeaurora.org>; Rondreis <linhaoguo86@gmail.com>; Andrzej
> Pietrasiewicz <andrzej.p@collabora.com>; Heikki Krogerus
> <heikki.krogerus@linux.intel.com>; linux-usb@vger.kernel.org; linux-
> kernel@vger.kernel.org; Open Source Submission
> <patches@amperecomputing.com>
> Cc: Chanh Nguyen <chanh@os.amperecomputing.com>
> Subject: [EXT] [PATCH v3] USB: gadget: Add ID numbers to configfs-gadget
> driver names
>=20
> Caution: EXT Email
>=20
> It is unable to use configfs to attach more than one gadget. When
> attaching the second gadget, it always fails and the kernel message
> prints out:
>=20
> Error: Driver 'configfs-gadget' is already registered, aborting...
> UDC core: g1: driver registration failed: -16
>=20
> This commit fixes the problem by using the gadget name as a suffix
> to each configfs_gadget's driver name, thus making the names
> distinct.
>=20
> Fixes: fc274c1e9973 ("USB: gadget: Add a new bus for gadgets")
> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>

Reviewed-by: Frank Li <frank.li@nxp.com>

>=20
> ---
> Changes in v3:
>   - Use the gadget name as a unique suffix instead     [Andrzej]
>   - Remove the driver.name allocation by template        [Chanh]
>   - Update commit message                                [Chanh]
>=20
> Changes in v2:
>   - Replace scnprintf() by kasprintf() to simplify the code [CJ]
>   - Move the clean up code from gadgets_drop() to
>     gadget_info_attr_release()                        [Frank Li]
>   - Correct the resource free up in gadges_make()   [Alan Stern]
>   - Remove the unnecessary variable in gadgets_make()    [Chanh]
>   - Fixes minor grammar issue in commit message          [Chanh]
> ---
>  drivers/usb/gadget/configfs.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.=
c
> index 96121d1c8df4..0853536cbf2e 100644
> --- a/drivers/usb/gadget/configfs.c
> +++ b/drivers/usb/gadget/configfs.c
> @@ -393,6 +393,7 @@ static void gadget_info_attr_release(struct
> config_item *item)
>         WARN_ON(!list_empty(&gi->string_list));
>         WARN_ON(!list_empty(&gi->available_func));
>         kfree(gi->composite.gadget_driver.function);
> +       kfree(gi->composite.gadget_driver.driver.name);
>         kfree(gi);
>  }
>=20
> @@ -1572,7 +1573,6 @@ static const struct usb_gadget_driver
> configfs_driver_template =3D {
>         .max_speed      =3D USB_SPEED_SUPER_PLUS,
>         .driver =3D {
>                 .owner          =3D THIS_MODULE,
> -               .name           =3D "configfs-gadget",
>         },
>         .match_existing_only =3D 1,
>  };
> @@ -1623,13 +1623,21 @@ static struct config_group *gadgets_make(
>=20
>         gi->composite.gadget_driver =3D configfs_driver_template;
>=20
> +       gi->composite.gadget_driver.driver.name =3D kasprintf(GFP_KERNEL,
> +                                                           "configfs-gad=
get.%s", name);
> +       if (!gi->composite.gadget_driver.driver.name)
> +               goto err;
> +
>         gi->composite.gadget_driver.function =3D kstrdup(name, GFP_KERNEL=
);
>         gi->composite.name =3D gi->composite.gadget_driver.function;
>=20
>         if (!gi->composite.gadget_driver.function)
> -               goto err;
> +               goto out_free_driver_name;
>=20
>         return &gi->group;
> +
> +out_free_driver_name:
> +       kfree(gi->composite.gadget_driver.driver.name);
>  err:
>         kfree(gi);
>         return ERR_PTR(-ENOMEM);
> --
> 2.17.1