Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 11 Jan 2023 10:24:22 -0500
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Deepak R Varma <drv@mailo.com>
CC:     Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        Praveen Kumar <kumarpraveen@linux.microsoft.com>,
        <intel-gfx@lists.freedesktop.org>,
        Saurabh Singh Sengar <ssengar@microsoft.com>,
        <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
        <intel-gvt-dev@lists.freedesktop.org>,
        Zhi Wang <zhi.a.wang@intel.com>
Subject: Re: [PATCH 2/2] drm/i915/gvt: Avoid full proxy f_ops for vgpu_status
 debug attributes
Message-ID: <Y77UpjMG9t3SIkMo@intel.com>
References: <cover.1673375066.git.drv@mailo.com>
 <188df08e0feba0cda2c92145f513dd4e57c6e6cf.1673375066.git.drv@mailo.com>
 <Y72zVXYLVHXuyK05@intel.com>
 <Y76JGj0cJpYr6/rv@intel.com>
 <Y77NfeKbLL4s/Ibg@ubun2204.myguest.virtualbox.org>
 <Y77O+0uGm1GRZnZd@intel.com>
 <Y77SsDGaZ8+BjXel@ubun2204.myguest.virtualbox.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y77SsDGaZ8+BjXel@ubun2204.myguest.virtualbox.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1PsoCFlpjgbVFQ8DpsaEe4ebIDzrpKMGu8PI/AHO4jup9uWcN/3peQ1DPbGj?=
 =?us-ascii?Q?Mn2I0EYpEYrfIJv2kXxMf3Cl+4/oz0jNiS6CJ/b8rRj/hLqPpRyykllQJttV?=
 =?us-ascii?Q?0LYtS6TJ/ZvnirFZ/sZpJU9+/RJIE9bJ4C6FwK9dWu0x/P0WG69Q8ErS30Qk?=
 =?us-ascii?Q?DVeIrVhn1GLCgbDLzSreFD5I2Fh6osBh4MteIXkXs3+2z+9EMVsy4smAtStE?=
 =?us-ascii?Q?2c8DBJmFx6/KLiGEYKIG3fxTF+FPdRorr+9V32UblY29wKj1L+KWH3fSpDxO?=
 =?us-ascii?Q?svBbi0dLzSSrUtF29KxxCP0veud4L5HRG6NPFUQpuQCdwYVRnGhyP3RQfWBo?=
 =?us-ascii?Q?5V0JR+mbZitYuKbt2fNcBAYutOhLRkfzHcp9lUGiClKalS0JAWDcYKjTmXAE?=
 =?us-ascii?Q?W2KDh3nRDr0l+b2Nsc1VTrlbPIoMBnnxq7V/uTL5i/4G5uX4kcVNy1ZTZQqN?=
 =?us-ascii?Q?J3Z+U9IGnujGA2CGoVgmgz90M7OgPJg1n+fmB9xP3BCT5Hto1Ar+eV3K8++g?=
 =?us-ascii?Q?iTnZ4FHi4ZxRCqogv+gfd4asNQo+fO5ptxKshTmOnhD4BOHH5iTEx7QSro+p?=
 =?us-ascii?Q?W0ceUbhlE9NrGuHTPHS9d9OzlHZJlxTtfW8vTkQSQvPZIKNGrY0/p5CAYokr?=
 =?us-ascii?Q?6pjAt2sz1A4fRmPvH2ei8+BJICJfZNEEUhU3h8r6TuAJpTJbHrLU8ruHfiyk?=
 =?us-ascii?Q?UUVVO8dTtLCIzEnGyJFc8iyedEYxhCqW3KmmNFwq8ryEJnZTyBqzl8k2WDuj?=
 =?us-ascii?Q?YZGe8zX9CPJpb10i5L0ZTT06Qozqe1gh93R+GbWmMnWk6tEexswiOX34o6RX?=
 =?us-ascii?Q?8woBDGdKUVdXGhT17t89mH5khjaTArt5MXOO7od4Id8xf5BY8AaXgOeWAAbi?=
 =?us-ascii?Q?ltBgwOD97Ivf9eYRg0n2croB6R7VmxAw4VVuQbIsS5OH6vGojUPjlog+bVq9?=
 =?us-ascii?Q?mw3qdCxmWj5hX8lyXENUfa/T63RjciphX2eW96ZvD7YtDjMHk0o99lnhqtjb?=
 =?us-ascii?Q?DGiLyMII/rzel1wMqUFLJIGuAfNRWS+jyf8rtHCQDypBVSEn60ziea0rJU42?=
 =?us-ascii?Q?t7zTkkQpu57g2URfnlYO9DKM3tyqoGpab7H0pHNmGmfhaDjprGGvQzCND3Uo?=
 =?us-ascii?Q?OpdotJAQCTuBd8Nkux5XElq4wm0WbvoQpbNh1L1q9P5ihWMIaW9R99CN2RXV?=
 =?us-ascii?Q?pwess5bMmeyjkE8wSvsbSlpIJuIePz3j4jHpQdq+7LY23DJSOOlnYrUuxr+O?=
 =?us-ascii?Q?MwVOwwRZ2IjLRGrovLZUJKOAwjnc5nrTbwpPLqozO6PBEAZs8ilCoJ8CldGM?=
 =?us-ascii?Q?ZWyUCBWV6wzz/gRs3YEmXr3Phxn+NlSHKx3s4s12aN6sGxuHp04N/d4DgTxG?=
 =?us-ascii?Q?OXT8OfbO0t3HjRDKFWwpVxLRuh/Z/afTCgEFZ6yH9S58kq77I9hSDrB97YSd?=
 =?us-ascii?Q?4Uj9v6kJ74lNAjYpBo9xYKeel1cpUGcVVN7w/UuPiX6cZn35qGk+4AQD5GlA?=
 =?us-ascii?Q?0OK2/aL2bS1v0/zsNsvWQ0SGB2P8UtwjOdfR3yb4wHMgB0P0wPFH0k75P81q?=
 =?us-ascii?Q?OTNwBWgGVbloLMgBo0aZVFJqrvw+QjHg6y6mdtW45MFIAvYlW1R3XG9O1tRK?=
 =?us-ascii?Q?1w=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cc848206-8e65-4a3f-2333-08daf3e7ece2
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 15:24:27.2336
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rSloRoZpximqVlu2EOqYhVs1LII4BM85va0x0J48m+V5qblrkP4PuSa2vo+tAzgTmtFyYhbYpk38U5828ZPkxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4705
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 11, 2023 at 08:46:00PM +0530, Deepak R Varma wrote:
> On Wed, Jan 11, 2023 at 10:00:11AM -0500, Rodrigo Vivi wrote:
> > > > Actually, could you please address the checkpatch issues before we can push?
> > > > Sorry about that, but just noticed now when I was going to push the other ones.
> > > 
> > > Hello Rodrigo,
> > > The checkpatch warning is associated with the long "make coccicheck ..." command
> > > in the commit message. It is not part of the code, so is should not be carried
> > > forward into the code base.
> > > If you still want me to correct it, I will need to split it into two lines which
> > > I think still violates the commit description guidelines.
> > 
> > This part I would just ignore or fix myself while merging. But the next one about
> > the parenthesis alignment need to be fixed in the code so we need another version.
> > Since we try to avoid touching the code between CI and merge.
> 
> I am sorry, but I am unable to locate the "second checkpatch complaint" you are
> referring to. I have received only the following from the checkpatch robot:
> 
> == Summary ==
> 
> Error: dim checkpatch failed
> 4c95e9b71212 drm/i915/gvt: Avoid full proxy f_ops for scan_nonprivbb debug attributes
> -:21: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
> #21:
> make coccicheck M=drivers/gpu/drm/i915/ MODE=patch COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
> 
> total: 0 errors, 1 warnings, 0 checks, 22 lines checked
> 33d68a01cad3 drm/i915/gvt: Avoid full proxy f_ops for vgpu_status debug attributes
> -:21: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
> #21:
> make coccicheck M=drivers/gpu/drm/i915/ MODE=patch COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
> 
> total: 0 errors, 1 warnings, 0 checks, 18 lines checked
> 

doh, my bad! this gvt patch is indeed right. up to gvt folks to modify this line
when merging or to ignore...

The problem I mentioned was in the other series. Sorry for the noise.

but for the record:

-:47: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#47: FILE: drivers/gpu/drm/i915/display/intel_drrs.c:386:
+	debugfs_create_file_unsafe("i915_drrs_ctl", 0644, crtc->base.debugfs_entry,
+				    crtc, &intel_drrs_debugfs_ctl_fops);


> ===============================
> 
> > 
> > Then, since you need to change that, while changing that, also please break
> > the coccinelle line in the commit msg.
> > 
> > I'd appreciate to have the patch for the pxp as well :)
> 
> Sure. As mentioned in the other thread, I am looking into it and would submit a
> patch accordingly.
> 
> Thank you,
> ./drv
> 
> > 
> > Thanks a lot,
> > Rodrigo.
> > 
> > 
> > > 
> > > Let me know what you think.
> > > 
> > > Thank you,
> > > ./drv
> > > 
> > > > 
> > > > > 
> > > > > > ---
> > > > > >  drivers/gpu/drm/i915/gvt/debugfs.c | 6 +++---
> > > > > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > > > > 
> > > > > > diff --git a/drivers/gpu/drm/i915/gvt/debugfs.c b/drivers/gpu/drm/i915/gvt/debugfs.c
> > > > > > index 03f081c3d9a4..baccbf1761b7 100644
> > > > > > --- a/drivers/gpu/drm/i915/gvt/debugfs.c
> > > > > > +++ b/drivers/gpu/drm/i915/gvt/debugfs.c
> > > > > > @@ -165,7 +165,7 @@ static int vgpu_status_get(void *data, u64 *val)
> > > > > >  	return 0;
> > > > > >  }
> > > > > >  
> > > > > > -DEFINE_SIMPLE_ATTRIBUTE(vgpu_status_fops, vgpu_status_get, NULL, "0x%llx\n");
> > > > > > +DEFINE_DEBUGFS_ATTRIBUTE(vgpu_status_fops, vgpu_status_get, NULL, "0x%llx\n");
> > > > > >  
> > > > > >  /**
> > > > > >   * intel_gvt_debugfs_add_vgpu - register debugfs entries for a vGPU
> > > > > > @@ -182,8 +182,8 @@ void intel_gvt_debugfs_add_vgpu(struct intel_vgpu *vgpu)
> > > > > >  			    &vgpu_mmio_diff_fops);
> > > > > >  	debugfs_create_file_unsafe("scan_nonprivbb", 0644, vgpu->debugfs, vgpu,
> > > > > >  				   &vgpu_scan_nonprivbb_fops);
> > > > > > -	debugfs_create_file("status", 0644, vgpu->debugfs, vgpu,
> > > > > > -			    &vgpu_status_fops);
> > > > > > +	debugfs_create_file_unsafe("status", 0644, vgpu->debugfs, vgpu,
> > > > > > +				   &vgpu_status_fops);
> > > > > >  }
> > > > > >  
> > > > > >  /**
> > > > > > -- 
> > > > > > 2.34.1
> > > > > > 
> > > > > > 
> > > > > > 
> > > 
> > > 
> 
>