Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <00e70137-3cc3-877e-5435-ac15f750f466@linaro.org>
Date:   Wed, 11 Jan 2023 16:01:58 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH V8 2/2] firmware: qcom: scm: Add wait-queue handling logic
Content-Language: en-US
To:     Sibi Sankar <quic_sibis@quicinc.com>, andersson@kernel.org
Cc:     agross@kernel.org, linux-arm-msm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
        konrad.dybcio@somainline.org, robimarko@gmail.com,
        quic_gurus@quicinc.com
References: <20230111101718.9225-1-quic_sibis@quicinc.com>
 <20230111101718.9225-3-quic_sibis@quicinc.com>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
In-Reply-To: <20230111101718.9225-3-quic_sibis@quicinc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/01/2023 10:17, Sibi Sankar wrote:
> +static int qcom_scm_waitq_wakeup(struct qcom_scm *scm, unsigned int wq_ctx, bool wake_all)
> +{
> +	int ret;
> +
> +	ret = qcom_scm_assert_valid_wq_ctx(wq_ctx);
> +	if (ret)
> +		return ret;
> +
> +	if (wake_all)
> +		complete_all(&__scm->waitq_comp);

As you explained in v7 that there will be only one caller at any point 
in time and that will be synchronous, so complete_all here is a dead 
code, isn't it?

Adding complete_all here is missleading and will require reinit 
completion in case you want to reuse the same completion.

AFAIU, you should remove support to wake_all in this patchset and add it 
when we really can do multiple scm calls simultaneously.

--srini

--srini
> +	else
> +		complete(&__scm->waitq_comp);
> +