Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 11 Jan 2023 18:00:25 +0100
From:   Johan Hovold <johan@kernel.org>
To:     Ilpo =?utf-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>
Cc:     linux-serial@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Samuel Iglesias =?utf-8?Q?Gons=C3=A1lvez?= 
        <siglesias@igalia.com>, Rodolfo Giometti <giometti@enneenne.com>,
        Oliver Neukum <oneukum@suse.com>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 13/13] usb/serial: Rename dtr/rts parameters/variables
 to active
Message-ID: <Y77rKQfIYyiPwz3S@hovoldconsulting.com>
References: <20230111142331.34518-1-ilpo.jarvinen@linux.intel.com>
 <20230111142331.34518-14-ilpo.jarvinen@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230111142331.34518-14-ilpo.jarvinen@linux.intel.com>
Precedence: bulk

On Wed, Jan 11, 2023 at 04:23:31PM +0200, Ilpo Järvinen wrote:
> Use active consistently for naming parameters and variables.
> This converts all USB serial drivers + CDC-ACM.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
>  drivers/usb/class/cdc-acm.c          | 4 ++--
>  drivers/usb/serial/ch341.c           | 4 ++--
>  drivers/usb/serial/cp210x.c          | 6 +++---
>  drivers/usb/serial/cypress_m8.c      | 6 +++---
>  drivers/usb/serial/digi_acceleport.c | 6 +++---
>  drivers/usb/serial/f81232.c          | 4 ++--
>  drivers/usb/serial/f81534.c          | 4 ++--
>  drivers/usb/serial/ftdi_sio.c        | 6 +++---
>  drivers/usb/serial/ipw.c             | 8 ++++----
>  drivers/usb/serial/keyspan.c         | 6 +++---
>  drivers/usb/serial/keyspan_pda.c     | 4 ++--
>  drivers/usb/serial/mct_u232.c        | 6 +++---
>  drivers/usb/serial/mxuport.c         | 4 ++--
>  drivers/usb/serial/pl2303.c          | 4 ++--
>  drivers/usb/serial/quatech2.c        | 6 +++---
>  drivers/usb/serial/sierra.c          | 6 +++---
>  drivers/usb/serial/spcp8x5.c         | 4 ++--
>  drivers/usb/serial/ssu100.c          | 6 +++---
>  drivers/usb/serial/upd78f0730.c      | 4 ++--
>  drivers/usb/serial/usb-serial.c      | 4 ++--
>  drivers/usb/serial/usb-wwan.h        | 2 +-
>  drivers/usb/serial/usb_wwan.c        | 6 +++---
>  drivers/usb/serial/xr_serial.c       | 4 ++--
>  23 files changed, 57 insertions(+), 57 deletions(-)

You should split this up as CDC-ACM is not a USB serial driver.

But this all seem like unnecessary churn to me. It was one thing
changing the parameter name in drivers that used something ambiguous
like 'on_off' but 'on' is just as clear as 'active' (and its shorter
too).

So please drop at least the USB serial changes as all drivers already
use 'on' consistently. 

Johan