Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp9799237rwl; Wed, 11 Jan 2023 10:05:43 -0800 (PST) X-Google-Smtp-Source: AMrXdXteft9tkVY8GiBxcB/7SiCwxsbIWlcFr6LGRTnp5oPBfx5eDuXYT8Df+iCyh/RwXSdz5ijx X-Received: by 2002:a17:907:c498:b0:7ff:7876:9c60 with SMTP id tp24-20020a170907c49800b007ff78769c60mr64166309ejc.15.1673460343736; Wed, 11 Jan 2023 10:05:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673460343; cv=none; d=google.com; s=arc-20160816; b=XT47evNH11PvFuiumlTmTQZj7+qhGRPTuwcp3gP9zDQJ+khcefn+SmYj+e4dUmkHlB 9aPHxly2ZgGbuNBQSmxPznn1LIgnSrwCq+NlZznO3CQB7W+yoPtZueXRrDoYvG8vZ9zn oTqq0Hxwjk9sYUttFunqBdiXYKkmE9SN4KXSGB8+T8ILmRmws7OuOCEjvMQpiBoKOrdc qGzUil3jUJSWBUcYgeFx56Ik2b/HcE04IU5ktFv/+f7+vsACYGrYTO5uwSh8CJf6b2ty zcoswiBX48SYiPtwlJDz64MfdxO0SmZA28QHfyawopNj9rbH4QAQixjcpo6QpSsD5rDl 0udg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=y7H0W/uI4oGcl9EUNvfzo202w7sogjK57bIVY0+8yC4=; b=BJN5n3WQzuA5RU5Ng6G0xnZmHKwbgdkYjt/3np7kTowlx4pVmviBWhV6+msvyNdsRn Po+z9x0VjPahbUdluUw2XraoZtyFaE3jak/AO9fCwkWQjkKgGBplxillJJPB41zMaWSy T2tX+/Mkw2BjN7x8VzsJ/0oQ2oHmqQUE54/iOlJg8h9OAHZL/uN0fuVFOgoPI0rv0Nsl jfhqkNFcZi1XjeOYbN2Y5WOiai99eGfsB6RxH9dflQFoDbd4FsBYh13S6JHXWn4MQcbl U0N+x4GABw9a5YRt/DH8/pyq85od3sDvnM98LJfgCYNEmGU45YSHG5aQLBSFDwjx30TM h+QA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IqSpmunt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o2-20020a1709061b0200b007c158ddfba4si4772983ejg.295.2023.01.11.10.05.30; Wed, 11 Jan 2023 10:05:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IqSpmunt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229511AbjAKR36 (ORCPT + 51 others); Wed, 11 Jan 2023 12:29:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239865AbjAKR31 (ORCPT ); Wed, 11 Jan 2023 12:29:27 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88BCA395DF; Wed, 11 Jan 2023 09:27:42 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id F1C02CE1B0D; Wed, 11 Jan 2023 17:27:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2100DC433EF; Wed, 11 Jan 2023 17:27:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673458059; bh=/miXrqCOjiG0Qs8BlvyFBFYxjZFoCwZzpXeOHMETUtc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IqSpmuntV2Ie6MwaRXSZyBhgJd2+W2VU4+4PRmnt6xf0q7f27CkhVJ/nU80EI6XKA KSeU1+/3ZlmMmyEaNIDyRU5qzxRjwL4cHv2eFBK2ZIuh83g3l5yaTTAppf8ad5GXlK um4sPN8jlWoKgrxtru75myWH6z8HvqkJSvNK4ZnnClcQ4h3IoXd2wm2gUczs8g8Bgi JZd0udB4prUz3FfEQQxQa5S7AmPTCgBAT5hI7ahJxthMrhu3cFKfHF1gG3PNGT/It5 j5vCVp+SQ+9igBlETn8PKZB5LvMKmb5p9v9vhEDcWyL30dm+Xad1Fygid/vZpK0ahF vJNcSydSbXp4g== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pFet5-00049L-Vs; Wed, 11 Jan 2023 18:27:44 +0100 Date: Wed, 11 Jan 2023 18:27:43 +0100 From: Johan Hovold To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= Cc: linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Samuel Iglesias =?utf-8?Q?Gons=C3=A1lvez?= , Rodolfo Giometti , "David S. Miller" , linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v3 08/13] tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool active Message-ID: References: <20230111142331.34518-1-ilpo.jarvinen@linux.intel.com> <20230111142331.34518-9-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230111142331.34518-9-ilpo.jarvinen@linux.intel.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 11, 2023 at 04:23:26PM +0200, Ilpo Järvinen wrote: > Convert status parameter for ->dcd_change() and > uart_handle_dcd_change() to bool which matches to how the parameter is > used. > > Rename status to active to better describe what the parameter means. > > Acked-by: Rodolfo Giometti > Reviewed-by: Jiri Slaby > Signed-off-by: Ilpo Järvinen > --- > drivers/pps/clients/pps-ldisc.c | 6 +++--- > drivers/tty/serial/serial_core.c | 8 ++++---- > drivers/tty/serial/sunhv.c | 8 ++++---- > drivers/usb/serial/generic.c | 10 +++++----- > include/linux/serial_core.h | 3 +-- > include/linux/tty_ldisc.h | 4 ++-- > include/linux/usb/serial.h | 2 +- > 7 files changed, 20 insertions(+), 21 deletions(-) Same here, split out the USB serial changes in a separate series. Johan