Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp9880787rwl; Wed, 11 Jan 2023 11:15:29 -0800 (PST) X-Google-Smtp-Source: AMrXdXstOz53sTNFlpvNehaY7xsMh7vsF1dl/sVFR2ViT+RN9SQyPzTcdAJcn1oTSRHyhig2Z0do X-Received: by 2002:a05:6402:38a:b0:499:d239:29bd with SMTP id o10-20020a056402038a00b00499d23929bdmr4862087edv.5.1673464529442; Wed, 11 Jan 2023 11:15:29 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1673464529; cv=pass; d=google.com; s=arc-20160816; b=jPNauFCFOk5jE0zzDX8+hnxw42J8qX5RRYxZfnFHZYrhOLxU+SO0Vhm9q4zPs5tuQ2 8tijKosg+CAy7Y8FFtIHDs9dj4LB0sBWQSwJUvTx6C5MdPE3zU65Ss+ILsNAqDGxcv6U UUyZHpRAWVlwdWUEAb/iTu6XXhLE+SH8QJ3+DwfpCUVq8E3pHUEelM62Lg5PTiWu28ax TNOxCSSaJ+UwD2YoZaVJDOUWbN1BPUwFsYEOpC0stZSPjpTDI4G5Oid3hOovSALjGH6+ J0C2yu/5YsD9fUAWOSgRrFcHgto6l89jKwD3SQumrWIjz/UGl907K+e8R6RvtJRa1nJM wShA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:importance:content-transfer-encoding :mime-version:subject:references:in-reply-to:message-id:cc:to:from :date:dkim-signature; bh=6fcdNPybl+xUYpUP49ToyIcYZNVnjP3wgQCGB02TB14=; b=fhnHAKb5P7QJhpBLHUx0iuDiAmSsNd61Fn0KOruvomaGhC9u1VpoSA+947K9yNsHIf ehq1FjorUdRsOxsZEd9SMRLtYOdny28237YXKi4XYKwZ19vNaoFl2R2b2dHXW4SxiRDs 6WWyyL+Ts5wE80IX4u4DhQ7RM90k4yDRcP4v/K5SVdOZ+C2hhFKawbkzPwnpiENLPFlX KPAyO6fo+B537JiQWZO+/awt01bYcEMjcy22Hhkox6ufuLYVk9k7zNormS8nKcYycO05 GKFlzvpurQzipNjWDe3YFm6tbmQKI4mkp3Ak9tDI1urPvdgojs7iUDAwgbaqoRRTofNl E6+g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@siddh.me header.s=zmail header.b=XsVyyOmz; arc=pass (i=1 spf=pass spfdomain=siddh.me dkim=pass dkdomain=siddh.me dmarc=pass fromdomain=siddh.me>); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siddh.me Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j14-20020a05640211ce00b0046cdae33434si17514571edw.333.2023.01.11.11.15.16; Wed, 11 Jan 2023 11:15:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@siddh.me header.s=zmail header.b=XsVyyOmz; arc=pass (i=1 spf=pass spfdomain=siddh.me dkim=pass dkdomain=siddh.me dmarc=pass fromdomain=siddh.me>); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siddh.me Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235608AbjAKSLl (ORCPT + 51 others); Wed, 11 Jan 2023 13:11:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234506AbjAKSLg (ORCPT ); Wed, 11 Jan 2023 13:11:36 -0500 Received: from sender-of-o50.zoho.in (sender-of-o50.zoho.in [103.117.158.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB37336319; Wed, 11 Jan 2023 10:11:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673460649; cv=none; d=zohomail.in; s=zohoarc; b=XK334mSDM5kmOwB83c6m3XjQpBNidXCnQRa0Kt8LxfcLp9/P6LKxmi1yeR8kABg7cDRm7uXwI87q3kPp9xsCmkrP8cJXaVmzBGg78fwkKruXv3AdkQppr2Q5o9tGu/kdaeF1M0qhUViteMnqluk12JePT6hLgjF1oQNxOX2iVXA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.in; s=zohoarc; t=1673460649; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=6fcdNPybl+xUYpUP49ToyIcYZNVnjP3wgQCGB02TB14=; b=GzhuBHGBTW2k6dsILLUtk0IpsEc0Thfwi3umO3FTt0O3rOl6RboYc0Jt3djtt6EJrY3vPAxvUcntVFkBh+2O3Nj3jPrUXgDIkgHajFFoz4V0nwaIQeyVgReh8v9ftile2ynZ/XGS1+wW0FcGsDdbjHLb9zBilrDk3pgZU6UMYYM= ARC-Authentication-Results: i=1; mx.zohomail.in; dkim=pass header.i=siddh.me; spf=pass smtp.mailfrom=code@siddh.me; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1673460649; s=zmail; d=siddh.me; i=code@siddh.me; h=Date:Date:From:From:To:To:Cc:Cc:Message-ID:In-Reply-To:References:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=6fcdNPybl+xUYpUP49ToyIcYZNVnjP3wgQCGB02TB14=; b=XsVyyOmzz2c7qO+tfmyaDoAhPhPtr4o31hhMHfbjR9AT0O+k+G+opfb6sRRRvEQJ VtF1850edm1idJrb4evO5j8YkQwoaOdMF8bXWIqI5WwgaGssFndVnWL7yHYVZCm9DJ7 uVD+8td/4ZS/VSG80WkbwrQsMvOvnOKTCBBSKfsQ= Received: from mail.zoho.in by mx.zoho.in with SMTP id 1673460638656299.0457988820257; Wed, 11 Jan 2023 23:40:38 +0530 (IST) Date: Wed, 11 Jan 2023 23:40:38 +0530 From: Siddh Raman Pant To: "David Howells" Cc: "mauro carvalho chehab" , "randy dunlap" , "jonathan corbet" , "fabio m. de francesco" , "eric dumazet" , "christophe jaillet" , "eric biggers" , "keyrings" , "linux-security-module" , "linux-fsdevel" , "linux-kernel" Message-ID: <185a206e3b0.2e1071428037.6356107010427889199@siddh.me> In-Reply-To: <2433039.1673455048@warthog.procyon.org.uk> References: <20230111161934.336743-1-code@siddh.me> <2433039.1673455048@warthog.procyon.org.uk> Subject: Re: [PATCH v4] kernel/watch_queue: NULL the dangling *pipe, and use it for clear check MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Importance: Medium User-Agent: Zoho Mail X-Mailer: Zoho Mail X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Jan 2023 22:07:28 +0530, David Howells wrote: > Seems reasonable. Have you run it with the keyutils testsuite? > > David I had not, but I did now. I first ran all the keyctl tests with ./runtest.sh keyctl/**/* All of them passsed. Log: https://pastebin.com/PBm6h5E2 All tests in tests/ pass except features/builtin_trusted, which fails even without the patch. (Failure log: https://pastebin.com/SGgAbzXp) Thanks, Siddh