Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
From:   Rob Herring <robh@kernel.org>
To:     Wadim Egorov <w.egorov@phytec.de>
Cc:     a.zummo@towertech.it, krzysztof.kozlowski+dt@linaro.org,
        riku.voipio@iki.fi, robh+dt@kernel.org, pavel@ucw.cz,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        alexandre.belloni@bootlin.com, linux-rtc@vger.kernel.org,
        lee@kernel.org, linux-leds@vger.kernel.org,
        upstream@lists.phytec.de
In-Reply-To: <20230111163404.3526248-1-w.egorov@phytec.de>
References: <20230111163404.3526248-1-w.egorov@phytec.de>
Message-Id: <167346265519.1103752.16521267476598663004.robh@kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: leds: Convert PCA9532 to dtschema
Date:   Wed, 11 Jan 2023 12:47:13 -0600
Precedence: bulk


On Wed, 11 Jan 2023 17:34:03 +0100, Wadim Egorov wrote:
> Convert the PCA9532 LED dimmer to dtschema.
> While at it, also update and the the example to match
> recommended node names and the link to the product datasheet.
> 
> Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
> ---
> v2:
>   - Rename yaml file to match compatibles, nxp,pca953x.yaml
>   - Remove Jacek Anaszewski from maintainers list
>   - Remove color labels in example
>   - Restore labels/default-states from original example
>   - Drop reg description
>   - Add unevaluatedProperties to patternProperties scope
>   - Update description of type property & set default to 0
>   - Fix indentation in example
> ---
>  .../devicetree/bindings/leds/leds-pca9532.txt | 49 -----------
>  .../devicetree/bindings/leds/nxp,pca953x.yaml | 85 +++++++++++++++++++
>  2 files changed, 85 insertions(+), 49 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/leds/leds-pca9532.txt
>  create mode 100644 Documentation/devicetree/bindings/leds/nxp,pca953x.yaml
> 

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230111163404.3526248-1-w.egorov@phytec.de


leddimmer@62: 'led1', 'led2', 'led3', 'led4' do not match any of the regexes: '^led-[0-9a-z]+$', 'pinctrl-[0-9]+'
	arch/arm/boot/dts/rk3288-phycore-rdk.dtb

leds@62: 'led1', 'led2', 'led3' do not match any of the regexes: '^led-[0-9a-z]+$', 'pinctrl-[0-9]+'
	arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dtb

pca9530@61: 'tft-panel@0' does not match any of the regexes: '^led-[0-9a-z]+$', 'pinctrl-[0-9]+'
	arch/arm/boot/dts/am335x-pdu001.dtb

pca9532@60: '#gpio-cells', 'gpio-controller' do not match any of the regexes: '^led-[0-9a-z]+$', 'pinctrl-[0-9]+'
	arch/arm/boot/dts/lpc3250-ea3250.dtb

pca9532@60: 'psc0', 'psc1', 'pwm0', 'pwm1', 'run.green@1', 'run.red@0', 's1.green@5', 's1.yellow@4', 's2.green@3', 's2.red@2' do not match any of the regexes: '^led-[0-9a-z]+$', 'pinctrl-[0-9]+'
	arch/arm/boot/dts/am335x-pdu001.dtb