Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 11 Jan 2023 19:40:38 +0100
From:   David Sterba <dsterba@suse.cz>
To:     Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc:     zys.zljxml@gmail.com, clm@fb.com, josef@toxicpanda.com,
        dsterba@suse.com, linux-btrfs@vger.kernel.org,
        linux-kernel@vger.kernel.org, Yushan Zhou <katrinzhou@tencent.com>
Subject: Re: [PATCH v3] btrfs: use PAGE_{ALIGN, ALIGNED, ALIGN_DOWN} macro
Message-ID: <20230111184037.GI11562@twin.jikos.cz>
Reply-To: dsterba@suse.cz
References: <20230103051137.4085572-1-zys.zljxml@gmail.com>
 <87d14908-dc9d-7ce4-c594-b28a9991efbb@gmx.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87d14908-dc9d-7ce4-c594-b28a9991efbb@gmx.com>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)
Precedence: bulk

On Tue, Jan 03, 2023 at 01:47:43PM +0800, Qu Wenruo wrote:
> 
> 
> On 2023/1/3 13:11, zys.zljxml@gmail.com wrote:
> > From: Yushan Zhou <katrinzhou@tencent.com>
> > 
> > The header file linux/mm.h provides PAGE_ALIGN, PAGE_ALIGNED,
> > PAGE_ALIGN_DOWN macros. Use these macros to make code more
> > concise.
> 
> Is there anything benefit from the change?
> 
> In fact, PAGE_ALIGN()/PAGE_ALIGNED() is just using the same 
> ALIGN()/IS_ALIGNED() macro.
> 
> Thus I don't think your change is of any usefulness, not to mention it's 
> going to introduce confusion and extra effort.
> 
> I'm completely fine with regular ALIGN()/IS_ALIGNED() usage with PAGE_SIZE.

We already have PAGE_ALIGN in some places and I think it's a bit better
than the ALIGN/IS_ALIGN as it's clear that it's for a page.