Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 11 Jan 2023 20:45:55 +0000
From:   Al Viro <viro@zeniv.linux.org.uk>
To:     Thomas =?iso-8859-1?Q?Wei=DFschuh?= <linux@weissschuh.net>
Cc:     Andrey Vagin <avagin@openvz.org>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Serge Hallyn <serge@hallyn.com>, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, Karel Zak <kzak@redhat.com>
Subject: Re: [PATCH RESEND v3] nsfs: add compat ioctl handler
Message-ID: <Y78gAyuFHtOcWKVB@ZenIV>
References: <20221214-nsfs-ioctl-compat-v3-1-dce2d26e1fec@weissschuh.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221214-nsfs-ioctl-compat-v3-1-dce2d26e1fec@weissschuh.net>
Sender: Al Viro <viro@ftp.linux.org.uk>
Precedence: bulk

On Wed, Jan 11, 2023 at 04:46:30PM +0000, Thomas Wei?schuh wrote:
> As all parameters and return values of the ioctls have the same
> representation on both 32bit and 64bit we can reuse the normal ioctl
> handler for the compat handler via compat_ptr_ioctl().
> 
> All nsfs ioctls return a plain "int" filedescriptor which is a signed
> 4-byte integer type on both 32bit and 64bit.
> The only parameter taken is by NS_GET_OWNER_UID and is a pointer to a
> "uid_t" which is a 4-byte unsigned integer type on both 32bit and 64bit.
> 
> Fixes: 6786741dbf99 ("nsfs: add ioctl to get an owning user namespace for ns file descriptor")
> Reported-by: Karel Zak <kzak@redhat.com>
> Link: https://github.com/util-linux/util-linux/pull/1924#issuecomment-1344133656
> Signed-off-by: Thomas Wei?schuh <linux@weissschuh.net>

Applied...