Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6390de72-36c8-39ea-7ece-eed0b464359a@intel.com>
Date:   Wed, 11 Jan 2023 14:04:54 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.6.1
Subject: Re: [PATCH v11 11/13] x86/resctrl: Add interface to write
 mbm_total_bytes_config
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <20230109164405.569714-1-babu.moger@amd.com>
 <20230109164405.569714-12-babu.moger@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230109164405.569714-12-babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTZnSUhxSmpTMG5OSE10a2kzTVc0Y1BLUU1td0h5ck9qTmQ3MzFQOWxkQXUz?=
 =?utf-8?B?MloxODRhQWtqaysxcFhPcFhQTjVVWFBmSGVSNWNONFZYdkI4RllNQjkzakZF?=
 =?utf-8?B?UkNSelIrWmNKVzNJRnc3RG5RNEFDYXpOQzNCcHh2S0l2QTl6Y0VkVWl5OFBx?=
 =?utf-8?B?RlZGSFVKZUtXVjFTNVlZcmFGTFpSaVFvaUVuWFJ4QkhtTzlmVzlwL2hNQWtV?=
 =?utf-8?B?OTdpZzZNUTFEbGtXMDdob1FCUWl1bU9TVXE2c1lGWjZCQnp3bllUWGwyQ1p4?=
 =?utf-8?B?T1NqMWhqcFdQTWsyQzA2VUJ2S0ZNV0J6OGsxOFBMcVJqWWI2aHg5WkxrOXVT?=
 =?utf-8?B?QmZjb1U3TmhRQXRsWEhrNGZ1QjVtNnRURE5lRjFCalNGS2E4eDNHTHVCT0Zn?=
 =?utf-8?B?NWc4Nm5HK3RFbDNxdWQzOGlmUW9OOW1HSzBxdUhVdWFvNXdyMitRWEZsWUhF?=
 =?utf-8?B?b216NWxPK1Vza0JzWGl0bWZwSFdCcDFOM2xCSzNnWmlLVWp3VjZFS2ZSa2p4?=
 =?utf-8?B?c29KZk95cFltNGFUN1FhRGtxRzJJeDczNTgwcStRTHg4WENLZC9NZDFOUVBN?=
 =?utf-8?B?TGs1aHZsRFZzSXlEZWVyZTRrRVhOMFpCblRwNHZ4eVNiYXR3MTU2SFB2a1FC?=
 =?utf-8?B?QVZkb3NlNDV1ZFNNL1hZZ3d2NThueG9Xc2pyMmI5VjRyT2dkTVYwRG5FT0J0?=
 =?utf-8?B?SVJYbS90NjRxUzNPU2kvSTEyT3JWTVF5SFBOSXVXNjNESmJEbTAxMndYUm1Q?=
 =?utf-8?B?cnlCNHo5SDY5SHU4NThnRk1WZkJqdEJqZG8rKzhBb0REMkpHL1VDQlhRVy9J?=
 =?utf-8?B?RHNjR1dzeHVtNHI0ZGF4SzNaRVVjTEExUXN2ajVYR01rQmlDZzQzWmIrcnNJ?=
 =?utf-8?B?ZGFKQXloQUM5Z0hIbkhDSU01M3g0cERxRU5STmpaNkhhelYrcDBOdXYweEdK?=
 =?utf-8?B?YzI3Y2lwY1ZZWWVOeThVMk1xZi93bUJsZVNob0tpQ0dYSmNSZUNmTVdEaVl3?=
 =?utf-8?B?ZzVoQkI5SFdaMXc1U2VkWUJvWTh4Ri9NejlLdlppY3hiOWYrV1R0azVQUk1U?=
 =?utf-8?B?RTU1YjhaVFhYQ3hPeEZaQWQ1OFEzQXNkdXEzZlFqWDVEeU43bFFBR29YbEN6?=
 =?utf-8?B?ZTJsc3FSSVZ3bFVBRkx4cGxIeEh1SDF3eVZTbkEvYkF5UGJmVjhaVndEbksy?=
 =?utf-8?B?MitxTVUzSHZPT1pIV3lPdFRoc0RaNVA3VnpTQzlMRkRIQUJwQXRpRUZDRDVu?=
 =?utf-8?B?b2kzQjJwVWZzdnFrTC9UdDdjYldhWDVkQ3hCWWhOMkNadXJiN2RMM1FjQlIy?=
 =?utf-8?B?QXhHN2xxK0FoeDQxeUNLQm9TRDY4V2ZCOGpkZnBIMjBiNlFOUVBjL0RNZHBJ?=
 =?utf-8?B?N1BZUTJ3RTBLS25GQS93S3Nvb3prKzIwbWdxL2dZLzI1VG5QTnV0RUU1R2h0?=
 =?utf-8?B?YlU2aVM3YXdPQU9lYVhma08wSU9IVXg1TjdpaWpUdldVWVJvQkdMV0l6SUJt?=
 =?utf-8?B?ZXYzQVY1TzRBKy9nSVNGb2JjT3ZLWlY4TFZWa3lsYUZBMDFQdUhSNUJCTXhO?=
 =?utf-8?B?enhxRDJnWGlwV29tK3k0bVhwbm5vVnVwSkI3b0IzQW95RTM0YnVGT1RZTXdV?=
 =?utf-8?B?bkliazVwMk5YMndHSjR3RUdtMlo0ZkQzMzdkdkJCTGdZbE9RM2NYaHdsZ0ZM?=
 =?utf-8?B?RlNidjNuN3dBQ1pvaGIyUTBvMmMxUkR6SU5PL2hTV3JiYnE5b0YxK2lLWE1x?=
 =?utf-8?B?NnZ4UTJOdnQ0TXpXTUZHdDBOdzhZbXdtV1ZFd3hDZEt0ZHVWTm9xTElyelBo?=
 =?utf-8?B?S3o1RHdFL2NlSnI5N0VHdjEzTWZnWDBmYWhzcmN3MWVMUGVaNFF0aXhrVmxk?=
 =?utf-8?B?SzF1a0o0Z3BvUktobVhnZ1NSSCt3YVlBYkYxa2MwQis2L1pSbEpKR0VKQng0?=
 =?utf-8?B?cDNhbko3NjBoVmNyU3poa1VXNG9aZzVqK25kN0xSL1doQXRBcDBaV2p2cWlt?=
 =?utf-8?B?ZWRTaC85WXc1NDZyclFveCs2cUsrM0djZ3liTzlJQ3NtL3EwWTJUWnJneGhV?=
 =?utf-8?B?dU9qK0l6RHpqdXdCaXhLVHJsZzlLNmIwODV5cktrU1gzUFhHUXh4T3hUNXpp?=
 =?utf-8?B?UkZHcC9BRVZvbkI0MnRINzBOY1JCUk4wYkVuSldQR3pqcDg3M0NidFUyQ2tH?=
 =?utf-8?B?Z0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d5678a0-cff1-4540-136c-08daf41fe15d
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 22:04:59.1172
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L4ai48VasIEMsC+K+n6ddOhqIFLWNUc0518OQctl3XDqb/DrBRiQnDdFQYGWFrLy1Yl+cJMmpV5cWrbt71bqDRbn9ZykV9j3IoMcDJc8T9k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4706
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 1/9/2023 8:44 AM, Babu Moger wrote:
> The event configuration for mbm_total_bytes can be changed by the user by
> writing to the file /sys/fs/resctrl/info/L3_MON/mbm_total_bytes_config.
> 
> The event configuration settings are domain specific and affect all the
> CPUs in the domain.
> 
> Following are the types of events supported:
> 
> ====  ===========================================================
> Bits   Description
> ====  ===========================================================
> 6      Dirty Victims from the QOS domain to all types of memory
> 5      Reads to slow memory in the non-local NUMA domain
> 4      Reads to slow memory in the local NUMA domain
> 3      Non-temporal writes to non-local NUMA domain
> 2      Non-temporal writes to local NUMA domain
> 1      Reads to memory in the non-local NUMA domain
> 0      Reads to memory in the local NUMA domain
> ====  ===========================================================
> 
> For example:
> To change the mbm_total_bytes to count only reads on domain 0, the bits
> 0, 1, 4 and 5 needs to be set, which is 110011b (in hex 0x33). Run the
> command.
>         $echo  0=0x33 > /sys/fs/resctrl/info/L3_MON/mbm_total_bytes_config
> 
> To change the mbm_total_bytes to count all the slow memory reads on
> domain 1, the bits 4 and 5 needs to be set which is 110000b (in hex 0x30).
> Run the command.
>         $echo  1=0x30 > /sys/fs/resctrl/info/L3_MON/mbm_total_bytes_config
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Thank you

Reinette