Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp10150487rwl; Wed, 11 Jan 2023 15:28:23 -0800 (PST) X-Google-Smtp-Source: AMrXdXu3KKoplEt0eUuLuIl9dfmZbZFQkKB9Q9I/jhfgi5F8ipj3VutX9XcGROV04yCe2xdWEHWz X-Received: by 2002:a05:6a20:9399:b0:ad:a277:eeee with SMTP id x25-20020a056a20939900b000ada277eeeemr82307752pzh.45.1673479703094; Wed, 11 Jan 2023 15:28:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673479703; cv=none; d=google.com; s=arc-20160816; b=JI08alLvG4Ih4t6DdY3Cg8g5zJwfan5Z8Wo0W6kOXUZn59sNjTiealDPO7JzpYZACz NVu1zatRxlGb9xYUgLFA+ESclCu+7L0AvP4bGDjijBQJCNOdmpT6Bo/M0+tc1MWSwr3v L5F+HoOm8mhAwajCnYJviy4vKEmEQCO+cLAgze5us6upf1A8A7hWl10Z5z9y/+MrqN8F hoQobGBFkXnmjtwbz1wDQAa1HcGvA4x+vbcJHbX0B4/9/KP91SzF6cdCXyJdAr4nbk21 JwttN4soXprhVx724lgKBQFEjR9WtNKqwYd+Vt9skKblERXmXsHFocCOCJbn+Gdk7VXn ZY3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature:dkim-filter; bh=chnumXMjRPxHc3+TqNhtG9dgkl5xb90Nb7uzfVeZNvY=; b=dIoghloCDOCBNyNKkQTlzjc0pk74awqUepkAsg6qP1va4Is8ibKYahbFAO0KP0qBMS LkT5rHqcYSyumX9TOz6cWszlTTE4k7jqG8Vq3TdTXJkemGTF8z9x74jADr9PIEMq2eOA Foy54vgutrvjqiclMP5GD3b0lDD7fypHY5Je4cCKqcwvJ8lYDS5veZhmr8ONVynA1Gek j+Pqni6xHpDtrNob7H0ml32Sk4iMsZTlCaQTcRElKRvj046+hma/3zNSYS+ef5KP/65X wrsKRTyzpxuQ1Z9WhaDxga1BWqb4VsPKQcBCTxtu1ShJfkjv7jQRtiyBfiLaDScRj270 KHuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lwn.net header.s=20201203 header.b=ddRh0FhM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s13-20020a63924d000000b004b0b7d55315si5485318pgn.233.2023.01.11.15.28.16; Wed, 11 Jan 2023 15:28:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lwn.net header.s=20201203 header.b=ddRh0FhM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230354AbjAKWqX (ORCPT + 50 others); Wed, 11 Jan 2023 17:46:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232477AbjAKWqU (ORCPT ); Wed, 11 Jan 2023 17:46:20 -0500 Received: from ms.lwn.net (ms.lwn.net [45.79.88.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30EA31A3AE; Wed, 11 Jan 2023 14:46:20 -0800 (PST) Received: from localhost (unknown [IPv6:2601:281:8300:73::5f6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 8508C6E3; Wed, 11 Jan 2023 22:46:19 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net 8508C6E3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1673477179; bh=chnumXMjRPxHc3+TqNhtG9dgkl5xb90Nb7uzfVeZNvY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ddRh0FhMtKZdGtV5hhz8TZ5xilzh1rQI98qIW5WNRSdWjYfmOt3nSXT47+jvumyBt eLjXdnkQdqgn7vFjKV9kKt76JtL88gUHsZXVvzWDUCh1DDGNC+1LjytS9ItSmPQ2vl Q63hfoG/x6Ovmf/4sfp0HJW4psBsfRBIsYI53ajxDYn/hnSpwP682erSvG1V1YVHXH K92JrbA1S9MkvbK6dE/SNBqkh7Ch7oSAryZZGV3vX/wltMMd2ioiJv4Wt2frzhpnHP ffQhYMlRZGOLzPlKoKUIeb0e7k2m3dvsTzQwIbM+5N06E8Zw38lcr/Bobh2YgDCTSE jPTli73JOUVbA== From: Jonathan Corbet To: "A. Sverdlin" , linux-doc@vger.kernel.org Cc: Alexander Sverdlin , Federico Vaga , Thomas Gleixner , Ingo Molnar , Manfred Spraul , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] docs: kernel-hacking: discourage from calling disable_irq() in atomic In-Reply-To: <20221223112859.937196-1-alexander.sverdlin@siemens.com> References: <20221223112859.937196-1-alexander.sverdlin@siemens.com> Date: Wed, 11 Jan 2023 15:46:18 -0700 Message-ID: <87y1q8wuyt.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "A. Sverdlin" writes: > From: Alexander Sverdlin > > Correct the example in documentation so that disable_irq() is not being > called in atomic context. > > disable_irq() calls sleeping synchronize_irq(), it's not allowed to call > them in atomic context. > > Link: https://lore.kernel.org/lkml/87k02wbs2n.ffs@tglx/ > Reviewed-by: Manfred Spraul > Signed-off-by: Alexander Sverdlin > --- > Changelog: > v2: Dropped changes to manage.c because of already applied > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/kernel-irq-managec-disable_irq-might-sleep.patch > > Documentation/kernel-hacking/locking.rst | 4 ++-- > Documentation/translations/it_IT/kernel-hacking/locking.rst | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) Applied, thanks. jon