Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6d3602fd-fdf8-d6f6-56f7-d70eb2d381d8@linuxfoundation.org>
Date:   Wed, 11 Jan 2023 16:20:22 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] kselftest: Fix error message for unconfigured LLVM builds
To:     Mark Brown <broonie@kernel.org>, Shuah Khan <shuah@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>
Cc:     linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev, Shuah Khan <skhan@linuxfoundation.org>
References: <20230111-kselftest-lib-clang-fix-v1-1-58ebadd0e090@kernel.org>
Content-Language: en-US
From:   Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <20230111-kselftest-lib-clang-fix-v1-1-58ebadd0e090@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/11/23 15:33, Mark Brown wrote:
> We are missing a ) when we attempt to complain about not having enough
> configuration for clang, resulting in the rather inscrutable error:
> 
> ../lib.mk:23: *** unterminated call to function 'error': missing ')'.  Stop.
> 
> Add the required ) so we print the message we were trying to print.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>   tools/testing/selftests/lib.mk | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
> index 291144c284fb..f7900e75d230 100644
> --- a/tools/testing/selftests/lib.mk
> +++ b/tools/testing/selftests/lib.mk
> @@ -20,7 +20,7 @@ CLANG_TARGET_FLAGS              := $(CLANG_TARGET_FLAGS_$(ARCH))
>   
>   ifeq ($(CROSS_COMPILE),)
>   ifeq ($(CLANG_TARGET_FLAGS),)
> -$(error Specify CROSS_COMPILE or add '--target=' option to lib.mk
> +$(error Specify CROSS_COMPILE or add '--target=' option to lib.mk)
>   else
>   CLANG_FLAGS     += --target=$(CLANG_TARGET_FLAGS)
>   endif # CLANG_TARGET_FLAGS
> 
> ---
> base-commit: b7bfaa761d760e72a969d116517eaa12e404c262
> change-id: 20230111-kselftest-lib-clang-fix-8936ba376ea1
> 
> Best regards,

Thank you. I will queue this up for the next rc.

thanks,
-- Shuah