Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ad2da884-c8c8-bc57-e21f-452a08cb10cc@intel.com>
Date:   Wed, 11 Jan 2023 16:27:49 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.6.1
Subject: Re: [PATCH 3/7] x86/cpu: Disable kernel LASS when patching kernel
 alternatives
Content-Language: en-US
To:     Sohil Mehta <sohil.mehta@intel.com>,
        <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Ravi Shankar <ravi.v.shankar@intel.com>,
        "Tony Luck" <tony.luck@intel.com>, Paul Lai <paul.c.lai@intel.com>
References: <20230110055204.3227669-1-yian.chen@intel.com>
 <20230110055204.3227669-4-yian.chen@intel.com>
 <693d8332-3b86-3dcf-fc87-5c3a08a752db@intel.com>
From:   "Chen, Yian" <yian.chen@intel.com>
In-Reply-To: <693d8332-3b86-3dcf-fc87-5c3a08a752db@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aEJvLzA3QXpjd3d1UytEMEJxaUpmeXE4NjVDK3lva001V3lDQ2l6bUVwWktj?=
 =?utf-8?B?c3V3aFMvUUJGTW1TdWlzYXBjSWFpWlRSZncxcTA0T1M1dm53aTQwTm5QeGNi?=
 =?utf-8?B?eDNIdXRpV0paVTgzQUxuQzBHU0tKbHYzVDdNWCtTLzluL0FDZmt4allSNndQ?=
 =?utf-8?B?ejJyOG9tSHVXVm1ERFhLMGNwZkJ0dndMOU90TXI2dXpRdWdORGh5MHBtdnQw?=
 =?utf-8?B?Q0MxQkVqRzFDbStLbnJkYjVSeHRrQzZJWmZWYjhRRWFOUVhDYktjb1lwKzBz?=
 =?utf-8?B?UFJIV3hTL0RxcHcwUFlyTXdyOHQwZkUwd0lTeXBFOTlGNkx0cVhnaU5ORnBs?=
 =?utf-8?B?SVZkNWVZZTh6YUxxYTZ1WktxaTI4bXh4NGM3ekNYbm1KT3ZCN05RV2xPeWYv?=
 =?utf-8?B?bGhQcGlvbmZGODZ6eGdKSDFSeGVhVU9UdStFaE9QY2pnVituQ1MzZDZVUk5T?=
 =?utf-8?B?TDE2ZDRjWVFXVG1SVUEvc1lsSmNNZzFpVkJ0aXNCRDVyMWpsaWJEY0lGTkRo?=
 =?utf-8?B?M2E4c3dVQklNRnZCWDNjdndZUGR5d1ZCaFRVRFBBOHdOWnRGRUk5Misza0ht?=
 =?utf-8?B?d1VxQ2lUOHVkSHRwUDFHbVlVRHZWNEdVS2xTaHRHQ3dVbXpYMXkxeWlxNXRK?=
 =?utf-8?B?L1lnM21EUjg2RjlINVNFNnM1M2UrZnFTczFLSk9nU0ZmSm45RkFnYkpsQjMx?=
 =?utf-8?B?QWlCY3NiZng2ZHBGS2ZMYk55OGNlK05DR3dSZU1hVlRwZGp4Nk5aSEZVWkNY?=
 =?utf-8?B?R0ZiNmdzaEczOWw5dnJ3a3dhOVpPK3dPaHcwY0xOQUNBNWhGamhtMUFSb2p1?=
 =?utf-8?B?Y2tXMlFXRFBYVk5JNURDZzd4RXlNbHpIM0NMd2swTkpPM21uNzkzWmF1V2I0?=
 =?utf-8?B?VllRNGRHWFNRM2IzQmwvQkt1UTE2RG83NkZPNG9FTnJzTERkZUFzTHZGWTZX?=
 =?utf-8?B?TVBpWlhJZk10ay9BR3E2QnlSc283Rk9TaTRtSENDY0VOZUwvaTE4TmxQQlBx?=
 =?utf-8?B?ZURCYWhSVUpqL3ZUM09pUkRMU2NidnRlNlE3Q21PTnNOUFFxRlhNQzlsMTc3?=
 =?utf-8?B?ZW42elpPN2VsbSs1ckdzMlRMOWs2WnR2UTZFazRWWXVMdlFGVEtkMXczSHFQ?=
 =?utf-8?B?Zkg2Y1ZtckJ1STZvdUpHMFR5S2JBOG1VZlE3UDExRUFoc0JDYnlUbG95Z0dq?=
 =?utf-8?B?RUtxTUZEblNKOG5EZGJqc0JERVk1WXZINzg0aE9RZjJmTHpMZ0VWN2ZMbmpo?=
 =?utf-8?B?OHdaOWRYL3pPRFprU2hFNlZqZUtVR2hOK3FHRThNVEZVQjJIdVJsTTgyMDR5?=
 =?utf-8?B?UitpcU5DTkQ3YXlNeXZQUHV3clJYUW45dzd3bXZjSXVXYjFyTG1qS1BaQzJD?=
 =?utf-8?B?RkU3L1hUUFE2bElVM3RjWUZJS0dlZ0d4RG1vZHpnV0FFeGljcWF2Vld5ekM5?=
 =?utf-8?B?amd6ekoxc2lYd2U0OW1XcHl3ZDJrNmpLY21paWNWV3RlMGRhZ09SQ3Z4RWRJ?=
 =?utf-8?B?OHA3UXB2ZlJINDNlNHNZNmJDVldFcFROSWhMcERhWlVlMWU0NlpJOHZMdlNX?=
 =?utf-8?B?YWluNWhwN2VJeGpsSUFiSzlhdHNVWjNQK1NaQVhVQVkyWUJhVzdscC9ESDg1?=
 =?utf-8?B?M3ZscWhnRUtkb3dsbUlJYXc2dXlTM3NSQW53Tm9LNHovcElTT3duMllwbGk5?=
 =?utf-8?B?WnlGQ3Zpa0FWaWtDMFg1U2t5aHMyZVQ1R3h3YVNCVmFCaUZRdWdMOHd1U1dR?=
 =?utf-8?B?MGFIdnZraVViVnM5dU1jL1AxVk1reTdaK2VvZW02Uy8xL2FBYWhZUTVCWjZP?=
 =?utf-8?B?U3NYTW52SExOYmlkUzlHaklYQjNCeVFQTUsyVEoyK3c2d2JsWSsrK1M4aEVY?=
 =?utf-8?B?SkJqYnZQanRDby9uTUVKS2VKMnZmY1NIM2UxT2dwTzZjVWt5bGYxSWlRZEZ3?=
 =?utf-8?B?bGx2dldZS2N2VG0vV2xVdGdPK2pJWkx4VGd0VU9WVEp2M1FhMzRtdDA3Y0hN?=
 =?utf-8?B?M1MyWG5hVHArclB5aXBsSWszM3pmKy9MR09CMUhWWXlXdWhGcEhnV2ZSR1ND?=
 =?utf-8?B?dVhSVmtGd2dMblR2V3lUcUVZK21kbjhVL1hqeFRPSkJTWFUralYwbStkbHhu?=
 =?utf-8?Q?2dhypuiRwdvVZzrsGEEtTTFsP?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ba566e63-2689-4852-2101-08daf433d76d
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5262.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 00:27:52.2671
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LYXoIuco6WaHK+jpuBPrBtYuubr8KSqLRGCVy/Y2al2s6DfwMTxI1/0cSlj2JoJAk9egcduMNzIdXJ1xe5s9KA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5500
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/10/2023 2:41 PM, Sohil Mehta wrote:
> On 1/9/2023 9:52 PM, Yian Chen wrote:
> 
>> LASS stops access to a lower half address in kernel,
>> and this can be deactivated if AC bit in EFLAGS
>> register is set. Hence use stac and clac instructions
>> around access to the address to avoid triggering a
>> LASS #GP fault.
>>
> 
> It seems we are implicitly relying on the on stac() and clac() calls 
> that are added for SMAP. Have you tried running with SMAP disabled  i.e 
> "clearcpuid=smap"?
>
Yes, I tested with clearcpuid=smap.

> I believe there needs to be a dependency between LASS and SMAP.
> 
Yes, In kernel mode, LASS depends on SMAP to work. And in user mode, it 
doesn't, so the dependency description in following may miss user space 
effect.

> diff --git a/arch/x86/kernel/cpu/cpuid-deps.c 
> b/arch/x86/kernel/cpu/cpuid-deps.c
> index d95221117129..00bc7e4a65d2 100644
> --- a/arch/x86/kernel/cpu/cpuid-deps.c
> +++ b/arch/x86/kernel/cpu/cpuid-deps.c
> @@ -79,6 +79,7 @@ static const struct cpuid_dep cpuid_deps[] = {
>       { X86_FEATURE_XFD,            X86_FEATURE_XSAVES    },
>       { X86_FEATURE_XFD,            X86_FEATURE_XGETBV1   },
>       { X86_FEATURE_AMX_TILE,            X86_FEATURE_XFD       },
> +    { X86_FEATURE_LASS,            X86_FEATURE_SMAP      },
>       {}
>   };

Thanks,
Yian