Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230111-uvc_privacy_subdev-v1-0-f859ac9a01e3@chromium.org>
 <20230111-uvc_privacy_subdev-v1-2-f859ac9a01e3@chromium.org> <350cbdd5-55bc-96b1-387e-ba9abeb26470@collabora.com>
In-Reply-To: <350cbdd5-55bc-96b1-387e-ba9abeb26470@collabora.com>
From:   Yunke Cao <yunkec@chromium.org>
Date:   Thu, 12 Jan 2023 10:40:17 +0900
Message-ID: <CAEDqmY6f5cYy-9C9pvpvV4X+WUZjEhgSkfYpZtwf2dbomHSQiw@mail.gmail.com>
Subject: Re: [PATCH RFC 2/3] media: uvcvideo: remove entity privacy control in
 the uvc video node
To:     Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Cc:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Ricardo Ribalda <ribalda@chromium.org>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
        Sakari Ailus <sakari.ailus@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Andrej,

On Wed, Jan 11, 2023 at 7:33 PM Andrzej Pietrasiewicz
<andrzej.p@collabora.com> wrote:
>
> Hello,
>
> W dniu 11.01.2023 o 09:52, Yunke Cao pisze:
> > For privacy_gpio, do not expose V4L2_CID_PRIVACY to userspace as a control
> > of the video node.
> >
>
> I know it is an RFC, so maybe you distribute the changes into 3 patches
> on purpose. But, after applying this patch V4L2_CID_PRIVACY is lost
> until it is re-implemented later, isn't it? Because of that It seems to me
> patches 2/3 and 3/3 should be combined into one.
>

Yes, that's correct. Now that I look at it, it makes little sense to split them.

Thanks!
Yunke

> Regards,
>
> Andrzej
>
> > Signed-off-by: Yunke Cao <yunkec@chromium.org>
> > ---
> >   drivers/media/usb/uvc/uvc_ctrl.c | 17 -----------------
> >   1 file changed, 17 deletions(-)
> >
> > diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c
> > index c95a2229f4fa..77c5ff19add8 100644
> > --- a/drivers/media/usb/uvc/uvc_ctrl.c
> > +++ b/drivers/media/usb/uvc/uvc_ctrl.c
> > @@ -348,14 +348,6 @@ static const struct uvc_control_info uvc_ctrls[] = {
> >                               | UVC_CTRL_FLAG_RESTORE
> >                               | UVC_CTRL_FLAG_AUTO_UPDATE,
> >       },
> > -     {
> > -             .entity         = UVC_GUID_EXT_GPIO_CONTROLLER,
> > -             .selector       = UVC_CT_PRIVACY_CONTROL,
> > -             .index          = 0,
> > -             .size           = 1,
> > -             .flags          = UVC_CTRL_FLAG_GET_CUR
> > -                             | UVC_CTRL_FLAG_AUTO_UPDATE,
> > -     },
> >   };
> >
> >   static const u32 uvc_control_classes[] = {
> > @@ -710,15 +702,6 @@ static const struct uvc_control_mapping uvc_ctrl_mappings[] = {
> >               .v4l2_type      = V4L2_CTRL_TYPE_BOOLEAN,
> >               .data_type      = UVC_CTRL_DATA_TYPE_BOOLEAN,
> >       },
> > -     {
> > -             .id             = V4L2_CID_PRIVACY,
> > -             .entity         = UVC_GUID_EXT_GPIO_CONTROLLER,
> > -             .selector       = UVC_CT_PRIVACY_CONTROL,
> > -             .size           = 1,
> > -             .offset         = 0,
> > -             .v4l2_type      = V4L2_CTRL_TYPE_BOOLEAN,
> > -             .data_type      = UVC_CTRL_DATA_TYPE_BOOLEAN,
> > -     },
> >   };
> >
> >   static const struct uvc_control_mapping uvc_ctrl_mappings_uvc11[] = {
> >
>