Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 12 Jan 2023 10:10:36 +0800
From:   Pengfei Xu <pengfei.xu@intel.com>
To:     Javier Martinez Canillas <javierm@redhat.com>
CC:     <skhan@linuxfoundation.org>, <shuah@kernel.org>,
        <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Heng Su <heng.su@intel.com>, <akpm@linux-foundation.org>
Subject: Re: [PATCH v1 1/1] selftests/filesystems: Grant executable
 permission to run_fat_tests.sh
Message-ID: <Y79sHLMU4BYEwFAn@xpf.sh.intel.com>
References: <cover.1673424747.git.pengfei.xu@intel.com>
 <dfdbba6df8a1ab34bb1e81cd8bd7ca3f9ed5c369.1673424747.git.pengfei.xu@intel.com>
 <667c1b8e-b46c-c830-8f01-9e97e64e4e4e@redhat.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <667c1b8e-b46c-c830-8f01-9e97e64e4e4e@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?a/UClpWnn5v1mX4DjPHTl26tR336EoMxUp3e8DBE0OasslY52zyKzjmsLBuA?=
 =?us-ascii?Q?TTQsCSkNJ5Glq114iCW9B7CXCN5+cQ5hoWnKB5yUY+GDOjxgSZEV/8t9/H0/?=
 =?us-ascii?Q?bldjcnf4+u6pdekY+qGkRN+sPwohuJlaLpD0amFz/CptBFQkrpk64jprq6ME?=
 =?us-ascii?Q?GdrRgEhqlua2vIvLU0jwgtQkd/dqNO5o/WcuvrDvv5qfirzFVnHGAncqkylo?=
 =?us-ascii?Q?uuP1QOaVvoI4QX+AW162wfLhA/fLXG0yFmA+emUiezb2sLXSnBT7Pp+bkj6P?=
 =?us-ascii?Q?HQV4GuSCgN0e0wKT7jupmEsXZ6wLA3K6GbmcnDJ6VeNa+KuNJq0NGt+F8CPl?=
 =?us-ascii?Q?uyJQ+kO9hF34ietbs0ICOzumMzEO/dz+2S3hL9QTvlnkpErXAFAgq+YdDG5b?=
 =?us-ascii?Q?MhVol+ZO7+VE0L4VWxwCVc3qScRv5xNSg3d36yFoBP5ipcSjO2uVDvC14+Yf?=
 =?us-ascii?Q?pcfUiYQQENxr6CY9UZwyuq0B+O4EF4+TG7ZjN9UzDSsd+kqm3D7G4MyuWfBV?=
 =?us-ascii?Q?rpw+ABemXtO/aE9fCXsS0yAmzU9Swcznm7dHPkbRnGlNKMKPxisOs001qPvA?=
 =?us-ascii?Q?2OE1mB7P0/Eudh+MG2Bwarx71qe8xP5sf3BuiMPdRVfVzflACpyM2BScfPOe?=
 =?us-ascii?Q?ejNSofHqnR6QOp2JlKeOncqv30HdPSllulBqr+4ZwihXjiO5usX9MuhCGi+b?=
 =?us-ascii?Q?Dp6bn7G7HHHwC2S5vzTLE38qkH79QDnifuKAuWVXepTOqlhaoQ1t9WJsNHim?=
 =?us-ascii?Q?PwFCdPgKWM8okeFOGy++vJgMFH6LDhkxn69k7QZrihpD4cMP2h+8I/JnF/sC?=
 =?us-ascii?Q?9Y4Uwwaoz2/Wg7vET1u7+B8PzIkm3FV2FmqBrfRkt8POwCHkR5BO9PL7841O?=
 =?us-ascii?Q?Bv9nMUUALRr/H3UtkGp2HyfXzim7kA6nMbHcs6hPuG7DgN8YBwXjJpZujcph?=
 =?us-ascii?Q?MXeoLFUdJQ/isCMBaI4p3nkFLJTnubOuK7CAB7BIfo9h05GJ2c20EC/Hk0hH?=
 =?us-ascii?Q?eIaRl/uDMkPOUPCDHFlvRx6ge4IPpCF7K0tzSGFvQs+guzBCFO36mpNJZPgc?=
 =?us-ascii?Q?fAA29l21iGXi8yOwzbhZBTkA9O1b09xq2Qgu/y52DhuGn0lw4CVDqbvyoLQO?=
 =?us-ascii?Q?LEtfmRdbWu+Z8/ozxLGp0FLzCQpEGMOVeZ2e5rD1fGfjvWHA+vwK/0u7vdwH?=
 =?us-ascii?Q?FR7q1HoymQmqbOBmd9De1t2fDep+7AFXsmXkGGEwi282qn8znuNT0/akoVoW?=
 =?us-ascii?Q?iGylRB3im9cGAB0uRza1m+/lGbM4jeRiaAe4Hz+IJnJkrFIEJVdNHv5DnWNY?=
 =?us-ascii?Q?aSEGgbee7j+5QBmzqQMijPkHiDmiLkZgH1w5AL0sZL1d5TGbZz5MQEIgbpvQ?=
 =?us-ascii?Q?VAP459xxG2lCnO6fA/HOlp+qiR+9RJMs7E3OQW+pGDjy4CIx9PmQswfMnYyg?=
 =?us-ascii?Q?+5gKd8+0dpQpltl7lCHkAxhF/z8e6kFmsHDc76QLeIQc9H+WqaSZtZYlK6VZ?=
 =?us-ascii?Q?TadqYzPxZStyR+jY7lUgCIDREan5Kq365DmA5w3MWct0KJFYnUbaP5cW2jCp?=
 =?us-ascii?Q?OwIwWKPJ5ra0oOLCBGrIz+3nK7GPzVRjuy2xSFb0?=
X-MS-Exchange-CrossTenant-Network-Message-Id: df57effe-51d6-44cd-6fc8-08daf44211d2
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4839.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 02:09:43.1618
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q5yC4kgaH/EtcJBWTU2PEBogoVuv3kGMPXeAQH1YF4RtU8uxmSqfD3sJYcdVqRjQSmdHMzpUttc1RMTJtuWC2Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5613
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Javier Martinez Canillas,

On 2023-01-11 at 15:47:00 +0100, Javier Martinez Canillas wrote:
> Hello Pengfei Xu,
> 
> On 1/11/23 09:15, Pengfei Xu wrote:
> > When use tools/testing/selftests/kselftest_install.sh to make the
> > kselftest-list.txt under tools/testing/selftests/kselftest_install.
> > 
> > Then use tools/testing/selftests/kselftest_install/run_kselftest.sh to
> > run all the kselftests in kselftest-list.txt, it will be blocked by
> > case "filesystems/fat: run_fat_tests.sh" with "Warning: file run_fat_tests.sh
> > is not executable", so grant executable permission to run_fat_tests.sh to
> > fix this issue.
> > 
> > Fixes: dd7c9be330d8 ("selftests/filesystems: add a vfat RENAME_EXCHANGE test")
> > Signed-off-by: Pengfei Xu <pengfei.xu@intel.com>
> > ---
> 
> Indeed, thanks for fixing this.
> 
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
  Thanks for your tag, thank you and Andrew Morton, and I'm glad it's helpful.

  Thanks!
  BR.
> 
> I wonder how I didn't get this when running the test with:
> 
> make TARGETS="filesystems/fat" kselftest
> 
> -- 
> Best regards,
> 
> Javier Martinez Canillas
> Core Platforms
> Red Hat
>