Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Zhang, Qiang1" <qiang1.zhang@intel.com>
To:     Frederic Weisbecker <frederic@kernel.org>,
        "paulmck@kernel.org" <paulmck@kernel.org>
CC:     "quic_neeraju@quicinc.com" <quic_neeraju@quicinc.com>,
        "joel@joelfernandes.org" <joel@joelfernandes.org>,
        "rcu@vger.kernel.org" <rcu@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] rcu: Fix the start_poll_synchronize_rcu_expedited() be
 invoked very early
Thread-Topic: [PATCH] rcu: Fix the start_poll_synchronize_rcu_expedited() be
 invoked very early
Thread-Index: AQHZJb5UWQa/x1vzsU2YPlwsTIa6Ya6ZTB2AgAC1hwA=
Date:   Thu, 12 Jan 2023 01:51:15 +0000
Message-ID: <PH0PR11MB588065795A247B479F692401DAFD9@PH0PR11MB5880.namprd11.prod.outlook.com>
References: <20230111131453.1626214-1-qiang1.zhang@intel.com>
 <Y77MS0+8Hjoxaog+@lothringen>
In-Reply-To: <Y77MS0+8Hjoxaog+@lothringen>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VDe42j2QM/6tQE/3K/hKzR+R1KBsrhT9QdorvK30rU9RYV5goHg5nfnpi1Xn?=
 =?us-ascii?Q?PIVZZlR7Xvtsff5hoRh8mrXUX1yW8Iepv8cIlMOe03yDYAFwgkD/AruyP3Ii?=
 =?us-ascii?Q?CkTcudaSM8iT1YZ51Dq/+edoo/Vr0TTPjFdoZ4GL648tq/oaZexUOMpvjS8k?=
 =?us-ascii?Q?ZwhHXewKVSIiyLw6LknPCB2rc4E8Jjq0h/KYVgge1oAlWOPCYjaYk1+ve20z?=
 =?us-ascii?Q?z3KYygw/RnTNWxtNXRD+m9c6kWOMRWED25DFmJfMzHIn9wvIiUr47r8FnKWP?=
 =?us-ascii?Q?kLonF00wUhLuvk0/qzNgrTH0ZrudBxdMglCCsg+UuYPMZ/McPonQxdtbpVbr?=
 =?us-ascii?Q?Wl6KmEvFKObXBliq9fEHxpQDKRz3Bt9I3xhl7qbem09LkAkJdSMCeV+cAI1u?=
 =?us-ascii?Q?AVAG1+ouKITT46ALbf4MdOTji0wDeru+EZWVTff0mf7OdEcRcvXLMiFjk7t4?=
 =?us-ascii?Q?3DecZYrf0S4nS5YQc7b/mHzmEcVILFOf7Q5o6q1H2l6hmSuLHizMVwOobZ5E?=
 =?us-ascii?Q?chiY2gVMsZ3FhZdTxgvMBzLjE2mJvQ4XRKP+FXR/IkN+M6jsKAXagRwwFw5o?=
 =?us-ascii?Q?Ty5vPzbSTNWtJN7uWLu06+Nib6DdbfVRGk/QD5/WFO7MNdOcYDOlFUzNDaTs?=
 =?us-ascii?Q?jxlD3fwZnNZPqBkeMrHzJjSwZar/mK3iCxKJQXgtL86UNZiEQa9il2eXUG7I?=
 =?us-ascii?Q?ZFyGxVXMwzzbhEsnU6MKPitXuTQqptS7ihhAqIDvEdkr32ZM3kktORQmSidc?=
 =?us-ascii?Q?JVTdNxIK4ngMedbvWnD9Sb/EGkz7Fby3uVCcMRvXkNgb8l1c6Z7DDTPSgWzp?=
 =?us-ascii?Q?kOgFYOUMMcOzlLS7hFK69lLyGWlw/iAA34ApRsXxBRRmh2N80wFfcfaY2hN5?=
 =?us-ascii?Q?KaN5xXlcSsRubG4Uv4Dh/rGbc01wWk6cNQsuPbimn6ZEruGJEJmt0WmJaJ8G?=
 =?us-ascii?Q?DSRs8w0cifuYVj+eG7ggy7O+/RrC5xfdfEQi5BPlfguSfDhWjZZxLONNM+2I?=
 =?us-ascii?Q?GqJ6Umu78/BbohfhnVMSbrSW6BC+cx9AeQaXZJBe5bzlaMjuDvYCbnHlj43X?=
 =?us-ascii?Q?QIHctXdmPO/ZZDVWZgojOFFcPxl/PnWkcgKqlkIl7xrqjumZ/v/v0Qpnupgk?=
 =?us-ascii?Q?wVG7UIvAlA2qmm8pfrYG4G5fEkhser7AS2UjCcFGj6nEc+vXYqMloylHt+Wr?=
 =?us-ascii?Q?jSyonDHHIF0KhfCJQ8TyzdsycA/kDpDhlrlLLr9YIQP9vC+CM0T96+vSGE0G?=
 =?us-ascii?Q?zTZMjkujr+t0kg39pCBIHRMYzl8R3aIKmg5vhuLiFA+gpz2FjUCf4Ug59Yos?=
 =?us-ascii?Q?l8WvkLXtWAP5WW01CCjJaVWKmBzNC2R3a6zkeALtwzYew8U8chxWhy0ItRNQ?=
 =?us-ascii?Q?lE5qShWeSmM0/N+a3UOwNTeVHBTGq8oRbdtZUgIfnmoh0lFDyPcW8ajXesHN?=
 =?us-ascii?Q?YVcA9HFA9SwiQTpMYgcIDTLZ/KKfOuxdWwKN/BfhHYdX9tTsM3aRmGCFnUqg?=
 =?us-ascii?Q?kovQSkGZI9ensNsRUZDdif0VdYIEYRDVRjNpDaUk4kdBUXN7zAdvu14wagVl?=
 =?us-ascii?Q?Hciv0vq/Pn+wJtNeDJxwvl6e3jmjuuvRxQ9U+pjd?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5880.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5185fb64-9470-4d14-4d8b-08daf43f7d75
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 01:51:15.0678
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: H34mJkTP3uHwlMe8pBz/q1afA6mwAYM00XqAaeM0eag2NqkX36Uv+OJzVOMxLUb7WHqsyER4XsIvi/uPjqmlsA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6789
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 11, 2023 at 09:14:53PM +0800, Zqiang wrote:
> Currently, the start_poll_synchronize_rcu_expedited() can be invoked
> very early. before rcu_init(), the rcu_data structure's->mynode is not
> initialized, if invoke start_poll_synchronize_rcu_expedited() before
> rcu_init(), will access to NULL mynode pointer.
>=20
> This commit therefore add exp_seq_poll_rq member to rcu_state structure
> to store snap seq number
>
>Is it even sane to poll that early in the morning? :-)

According to d96c52fe4907c ("rcu: Add polled expedited grace-period primiti=
ves "),
the start_poll_synchronize_rcu_expedited() can be invoked very early, that =
is to say
can be invoked before rcu_init(),  the following code snippet also shows th=
at the=20
start_poll_synchronize_rcu_expedited()  may be called early.

// Kick-start any polled grace periods that started early.
         if (!(per_cpu_ptr(&rcu_data, cpu)->mynode->exp_seq_poll_rq & 0x1))
                 (void)start_poll_synchronize_rcu_expedited();

But before rcu_init(), the rcu_data structure's->mynode is not initialized,
so at least, we set rnp->exp_seq_poll_rq should be in case the rcu_init_inv=
oked()
returns true in start_poll_synchronize_rcu_expedited() .


>
>=20
> Signed-off-by: Zqiang <qiang1.zhang@intel.com>
> ---
>  kernel/rcu/tree.c     | 3 ++-
>  kernel/rcu/tree.h     | 1 +
>  kernel/rcu/tree_exp.h | 6 ++++--
>  3 files changed, 7 insertions(+), 3 deletions(-)
>=20
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index 63545d79da51..34b13d6bd8c4 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -92,6 +92,7 @@ static struct rcu_state rcu_state =3D {
>  	.exp_mutex =3D __MUTEX_INITIALIZER(rcu_state.exp_mutex),
>  	.exp_wake_mutex =3D __MUTEX_INITIALIZER(rcu_state.exp_wake_mutex),
>  	.ofl_lock =3D __ARCH_SPIN_LOCK_UNLOCKED,
> +	.exp_seq_poll_rq =3D RCU_GET_STATE_COMPLETED,
>
>I don't know if we really want to fix this, but assuming we do,
>can we rename it to boot_exp_seq_poll_rq? To avoid later confusion.

Will fix in next version.

Thanks
Zqiang

>
>Thanks.