Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 12 Jan 2023 11:05:34 +0800
From:   Li Chen <me@linux.beauty>
To:     "Stephen Boyd" <sboyd@kernel.org>
Cc:     "michael turquette" <mturquette@baylibre.com>,
        "li chen" <lchen@ambarella.com>,
        "linux-clk" <linux-clk@vger.kernel.org>,
        "linux-kernel" <linux-kernel@vger.kernel.org>
Message-ID: <185a3f0a326.b623e6bd1243489.6765528573167668508@linux.beauty>
In-Reply-To: <57d1f58c4c6cca793d629d5776b477d0.sboyd@kernel.org>
References: <20230110114540.2975540-1-me@linux.beauty> <57d1f58c4c6cca793d629d5776b477d0.sboyd@kernel.org>
Subject: Re: [PATCH] clk: create write_enable file to control clk rate write
 and other dangerous ops permission
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Importance: Medium
User-Agent: Zoho Mail
Precedence: bulk

Hi Stephen,
 ---- On Thu, 12 Jan 2023 02:37:29 +0800  Stephen Boyd  wrote --- 
 > Quoting Li Chen (2023-01-10 03:45:39)
 > > From: Li Chen lchen@ambarella.com>
 > > 
 > > It's common requirement for bsp debug/test to change clk rate from userspace.
 > > 
 > > Currently, we must define CLKOCK_ALLOW_WRITE_DEBUGFS then re-compile kernel
 > > to allow this feature. Let's replace it with a "write_enable" file to
 > > allow enable it at runtime.
 > 
 > Nak. This design is intentional.
 
Thanks for your reply. Got it. But sometimes re-compile is somewhat low efficient. Is it acceptable to provide 
a write_enable to clk_core(not enable by default), and allow clk driver to enable it inside clk_ops->init
via clk_hw->core->write_enable = 1?

Regards,
Li