Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp10466686rwl; Wed, 11 Jan 2023 21:07:00 -0800 (PST) X-Google-Smtp-Source: AMrXdXuiGY7lXZF/6BfxXSHMv8WK/+4ieYv464pwiGR1ydPKIECHoXoXIL+OneI2MlZc2yMxQbnQ X-Received: by 2002:a05:6402:448a:b0:481:9219:f603 with SMTP id er10-20020a056402448a00b004819219f603mr58632433edb.28.1673500019922; Wed, 11 Jan 2023 21:06:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673500019; cv=none; d=google.com; s=arc-20160816; b=ZUsyGX2MN0T4aWOO5zazXMvPAKWF9CX/Lu2M2MeqLyMlxMbyd+OsMTQvYB5anjdytT zRyN3+ML/Qz2HrxEsRoRHbChbpaC6F3g3jtBLdW8SHIn8ft2iHA6h8IW51B0Ss1c7bbl wu6XtN8nGBhyBVCb9TnbtQ7TwmSczv94YqNFrEpJfPL9UuhHQrDoNNr56uiBjlxe3D73 293KdEAGJhAJZv7ncpodnSQXRg8bFvgY4NIfvWbnTJI1iFCfbR3xPuav9qnB7mRAoP0K xauI8Awd3il2OXXTWDGpaLVdM+NLGSENRAgXSP0JAQLo9Uk5Ma++TCb464NA7RUz2FKW +77A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=0JjWYRu/kVfVhVMQzk2HzUkqzGw62vTtAvDUcCRIg2Q=; b=jT0GBosX7gkrbaRwqRgGi6FP2DIjnuJnVJz9KCv+bR3GO6K5V/RSpgPFpukzNkODQz v3B1O2T2/DtCuczTYA6DlasmUHO2UFXI+oyb7pb7cVDe6PqyJqfneQxkyQm3+sT8umBQ VfRSTH7UCk5cc3Ak5JA4E1B5EBPwLRXratz0I5q6TFlgaswLCmW+OyskFMGZQHJhpfKy JfBD7HihQvAy5Y8ffBRmjxjdFNPta919RLPlrTdI5cCQHtH6TanVLe9S9PYGF3qy3bDo SPyuW22AK4ET2xO79echojD7XAqLCVfHNkVdXfmyCHeHxo4u2u296gD5Ru8Cjagb2NGm d5wA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xnCH+90v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b14-20020a056402084e00b004842aaeea0bsi20509634edz.603.2023.01.11.21.06.47; Wed, 11 Jan 2023 21:06:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xnCH+90v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235483AbjALEfE (ORCPT + 51 others); Wed, 11 Jan 2023 23:35:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236549AbjALEe7 (ORCPT ); Wed, 11 Jan 2023 23:34:59 -0500 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 169E412A8F for ; Wed, 11 Jan 2023 20:34:56 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id v25so26654034lfe.12 for ; Wed, 11 Jan 2023 20:34:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0JjWYRu/kVfVhVMQzk2HzUkqzGw62vTtAvDUcCRIg2Q=; b=xnCH+90vro8HMqVxbQWy0+QpP1RoJllaC7vgNWkMXosA1sjMcQG3WXug2Xm3w1gWDc 54BbU2npxmYPjPpuB4OM00Jqjm+OGTqeM4yH6GTJgMDjBtfiZ2anhtAcR8WL+USGjN+w oPt5/OL1Gu24THz9dqppSYQ8wW3dkFnerIrZezOK87RIIyA89U29icART7QawzY+TyZr n6DFmUYUR3I4xTs3LtU+5DS3R4zrE/XEbY4kzSa99C8m7Z/mUBkxtJwOmYs/mB1ssces AyCzScDZf/LHR/rSv3T4+gedsPtapZ1b3DyzjV2bUO8zKXEAjMA2ikUhwkB4+PDLshed W5sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0JjWYRu/kVfVhVMQzk2HzUkqzGw62vTtAvDUcCRIg2Q=; b=wGCeMsxaBNdjbtxT/aH2hF21NbQb0OOOZjw6uJfFc0+o8YFa47aKgdcBr+ILa79RaV RRdQmrnaqd5Z5YAMR78A0yM2NoJiR9HaATEX54A2PZBZ+CZqCzx8MVGY+6jwUuX8gdql NjARu1qFnGzj7lyO2xfMFp4Suh+OZ9DYkdY6w/IdGSZ3P86OI9dxojtEw6QF7/xiHafI dxPF84lfzyClkN1GIVpo4m1ihNWuHZ/AifA7xYWeaj2sVSXwEeyAFdM2BXJK+mlpz62Q t6drX2nbgrfP6AAzNr2hIPmByboARbHqV5ETzDqWCCWddrzN7bLlXExN7LC6jPohGc8x eVOw== X-Gm-Message-State: AFqh2kq/F22LeQMroTDFf1DItzQnRsokoIaxOXR/AxAy8l19l3kQ9Bta QGekU9IR3Jwwq3ysMWZ/Xx4Dkw== X-Received: by 2002:a05:6512:c03:b0:4b5:a4ef:fca3 with SMTP id z3-20020a0565120c0300b004b5a4effca3mr24625783lfu.38.1673498094415; Wed, 11 Jan 2023 20:34:54 -0800 (PST) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id x22-20020a0565123f9600b004b52aed44besm3078302lfa.25.2023.01.11.20.34.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jan 2023 20:34:53 -0800 (PST) Message-ID: <61ba2880-6784-1014-a7a2-a1eecc4e810e@linaro.org> Date: Thu, 12 Jan 2023 06:34:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v10 0/9] Register Type-C mode-switch in DP bridge endpoints Content-Language: en-GB To: Pin-yen Lin , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J . Wysocki" , Prashant Malani , Benson Leung , Guenter Roeck Cc: Stephen Boyd , =?UTF-8?Q?N=c3=adcolas_F_=2e_R_=2e_A_=2e_Prado?= , Marek Vasut , AngeloGioacchino Del Regno , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, Javier Martinez Canillas , Lyude Paul , chrome-platform@lists.linux.dev, Xin Ji , Thomas Zimmermann , linux-kernel@vger.kernel.org, Allen Chen , linux-acpi@vger.kernel.org, Hsin-Yi Wang , Douglas Anderson , Imre Deak , Jani Nikula , =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= , Kees Cook , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , shaomin Deng References: <20230112042104.4107253-1-treapking@chromium.org> From: Dmitry Baryshkov In-Reply-To: <20230112042104.4107253-1-treapking@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/01/2023 06:20, Pin-yen Lin wrote: > > This series introduces bindings for anx7625/it6505 to register Type-C > mode-switch in their output endpoints, and use data-lanes property to > describe the pin connections. Please cc everybody on all patches. Having received just a single patch made me spend time on having to look them up on lore. > > The first two patch modifies fwnode_graph_devcon_matches and > cros_typec_init_ports to enable the registration of the switches. > > Patch 4~6 introduce the bindings for anx7625 and the corresponding driver > modifications. > > Patch 7~9 add similar bindings and driver changes for it6505. > > v9: https://lore.kernel.org/all/20230109084101.265664-1-treapking@chromium.org/ > v8: https://lore.kernel.org/all/20230107102231.23682-1-treapking@chromium.org/ > v7: https://lore.kernel.org/all/20230105132457.4125372-1-treapking@chromium.org/ > v6: https://lore.kernel.org/all/20221124102056.393220-1-treapking@chromium.org/ > v5: https://lore.kernel.org/linux-usb/20220622173605.1168416-1-pmalani@chromium.org/ > > Changes in v10: > - Collected Reviewed-by and Tested-by tags > - Replaced "void *" with "typec_mux_set_fn_t" for mux_set callbacks > - Print out the node name when errors on parsing DT > - Use dev_dbg instead of dev_warn when no Type-C switch nodes available > - Made the return path of drm_dp_register_mode_switch clearer > - Added a TODO for implementing orientation switch for anx7625 > - Updated the commit message for the absence of orientation switch > - Fixed typo in the commit message > > Changes in v9: > - Collected Reviewed-by tag > - Fixed subject prefix again > - Changed the naming of the example node for it6505 > > Changes in v8: > - Fixed the build issue when CONFIG_TYPEC=m > - Fixed some style issues > - Fixed the subject prefixes for the bindings patch > - Fixed the bindings for data-lanes properties > > Changes in v7: > - Fix the long comment lines > - Extracted the common codes to a helper function > - Fixed style issues in anx7625 driver > - Removed DT property validation in anx7625 driver. > - Fixed style issues in it6505 driver > - Removed the redundant sleep in it6505 driver > - Removed DT property validation in it6505 driver > - Rebased to drm-misc-next > - Fixed indentations in bindings patches > - Added a new patch to fix indentations in Kconfig > > Changes in v6: > - Changed it6505_typec_mux_set callback function to accommodate with > the latest drm-misc patches > - Changed the driver implementation to accommodate with the new binding > - Dropped typec-switch binding and use endpoints and data-lanes properties > to describe the pin connections > - Added new patches (patch 1,2,4) to fix probing issues > - Changed the bindings of it6505/anx7625 and modified the drivers > accordingly > - Merged it6505/anx7625 driver changes into a single patch > > Pin-yen Lin (7): > drm/display: Add Type-C switch helpers > dt-bindings: display: bridge: anx7625: Add mode-switch support > drm/bridge: anx7625: Check for Type-C during panel registration > drm/bridge: anx7625: Register Type C mode switches > dt-bindings: display: bridge: it6505: Add mode-switch support > drm/bridge: it6505: Fix Kconfig indentation > drm/bridge: it6505: Register Type C mode switches > > Prashant Malani (2): > device property: Add remote endpoint to devcon matcher > platform/chrome: cros_ec_typec: Purge blocking switch devlinks > > .../display/bridge/analogix,anx7625.yaml | 99 ++++++++++++- > .../bindings/display/bridge/ite,it6505.yaml | 93 ++++++++++-- > drivers/base/property.c | 15 ++ > drivers/gpu/drm/bridge/Kconfig | 21 +-- > drivers/gpu/drm/bridge/analogix/Kconfig | 1 + > drivers/gpu/drm/bridge/analogix/anx7625.c | 105 +++++++++++++- > drivers/gpu/drm/bridge/analogix/anx7625.h | 13 ++ > drivers/gpu/drm/bridge/ite-it6505.c | 119 +++++++++++++++- > drivers/gpu/drm/display/drm_dp_helper.c | 134 ++++++++++++++++++ > drivers/platform/chrome/cros_ec_typec.c | 10 ++ > include/drm/display/drm_dp_helper.h | 17 +++ > 11 files changed, 598 insertions(+), 29 deletions(-) > -- With best wishes Dmitry