Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4a764544-189f-65e0-7d77-84995299721d@nvidia.com>
Date:   Thu, 12 Jan 2023 10:29:45 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH V1] PCI/AER: Configure ECRC only AER is native
Content-Language: en-US
To:     Sathyanarayanan Kuppuswamy 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        Bjorn Helgaas <helgaas@kernel.org>
Cc:     bhelgaas@google.com, ruscur@russell.cc, oohall@gmail.com,
        treding@nvidia.com, jonathanh@nvidia.com, mmaddireddy@nvidia.com,
        kthota@nvidia.com, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org, vsethi@nvidia.com,
        linuxppc-dev@lists.ozlabs.org, sagar.tv@gmail.com
References: <20230111231033.GA1714672@bhelgaas>
 <880c4d3c-86d2-082c-bb58-8212adc67ff3@linux.intel.com>
 <4ddef2c9-44b6-4a08-dbeb-428cd0864c55@nvidia.com>
 <de13b6bd-813f-d0bb-3a92-ea1ad3db5d54@linux.intel.com>
From:   Vidya Sagar <vidyas@nvidia.com>
In-Reply-To: <de13b6bd-813f-d0bb-3a92-ea1ad3db5d54@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OEo4Mnd6bE9SQmcwQnVsNmYwMFlRMmlrT1hUckFKQ0RNbjFkYTRBVDRvZnMv?=
 =?utf-8?B?SjlYcHNzMkZ1WGU3Vk52a3NITXkwUEVGbXJHYXFHK2tJa0E2b2Y5d0NoWE16?=
 =?utf-8?B?QzhTU0JrdDQ5MHVPQkFXY2JuSkRzcGRYWElFWXNJaDJXalZjd3JjSEpsNTI1?=
 =?utf-8?B?R3Y1L2ZRNVcwQUxRc2ZKejlINTN0Z0U1ZGJCcVo4bDllSkpVVjUxNGFXRHM2?=
 =?utf-8?B?cVBGQi9JNWxBbTcwVzdLOFZBMjZ1ZGVZUE4vM0pFWXNjYTU4OW9qV3FDd1N3?=
 =?utf-8?B?YTVSWVBxcVFSa2F2NGppR2J1Q2tiSHFaR0FwQkZBUzJEazRHZllqd05MZkFN?=
 =?utf-8?B?U0x5NENiQ2RoeFhCV2hXMlF6Zng3Ky9WYUJoQTBsdmEySmI0cHltMkNUQUUr?=
 =?utf-8?B?MDJIelJ4dC9XVkZwdGhiSGVvTU5tTUJ4cWtYd05tNldDUU1UTGQyc2Y3T1BI?=
 =?utf-8?B?WU1mbEoxa1R3ZTUzY2lKbGw5cVh6eGp2VXo4aHFUYXRRbW1rNGs0dTV5aTQ1?=
 =?utf-8?B?by9SOTBabllNZGRsS1hFZi9TbnZ1VVc3MmZraWFBczdQbDcxaVhheFJIaHpG?=
 =?utf-8?B?RkJJblo3QVI2a0pDSVU3MTdWS0tlSkNzdUdnSDRIQTdkUS9uRGs1Z1BnNWxy?=
 =?utf-8?B?eFhuWHN3Vy9HT3FicDQwQ051TnM3QWVuTTVjTFBZWEFmSThRVVE4VXo2VzBR?=
 =?utf-8?B?VUI0d1BhakNKMnRCdHlCQ0ZFSU1PSGwzWW1FaDNJdm9PL2FqK2lTaGk1MVNC?=
 =?utf-8?B?b0V2Y0NvSGhQNVFteFJUdHRxS1pSeFNxL1B5bDV0Tm5yWWhqWUtYczhzZ3Ir?=
 =?utf-8?B?MmFEZncwcVVKZ2FZVjRxajdDZTJsSTViZGJrQ05va25pNXpkQWxmaU1BMC9Z?=
 =?utf-8?B?RkFuampwQ3NoZ28xb2NmWUtGSFpvMUFyQUpxZGdHRWd5eVNuM3Q5TzhZMEhK?=
 =?utf-8?B?Tk9BUWNWOHRnWWZaNTVxS01zRmdlUUEwUUFrSnJhTm04WSt3eWc1eDQycHB6?=
 =?utf-8?B?WTFmT09mWVplYUQ0aVcwd1VSUUJlMk0vbVVRVHlEU1R0ZUZyaSt6TEgzcWFK?=
 =?utf-8?B?bmlBK0hDdGVoOWg4Nnk2aEdMUCs4VU0raHdFRnJ1dU9hL0RUWlJxSGpmVFpZ?=
 =?utf-8?B?MUs2WWVNejNjdy9xTFh1Z0dyVlpkRUJCcFBlQkJERXRYUVliV3ArM1l1YjNp?=
 =?utf-8?B?WWpKT2wzckxqMW13R2l3dDFhWFI3WGxqYnV2a0xxYWZKRGF6dGtLMjJCRVcx?=
 =?utf-8?B?MENxSStGQU94UVB4eUpUREtLRjVuRTVXaDRhRXBlS0kwb3UyYkxwOVkrUERo?=
 =?utf-8?B?aUtJOC8yY1I5MjFJTXdLVmltWlA3QXBTamk3OXdZYW9VMzZKMmRjTXJmMVM5?=
 =?utf-8?B?dHY1Tlp1YWZqdXVvL0FQU1RET1I3NkpVVGx5NE54cTBTODVoaExMUjQ0alIx?=
 =?utf-8?B?bDhzMTcrRGN1SDhYZGhFYUlSNktrVC9Pcy9hZ1BscmljYm9oK0dRMWVYMWlN?=
 =?utf-8?B?SkVkZUgwR0MwNHZqOU9LQU92Qlp0czEzMG9aWjJ5V0FoN01YVlJvUW9JcE9l?=
 =?utf-8?B?Z2gwV2NNTUk2c3pRcFYxV0NuS3hwM1VRa2xNRGJBUDBrMy9mRzlVZFhGdkZK?=
 =?utf-8?B?eXJjaHV3TlczelpRdE1VbHAvWFFSVlcrS2ZGc2xadThFZEIxN0ZYMG5RNTRP?=
 =?utf-8?B?ZWJjOWtmeFNlSGtONjFxaG5FTVdiOUNnRDZ4cUhxS1ZZOVpCZ1d1blFTZnNO?=
 =?utf-8?B?WVJSVDJOTTEzdzBvcjJzaGJSSStCdmRudHVtRHhNNjEyZk45d2gzc2p0Rm1l?=
 =?utf-8?B?Um9iY0lmYVZ2bXVsL2l5bGc3ZzNOR1FEMy9JbDU5S21GRlB5ZW8wbmhLNUY2?=
 =?utf-8?B?UzNLbFFmL01lRVJRalY3WFFCZ0ZwcktMTkMrVUpMOXdYMGIzV2JVYTliNThG?=
 =?utf-8?B?TEZ0eC9UK2FFc25YQTFvOVk5bm94elozRTVibnFjd1BnQVZnZmRnVmo3WWQr?=
 =?utf-8?B?emhhc0VrM0FyU1NKdGc0clNGYjZHbHJubkhoWlhMTGhadDQzQUFMUXdqZk9m?=
 =?utf-8?B?N0srRGxDbjBEcVdZSm1kd0RSRytuTjlMdTJ3RGQ5T3FGZk9nKzYwR2hJdEZS?=
 =?utf-8?Q?xuDNGrqCgsOB4IUivDuoJfS7D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ac0aaed1-a7b7-4e89-912a-08daf459dba3
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB2900.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 05:00:00.4292
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d4CeIt1XZN9HqaKP8swMzGWPFDvK94LrUIPrPbMoyColyb7/848/TwyTVlN+vZFI2ySMUDW5EchziFPSWrAc/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8242
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/12/2023 9:18 AM, Sathyanarayanan Kuppuswamy wrote:
> External email: Use caution opening links or attachments
> 
> 
> On 1/11/23 7:33 PM, Vidya Sagar wrote:
>> I think we still need bios option. For example, consider a system where BIOS needs to keep ECRC enabled for integrity reasons but if kernel doesn't want it for perf reasons, then, kernel can always use 'ecrc=off' option.
> 
> I agree that "on" and "off" option makes sense. Since the kernel defaults ecrc setting to "bios", why again allow it as a command line option?

Agree. "on" and "off" are fine but "default" is redundant. Do you want 
me to push a change to remove that as part of this patch itself? I think
it is more like a cleanup and should go separately.

> 
> --
> Sathyanarayanan Kuppuswamy
> Linux Kernel Developer