Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sun, Yunying" <yunying.sun@intel.com>
To:     Bjorn Helgaas <helgaas@kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
CC:     "Williams, Dan J" <dan.j.williams@intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        "Luck, Tony" <tony.luck@intel.com>,
        "Box, David E" <david.e.box@intel.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "Mika Westerberg" <mika.westerberg@linux.intel.com>,
        "Cabiddu, Giovanni" <giovanni.cabiddu@intel.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "Hans de Goede" <hdegoede@redhat.com>,
        Florent DELAHAYE <linuxkernelml@undead.fr>,
        Konrad J Hambrick <kjhambrick@gmail.com>,
        Matt Hansen <2lprbe78@duck.com>,
        Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>,
        =?iso-8859-1?Q?Benoit_Gr=E9goire?= <benoitg@coeus.ca>,
        Werner Sembach <wse@tuxedocomputers.com>,
        "mumblingdrunkard@protonmail.com" <mumblingdrunkard@protonmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>
Subject: RE: [PATCH 0/2] PCI: Fix extended config space regression
Thread-Topic: [PATCH 0/2] PCI: Fix extended config space regression
Thread-Index: AQHZJR3Xndf5rFZtTUi/O30oa9oeZ66aSKEg
Date:   Thu, 12 Jan 2023 05:50:32 +0000
Message-ID: <DM6PR11MB40920805703B4B8485A0450DF2FD9@DM6PR11MB4092.namprd11.prod.outlook.com>
References: <20230110180243.1590045-1-helgaas@kernel.org>
In-Reply-To: <20230110180243.1590045-1-helgaas@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?7m7i6LEVqDHRKKMDy1Dw6d0eYgDD2f0UD76SGjEoCfGk8sS8TL2M2DUo8H?=
 =?iso-8859-1?Q?94a/+gPYAGivZLU+1UG6Hgxkt30wSPeHYFa0Xtrdu/+dKx1sWDP5Fv3iwr?=
 =?iso-8859-1?Q?u7U5kaPhuOHDPbawDJgIod8ksLGqmImc/0P217itvszTUU7j2NbMplPc+8?=
 =?iso-8859-1?Q?ubv7Ds2zqga50mG3PR3CJni6XhxNWeg1KkDesGCr8g1kDoaUlTSvTekSJw?=
 =?iso-8859-1?Q?dSfmjuL3FTS69LD70lHIhNFqKbfLkBwmHO+VpC0uSLG0dTpBleFd3WUqWx?=
 =?iso-8859-1?Q?rdvprCjMCnklW75j1GZRWcx+4hjuqDQjLNn7+SlTpOW3ejcbnxbGl10pvT?=
 =?iso-8859-1?Q?UupBrf50d8NZ3xvW+z2CvnDJSKvr+7cP3fymnIzjsVBEcK6+LUlkGrDuiK?=
 =?iso-8859-1?Q?DVAlRmLv9FZemtNBuUArO4tDkOuh4/Gylhd9sdo6lE6B6xQRUaVXkwsHfT?=
 =?iso-8859-1?Q?wgEVCPC2BxA/EuHorR2m97pV3OYpQGN2jzZDHPWFwrhqK9DQ/ehgoG3vdb?=
 =?iso-8859-1?Q?rCD1NYHs/oDZBzCT8/qctaps3tdYbiFsOcaJoqjutgfaVAqm0yTNUUYeqc?=
 =?iso-8859-1?Q?eHOMvx1vNGW6ZTm0jRIVxf5iQGSFTEYtsIcvwhg6Gon3C+g6eGbI2xVnwz?=
 =?iso-8859-1?Q?lGJyPb/sB7YOVter6aXaOB4N6i9UwtcMN28Sd4lP6hsbrbuTJH6riy58MC?=
 =?iso-8859-1?Q?5aJff2by1ADT4cefXVP6R13uEt3EJvr/F8YT+X1F93mZYJEpNwKuzOnj17?=
 =?iso-8859-1?Q?LdNochwVcDryRRMIhqFJDO1q15oFKg2ITiemSTi0kqvbTb+dEGLjTsM7DI?=
 =?iso-8859-1?Q?9VZ8OZtgx4JNpSWI8e8JaC9IMRoo3P4CVo+pfcDEGELKsMmcIOysUBNmur?=
 =?iso-8859-1?Q?5INvodLU8AI5ii94A2QbL9bqnVhIG3GgfCTwt//mQG+e7Ano61+majfYRf?=
 =?iso-8859-1?Q?MnDXnDYkY/z6AknYQwPJYaaJsUkuPvaWsiljAMKSOs+K8DpQZ0plO/SubA?=
 =?iso-8859-1?Q?P1/mEcQTboBlgLERW3xPRd+Jrfn9ZrxyfhDrueNG3gSm//0bQtgoJX+e9r?=
 =?iso-8859-1?Q?H0dUyG5wJOWCy20IyQ/0eaFpTwYOKg07MneoHY8woVnImS9DvrTA76v5FW?=
 =?iso-8859-1?Q?qlKUR5HH5G9dDWh+JnSMn9ArUhtc2NW2UefPdG4mPtBPlgGLaEOqhnHSwr?=
 =?iso-8859-1?Q?dGyCkfg9CLrIrIFRmSv6PBEnd6taz8D+gm4QuOWST/h4dsO8+Y1sWubty5?=
 =?iso-8859-1?Q?ae0LsME4B8wHsWduB5IJAVuh5nBxPh5GDwF20Q/i3GjjwQ2ExNDI+TPkoB?=
 =?iso-8859-1?Q?m7YOdAO7ir9REu59CwpI9nlAlvY75pW79VUOd3hmWjjsI4B+jqI04UR55u?=
 =?iso-8859-1?Q?zO9+KTybAx4xTqm3bOLpghWdygBY2K32DBuY+3Qo2DEd46xwPDl4hBQi2Z?=
 =?iso-8859-1?Q?xvEkSLpscx+R/K3B/rjST4P8CzsuDpxy4Zl6jVfpx8yqv9bUVK8JwxOJ7m?=
 =?iso-8859-1?Q?SwM5buVwbVKrC86RN5iB5913RZT90Ra9epsRT4R6w4CVbcOmF64vUIZLCI?=
 =?iso-8859-1?Q?wBYrfEpp5epeUqhtOPR1j4y8vl6ElzS9uSOCNO4qBkZUGrDNy/ktJhyORH?=
 =?iso-8859-1?Q?ozZq5sWRAxFtL1cLEWTNCtDEM5dcIZtdbb?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4092.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fd68d573-1085-4f6f-2b37-08daf460eb7c
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 05:50:33.1011
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YK8n6Tsf3ot2w+Cv3BZmqB4zpuWvfsNVuv1mpHq5HhsS/L6Fp2sb3Y4RNDH13oGci54R5o3vBasEG0k0VAEaUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6436
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

With this updated patches, perf uncore works fine on SPR(tested on both DNP=
 and MCC).

Tested-by: Yunying Sun <yunying.sun@intel.com>

-----Original Message-----
From: Bjorn Helgaas <helgaas@kernel.org>=20
Sent: Wednesday, 11 January, 2023 02:03
To: linux-pci@vger.kernel.org
Cc: Williams, Dan J <dan.j.williams@intel.com>; Kan Liang <kan.liang@linux.=
intel.com>; Luck, Tony <tony.luck@intel.com>; Box, David E <david.e.box@int=
el.com>; Sun, Yunying <yunying.sun@intel.com>; Jiang, Dave <dave.jiang@inte=
l.com>; Mika Westerberg <mika.westerberg@linux.intel.com>; Cabiddu, Giovann=
i <giovanni.cabiddu@intel.com>; Herbert Xu <herbert@gondor.apana.org.au>; H=
ans de Goede <hdegoede@redhat.com>; Florent DELAHAYE <linuxkernelml@undead.=
fr>; Konrad J Hambrick <kjhambrick@gmail.com>; Matt Hansen <2lprbe78@duck.c=
om>; Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>; Benoit =
Gr=E9goire <benoitg@coeus.ca>; Werner Sembach <wse@tuxedocomputers.com>; mu=
mblingdrunkard@protonmail.com; linux-kernel@vger.kernel.org; Bjorn Helgaas =
<bhelgaas@google.com>
Subject: [PATCH 0/2] PCI: Fix extended config space regression

From: Bjorn Helgaas <bhelgaas@google.com>

07eab0901ede ("efi/x86: Remove EfiMemoryMappedIO from E820 map") appeared i=
n v6.2-rc1 and broke extended config space on several machines.

This broke drivers that use things in extended config space, e.g., perf, VS=
EC telemetry, EDAC, QAT, etc.

This happened because mmconfig-shared.c checks to see that ECAM space is re=
served in E820 or ACPI motherboard resources.  If it's not, it assumes ECAM=
 doesn't work.  07eab0901ede removed some E820 entries, so it looked like E=
CAM was no longer reserved, so we stopped using it.

The machines where this broke don't reserve the ECAM in ACPI PNP0C02 device=
s (which seems to be what the PCI Firmware spec requires), but they do ment=
ion it in the EFI memory map as EfiMemoryMappedIO.

Bjorn Helgaas (2):
  x86/pci: Simplify is_mmconf_reserved() messages
  x86/pci: Treat EfiMemoryMappedIO as reservation of ECAM space

 arch/x86/pci/mmconfig-shared.c | 44 +++++++++++++++++++++++++++++-----
 1 file changed, 38 insertions(+), 6 deletions(-)

--
2.25.1