Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp10533454rwl; Wed, 11 Jan 2023 22:19:34 -0800 (PST) X-Google-Smtp-Source: AMrXdXuFpGgS9pcrm3+VEkOXfdg+ATPt7YMlaozLZ9TuVHoDw2UNWkXsskwLo6MbHuAXZZOjXKo6 X-Received: by 2002:a05:6a21:788e:b0:b5:9fd7:bb64 with SMTP id bf14-20020a056a21788e00b000b59fd7bb64mr8256509pzc.39.1673504374183; Wed, 11 Jan 2023 22:19:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673504374; cv=none; d=google.com; s=arc-20160816; b=cXBdSJKGJZuV13LoOn+SBInbvlk3iTBbT7kaydmOehUgSNCJ4AUPibkD/fO0U1LjAz FmmptJ22xfX/GhVNNMyBbHomWfNV4ULfc9NtcIZPeRzO313Vv70PWzqx0NWDNWtimlct 0lUB3C9ia6rblzp6QcwJNI+a59z9Xmm+3xqCc+3JOINJIjWjkOzxbPjVue035SHS5OzY mDy1PcNpeqMAl1gGbMSiOnEcCg9GRJaxc6fNQWWEKmF0HkXIz4H471o0nrk6k6gXBDW7 bXqDvPVlzhkQcZBIygV/HcvZ9ZPkJ6GOQiQHqG2jkxOJevzABSe1E9unX6LVvRARyFPk x99Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=UC12VzGU8VCtrmIj4zZSg34T0LFT5Z9E1mLRNWCFjCU=; b=FhZWAdpiTjbdFXyF0Pz3Nb9FF66XL9IL9HLU9ZSnpxGMordkPsUA6lZvAMBN7+r2Cy W90UVIgvUmNwhq98RHXB+Kki89yr2JkCVVRB2RdV1ieDPjzMoQc324IB3Pil7K0VtbVH ELeTbl8Wkd+HGYKgit/Oq7c3mT/h7UdjTof32U29aLuLalbm/dwcnso2hPG03I4HeS48 sLYimOURq+ywv/08+/oJXy4BXiCtEMUxaZaumzGQqyWqfRS/5xkOTj3XlfGlVt+IaCcc mWBiRFWk2HlehUwd/cW5gmAoWPzVM4IUr8DMpKN0hcfiRVjd5+5n5uB6qMLMbIK3lWXL hswg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uzE8iQ4S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f4-20020a63e304000000b004a4dc4bcac6si18072479pgh.695.2023.01.11.22.19.27; Wed, 11 Jan 2023 22:19:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uzE8iQ4S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236658AbjALFbw (ORCPT + 51 others); Thu, 12 Jan 2023 00:31:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235957AbjALFbs (ORCPT ); Thu, 12 Jan 2023 00:31:48 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AAE21B9F9; Wed, 11 Jan 2023 21:31:46 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 91DFBB81DBE; Thu, 12 Jan 2023 05:31:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E84DEC433D2; Thu, 12 Jan 2023 05:31:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673501504; bh=k6K4XfraXrxIB9XWz/v1a+l1ie9WasxsA+o7stisLAo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uzE8iQ4SeEZAe3EAL0HfEtS8gbqKAxACJQZidwntvEd1mddf6vPsHvwUD18Bd0fUo 2RnbPZJN/JWzT7UvuXBIKPuGskpAouaDHbZXHWOC5vI3NGDgQTTnSv1zXYNB5+NsYy qEQ7YaxLBxm12xkQJi3WPjyYh8Kj9ceap4m1Er94PUVA3fT7fWvaFZUfGnTvo0f46+ LusmFlqnrNEXQ8wIqsUieSRl0N2Rx3H8kvppjyZPqUZbe/Gwe8K28CjUzqp9D1EMUD RCFp8GnnRw6oTCS6iXv+x7foAyfBSKCKpqjNwvA6Dr3O+md/yMYZjWeHx2RjcGwtod IDnIl7PadwrZw== Date: Wed, 11 Jan 2023 21:31:43 -0800 From: Jakub Kicinski To: Andre Przywara , Paolo Abeni Cc: "David S . Miller" , Eric Dumazet , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] r8152: add vendor/device ID pair for Microsoft Devkit Message-ID: <20230111213143.71f2ad7e@kernel.org> In-Reply-To: <20230111133228.190801-1-andre.przywara@arm.com> References: <20230111133228.190801-1-andre.przywara@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Jan 2023 13:32:28 +0000 Andre Przywara wrote: > The Microsoft Devkit 2023 is a an ARM64 based machine featuring a > Realtek 8153 USB3.0-to-GBit Ethernet adapter. As in their other > machines, Microsoft uses a custom USB device ID. > > Add the respective ID values to the driver. This makes Ethernet work on > the MS Devkit device. The chip has been visually confirmed to be a > RTL8153. Hm, we have a patch in net-next which reformats the entries: ec51fbd1b8a2bca2948dede99c14ec63dc57ff6b Would you like this ID to be also added in stable? We could just apply it to net, and deal with the conflict locally. But if you don't care about older kernels then better if you rebase.