Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 12 Jan 2023 15:35:39 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     Andrei Vagin <avagin@google.com>
CC:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        <linux-kernel@vger.kernel.org>, Kees Cook <keescook@chromium.org>,
        Christian Brauner <brauner@kernel.org>,
        Andrei Vagin <avagin@gmail.com>,
        Andy Lutomirski <luto@amacapital.net>,
        Juri Lelli <juri.lelli@redhat.com>,
        Peter Oskolkov <posk@google.com>,
        Tycho Andersen <tycho@tycho.pizza>,
        Will Drewry <wad@chromium.org>
Subject: Re: [PATCH 2/5] sched: add WF_CURRENT_CPU and externise ttwu
Message-ID: <Y7+4S9umCo5I+Ty7@chenyu5-mobl1>
References: <20230110213010.2683185-1-avagin@google.com>
 <20230110213010.2683185-3-avagin@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230110213010.2683185-3-avagin@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7TaCULjzTSZtCuqPgY4dvvFs0pl5rSRIJlSHynBgHbSJ1f4PhJgW1l43mJRm?=
 =?us-ascii?Q?2vVCSB43SBm4R8dMB1TF87N1PO7COiiwdDF8NbilpKcVroFHFdXMxOt/yY6p?=
 =?us-ascii?Q?jSBBlyLoQmWKesMAeXEOu4sLI3XxPUOcrYIa9rM0ggDVnENwv6y55gf2EWgv?=
 =?us-ascii?Q?/PEncCoE9220WxU7Ak4JzaK2LYwEnZt3pBXK7CYFcmz4OdT6UAqq2QPZzS81?=
 =?us-ascii?Q?g9tjMXwJ4enWdoVkhAZigDVSyNvX0xgRlVUrjba1GadZjpBtbJRR9ptkHRhO?=
 =?us-ascii?Q?vybu/dw4qQhLgnzUkX90QiT2eIk0B8YBlP8ldrmzozvMcRUSsA1V3etV9y4K?=
 =?us-ascii?Q?TRn11ThNKZaQoqgpbW/kFA3qK5Ub3pd7mRtgIBDeqZXBHwHtp9B1LVug8XiI?=
 =?us-ascii?Q?B/br9mD7gsvENPutRT2m36T9c/dxf9a/ckn5EgFxy4rYYp3QKheNbP8mG0l5?=
 =?us-ascii?Q?bOktjPAbr3Ww7mikdW8ytCr4w803K7yjXg8kIXU0vFrsjanKNGoA6qURVmld?=
 =?us-ascii?Q?mIdtf+hnQmDjvMytIW4W+4PsSg2Mu5rP97417rb3gsh1BtARUWdlIrorrxG0?=
 =?us-ascii?Q?+05N1/GPMd2+uq7iZ3RYHv+qDv2W+opZprPfJzB411g+ilKSg0UTWZGa4T9+?=
 =?us-ascii?Q?+em4hR0Tcj27wIoq3nLCFp7sY3udUVAxz7BBWZvB6HRlY7bgcQsVzW/pAm/u?=
 =?us-ascii?Q?nJfrKzHt1O2KUGR6GkqUk1bggIUfdskTKq3spcnuwFbfdqFS4Id8GwRqcTuf?=
 =?us-ascii?Q?gsXFo7MCFzHDFdx9WyhbtKx57ALfGMzGYYL8BzZkakYrjPrWFyh4S1hAW92z?=
 =?us-ascii?Q?C//2DTV+bUsfVjgTkjYKFB+/WKgSOjpKMa66rDELbFTSY0Car5GvSmOu1wEI?=
 =?us-ascii?Q?UgDgL43HFqmt6TI85W55143Sdz2sviNkkz6rE0WhwLjHdT+FHVHEioBECanX?=
 =?us-ascii?Q?Iw8q+3T6mLSQtEABjqn2XGewIvGbXhheo+VB3AHqaS0A2n4i873/vkCkP1yR?=
 =?us-ascii?Q?sx5LRxf/vDPzqeFc0vUqfdeVKXk84JHf+tmlOqNZQn2P1geSt88SZvwrURgw?=
 =?us-ascii?Q?q5B7xCjq4Q3VjIndU+3MtNegw9uHp0voeyogVMixbV5PzLgfwb+U7YoHVopq?=
 =?us-ascii?Q?5mJge5hVVpslk53dRGr0APKBXhA1QuATbY9ovx2xa5Q7YvsZinWZnP4WOCLP?=
 =?us-ascii?Q?sypCK//FGy5eH/7oppo2cfPuaOz36ndWh2vv4mm3yOYknpsrC/oSIzacSPi5?=
 =?us-ascii?Q?1XQfpM2LMpOxsSK55W5k08jXxTA8yKCO/ww56Sxx3EzycXZ/zqCXZxcxYAnK?=
 =?us-ascii?Q?xRon9J2YSiZaFQML70E6V3Zc16Sh2/fL1hWZj7CpdaobGwRlak3Nk9iI27dI?=
 =?us-ascii?Q?xVEOh2f18bmExzAtFlxc8T/5VJRdn4W2ZNovwdAHPOLSNAemaEYSE3WkGXwD?=
 =?us-ascii?Q?z5q0199kDB4jdaY0RCyRNTFqYAY5vNwMEpHcdvJ2iVJD9SAtzhiTlcHlxCwS?=
 =?us-ascii?Q?HFFfj8AhxDm6Gs8grzsEtxvDY34EtkIjbFENbe0m9wkOAIUP0EhhFA2sLXhE?=
 =?us-ascii?Q?QHIhKbxLYxGoQ7dV4MCH/FJIa29p/tGSRTeZpu4l?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f484ad7-cf76-4a4a-39a9-08daf46fa54a
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6206.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 07:35:58.0185
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lMHGb3JTiyetHumJQ4Kl+V8ExAHShy98OWwf8N69Hd3mOymdjoamc5+n5N3XeEqgpfDkxFmfePHsP6NPyqi9dQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4719
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2023-01-10 at 13:30:07 -0800, Andrei Vagin wrote:
> From: Peter Oskolkov <posk@google.com>
> 
> Add WF_CURRENT_CPU wake flag that advices the scheduler to
> move the wakee to the current CPU. This is useful for fast on-CPU
> context switching use cases.
> 
> In addition, make ttwu external rather than static so that
> the flag could be passed to it from outside of sched/core.c.
> 
> Signed-off-by: Peter Oskolkov <posk@google.com>
> Signed-off-by: Andrei Vagin <avagin@gmail.com>
> @@ -7380,6 +7380,10 @@ select_task_rq_fair(struct task_struct *p, int prev_cpu, int wake_flags)
>  	if (wake_flags & WF_TTWU) {
>  		record_wakee(p);
>  
> +		if ((wake_flags & WF_CURRENT_CPU) &&
> +		    cpumask_test_cpu(cpu, p->cpus_ptr))
> +			return cpu;
I agree that cross-CPU wake up brings pain to fast context switching
use cases,  especially on high core count system. We suffered from this
issue as well, so previously we presented this issue as well. The difference
is that we used some dynamic "WF_CURRENT_CPU" mechanism[1] to deal with it.
That is, if the waker/wakee are both short duration tasks, let the waker wakes up
the wakee on current CPU. So not only seccomp but also other components/workloads
could benefit from this without having to set the WF_CURRENT_CPU flag.

Link [1]:
https://lore.kernel.org/lkml/cover.1671158588.git.yu.c.chen@intel.com/

thanks,
Chenyu