Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f9e653ce-52bb-cb89-8845-2a718e76b718@amperemail.onmicrosoft.com>
Date:   Thu, 12 Jan 2023 15:33:24 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: [PATCH v3] USB: gadget: Add ID numbers to configfs-gadget driver
 names
Content-Language: en-US
To:     Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
        Chanh Nguyen <chanh@os.amperecomputing.com>,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Frank Li <frank.li@nxp.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Dan Vacura <w36195@motorola.com>,
        Jakob Koschel <jakobkoschel@gmail.com>,
        Alan Stern <stern@rowland.harvard.edu>,
        Vijayavardhan Vennapusa <vvreddy@codeaurora.org>,
        Rondreis <linhaoguo86@gmail.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Open Source Submission <patches@amperecomputing.com>
References: <20230111065105.29205-1-chanh@os.amperecomputing.com>
 <4e98a5ee-96a1-eb98-8529-68f36c3cb7fa@collabora.com>
From:   Chanh Nguyen <chanh@amperemail.onmicrosoft.com>
In-Reply-To: <4e98a5ee-96a1-eb98-8529-68f36c3cb7fa@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZjBDRjJudHQyNHRDWkl1cHlsU28ydG9BRkNqOGQ1Yy9zeEJtWUZHekh2dko1?=
 =?utf-8?B?ZDE3YWR4Q0txTUg5ZHI3NUgrcEsvWDFaVnh4MVllNHg3YXA5REhrVHZIcnBC?=
 =?utf-8?B?c0d4K2N5djBuNDFXQldOeDlyTFhMcElLV0pYUE42UXRjTVY5SWVxZXZTaW1U?=
 =?utf-8?B?UFBmM1E1b0p6NisrL1k1TUtxVGdJaWVCQ2tSZm00ZmllSXJHY1lDQldjREVt?=
 =?utf-8?B?d0svQ3hnQzM5VXZ4UkdjMTI0R3Rsd1B5VEllRGVJUm5lb1lNSTFHNVhsYVc0?=
 =?utf-8?B?ek5yWmxYdUpRTHk1cHFMWmR2RE0rdE5ua3JQRmdyU3N4OUlCVUJZVWwvTm9y?=
 =?utf-8?B?Q1FyUHNTMUo5YkMrOEdQRGFvMnI5QTA2OHJ5cUJzMXVQWTlpZ2cyc2pkclo1?=
 =?utf-8?B?Ums1bWhCWVRnNDJrUkJ6ckwrQmFIOWxRWnhTYW5YeUd5UFdRV2ZDY0dLQVVL?=
 =?utf-8?B?TzRXYlNoSFZhdGsydjhnWVZhTHQyVU01dEsxdjF6aFQvTVU4K3BKQmZDWTlM?=
 =?utf-8?B?UGNJcU1yOXFhclV4SkpUb3ZLaytteDRIZWhaVVhla0ZyNHkwSjFkMmNFS3J0?=
 =?utf-8?B?K01DZFFqSHpxeElhUlJQSWl5bTdzUGRlYlE3amRJNENJUzJXc1FRN2hjMWRR?=
 =?utf-8?B?NEpRR1RRQjJaSFF2TDdwV0xacVZzYXZqSll6aWtNMVA0YmxuT0JOQmpsN1cx?=
 =?utf-8?B?MjJnUFdheDBBMy8xZk1FTmRyOXhrS1BpTFdYZE5oeWxjM096eFV4OC9JNUd3?=
 =?utf-8?B?SDl1emx0dXBjZGJDYlo4M1JuUDRZdnZWUnZaQllBZW5zMWNzUnZFenVuSEND?=
 =?utf-8?B?aVJSWUkwcDRtRUNuSVMySjRyem5wdyt2clFPRVp5bThTd01LclVxYXdMdVlJ?=
 =?utf-8?B?YzJJUFpoOFFtbEtWL0JaK0RCblVsSzBNN2lTYjU5cjdZTnJWT0xjT3dFaUZ6?=
 =?utf-8?B?ZzJJTmFNa3lQRDRUM0xsaklPK0pPS1RSQXR3VDAvODhyamc0ODcrYU1nYVhv?=
 =?utf-8?B?SHZNSTN3WVZFeWFxUkdkb21INCtSQ1N3MDRsdjFvY1I1MmU2R3NYT3p2aUpV?=
 =?utf-8?B?TEV0d21KZTBzVXdnR3NjOWdXMU1ZNmUxb2dQaGt5Q1p1c2NqNEVBb3ZscGRU?=
 =?utf-8?B?RzArRkJEeFV0OHlNbEYzcXFPSEQvdEwzczgwQnFkeEZoY2pvdVFQb0lMMWhX?=
 =?utf-8?B?WHU0cEFBcEswYjdLYVNPZ0N2cEhhalBnVDE3eGxjTjJUM0tXUUIxUExyTmUz?=
 =?utf-8?B?ZzF3L0tpUlR1eExxUlNESVZzNkxCcEZDTVcxVFlaS3NtMXAvZ2tiTmNjdmhp?=
 =?utf-8?B?RFFsR1owa1drckpza0dxbkRNYXA2RGJHd3cvcjloN2tqMHlIOFVtRlFKRE1h?=
 =?utf-8?B?ekUzQkEyRWRtK3pLeTg0cUdjQXJNalIxODFtTTlyNFJkbklseTBsamRablI2?=
 =?utf-8?B?VzVCU3k1bktSS2V3ZWx0U1MzNllmQVRIM0tFUUxLOHFNU3ZuNG8rbVdleW41?=
 =?utf-8?B?Qm1wU21TOGpIM1JqOU5HVHUyRDJwY3RqUnE0M0hCLy9ZNnAxVklOUktybXQ1?=
 =?utf-8?B?aVZJaW5hZU9FejRFYjN6MU4yKzErK1oyWklHWDhLWmZSZnNVS3lhNlRDcjMz?=
 =?utf-8?B?Vi9MZHBQdVh0WTNROGloZytoc0hmZTFhY3NubjJBZFIvSllHMmtCcXVkcjlS?=
 =?utf-8?B?ZDlsNW9VVHhxUnRIN29nOFhXeWQ4U2hMNFhwczk0dVluOFNjYU9UUlN0RkpG?=
 =?utf-8?B?S0ZPQWRiWXhnYW9RLzgyVGpsOHlXNXhWUzBENFNPOFF0bXdhTVRMZnkyeDlG?=
 =?utf-8?B?T3d0UmxLalkvZGpBVU8xVmNxdGlZdFVyVjBJQ3hZNGJoRTNGWnpPT0xVU25u?=
 =?utf-8?B?R1QvUWJ4amU0YTNBamRYOTRKUGZOYmtxcDdhQ1FoVVd0MUcrSXlYYUh0R3V4?=
 =?utf-8?B?bS9CMXUwZVpGRjFKOWxoNlNrOXBWaVRnRU5XM0FlV1hwbjVsS1UrcVFINlo5?=
 =?utf-8?B?a1BzU1J2MFFaOWQ2N01PTE9Wd0pkcVlvckJORXVwVDlEMHUrMmovTEVyS1I2?=
 =?utf-8?B?KzNOWWJxQ2J1Y25KMTEwSG15QzZIVjNsQzJ6Sm1ValpnQnN3ZWlLcVY4M20y?=
 =?utf-8?B?dWE2V1QxSnJlSTN3ODl6bGVXVTFoTE1WNGxBTGZqMHpqWWpsY2dMZ0NKcVdt?=
 =?utf-8?Q?27iFsyt3T5PW/T6S0dKKkiE=3D?=
X-OriginatorOrg: amperemail.onmicrosoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1cd0b497-8e71-433c-7389-08daf477b15c
X-MS-Exchange-CrossTenant-AuthSource: SN6PR01MB4973.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 08:33:34.1508
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 97UeJf7/iC7MEo3zATZpxpy8+7w1HVgIbYHiXVd0qO9jHWyYuI/9pyrQ8uPFJzTPdQurtOJPtJId1/RviHgt8+MDw9RPMCxacSO/z3ObylKLtOkB8LjgMBhByYv4lF7N
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR01MB7916
X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIM_INVALID,
        DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,
        HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/01/2023 16:46, Andrzej Pietrasiewicz wrote:
> Hello,
> 
> W dniu 11.01.2023 o 07:51, Chanh Nguyen pisze:
>> It is unable to use configfs to attach more than one gadget. When
>> attaching the second gadget, it always fails and the kernel message
>> prints out:
>>
>> Error: Driver 'configfs-gadget' is already registered, aborting...
>> UDC core: g1: driver registration failed: -16
>>
>> This commit fixes the problem by using the gadget name as a suffix
>> to each configfs_gadget's driver name, thus making the names
>> distinct.
>>
>> Fixes: fc274c1e9973 ("USB: gadget: Add a new bus for gadgets")
>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
>>
>> ---
>> Changes in v3:
>>    - Use the gadget name as a unique suffix instead     [Andrzej]
>>    - Remove the driver.name allocation by template        [Chanh]
>>    - Update commit message                                [Chanh]
>>
>> Changes in v2:
>>    - Replace scnprintf() by kasprintf() to simplify the code [CJ]
>>    - Move the clean up code from gadgets_drop() to
>>      gadget_info_attr_release()                        [Frank Li]
>>    - Correct the resource free up in gadges_make()   [Alan Stern]
>>    - Remove the unnecessary variable in gadgets_make()    [Chanh]
>>    - Fixes minor grammar issue in commit message          [Chanh]
>> ---
>>   drivers/usb/gadget/configfs.c | 12 ++++++++++--
>>   1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/configfs.c 
>> b/drivers/usb/gadget/configfs.c
>> index 96121d1c8df4..0853536cbf2e 100644
>> --- a/drivers/usb/gadget/configfs.c
>> +++ b/drivers/usb/gadget/configfs.c
>> @@ -393,6 +393,7 @@ static void gadget_info_attr_release(struct 
>> config_item *item)
>>       WARN_ON(!list_empty(&gi->string_list));
>>       WARN_ON(!list_empty(&gi->available_func));
>>       kfree(gi->composite.gadget_driver.function);
>> +    kfree(gi->composite.gadget_driver.driver.name);
>>       kfree(gi);
>>   }
>> @@ -1572,7 +1573,6 @@ static const struct usb_gadget_driver 
>> configfs_driver_template = {
>>       .max_speed    = USB_SPEED_SUPER_PLUS,
>>       .driver = {
>>           .owner          = THIS_MODULE,
>> -        .name        = "configfs-gadget",
>>       },
>>       .match_existing_only = 1,
>>   };
>> @@ -1623,13 +1623,21 @@ static struct config_group *gadgets_make(
>>       gi->composite.gadget_driver = configfs_driver_template;
>> +    gi->composite.gadget_driver.driver.name = kasprintf(GFP_KERNEL,
>> +                                "configfs-gadget.%s", name);
> 
> This line is 88 chars long, which means you're taking advantage of 
> checkpatch
> allowing 100 columns nowadays. That's absolutely fine. If you collapse 
> the above
> two lines into one, the combined length is exactly 100 chars, so you might
> just as well use a single line. In any case (collapsed or not) you can 
> add my
> 
> Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
> 

Thanks Andrzej for the review.

Just found out the commit title is not totally correct.
It should be "usb: gadget: Append name as suffix to configfs-gadget 
driver names".

I wonder if these issues could be fixed when get merged or should I 
resend a v4 with that two lines collapsed and with the title adjust?

Thanks a lot,
- Chanh

>> +    if (!gi->composite.gadget_driver.driver.name)
>> +        goto err;
>> +
>>       gi->composite.gadget_driver.function = kstrdup(name, GFP_KERNEL);
>>       gi->composite.name = gi->composite.gadget_driver.function;
>>       if (!gi->composite.gadget_driver.function)
>> -        goto err;
>> +        goto out_free_driver_name;
>>       return &gi->group;
>> +
>> +out_free_driver_name:
>> +    kfree(gi->composite.gadget_driver.driver.name);
>>   err:
>>       kfree(gi);
>>       return ERR_PTR(-ENOMEM);
>