Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   =?utf-8?Q?Bj=C3=B8rn_Mork?= <bjorn@mork.no>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Andre Przywara <andre.przywara@arm.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>, linux-usb@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] r8152: add vendor/device ID pair for Microsoft
 Devkit
Organization: m
References: <20230111133228.190801-1-andre.przywara@arm.com>
        <20230111213143.71f2ad7e@kernel.org>
Date:   Thu, 12 Jan 2023 09:33:08 +0100
In-Reply-To: <20230111213143.71f2ad7e@kernel.org> (Jakub Kicinski's message of
        "Wed, 11 Jan 2023 21:31:43 -0800")
Message-ID: <87k01s6tkr.fsf@miraculix.mork.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Jakub Kicinski <kuba@kernel.org> writes:
> On Wed, 11 Jan 2023 13:32:28 +0000 Andre Przywara wrote:
>> The Microsoft Devkit 2023 is a an ARM64 based machine featuring a
>> Realtek 8153 USB3.0-to-GBit Ethernet adapter. As in their other
>> machines, Microsoft uses a custom USB device ID.
>>=20
>> Add the respective ID values to the driver. This makes Ethernet work on
>> the MS Devkit device. The chip has been visually confirmed to be a
>> RTL8153.
>
> Hm, we have a patch in net-next which reformats the entries:
> ec51fbd1b8a2bca2948dede99c14ec63dc57ff6b
>
> Would you like this ID to be also added in stable? We could just=20
> apply it to net, and deal with the conflict locally. But if you=20
> don't care about older kernels then better if you rebase.

And now I started worrying about consequences of that reformatting...
Maybe I didn't give this enough thought?

Please let me know if you prefer to have the old macro name back.  We
can avoid reformatting the list.


Bj=C3=B8rn