Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 12 Jan 2023 16:40:36 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     Yuanhan Zhang <zyhtheonly@gmail.com>
CC:     <mingo@redhat.com>, <peterz@infradead.org>,
        <juri.lelli@redhat.com>, <vincent.guittot@linaro.org>,
        <linux-kernel@vger.kernel.org>, <pmladek@suse.com>,
        <zyhtheonly@yeah.net>, <zwp10758@gmail.com>,
        <tiozhang@didiglobal.com>
Subject: Re: [PATCH] sched: print parent comm in sched_show_task()
Message-ID: <Y7/HhF2OQQc70Dfv@chenyu5-mobl1>
References: <20221227161400.GA7646@didi-ThinkCentre-M930t-N000>
 <Y60WrwuM43HcNVC7@chenyu5-mobl1>
 <CAEQmJ=gcCx1hMf7HicE5OFeUstipdtr=3JkF1JxLuP-CrG++Pw@mail.gmail.com>
 <Y7fvOz9jZPndTDqp@chenyu5-mobl1>
 <CAEQmJ=gZJL6K1yUPq0hHy5D7Rc6g=5Ri72V_kE=xfqR6gJedWg@mail.gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CAEQmJ=gZJL6K1yUPq0hHy5D7Rc6g=5Ri72V_kE=xfqR6gJedWg@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CD6hwVJY9nRUpsotkcXneKBLv+rgOljkRY9VHm7aqQSKO/19y0NJ24AZIfMM?=
 =?us-ascii?Q?jVMrs7IhHHCJLrxUuHmf/+qiCzqrtnrdDHJeyfXSHFK+8mmcyXZwKlMNzKAz?=
 =?us-ascii?Q?2KM94/vKKtXgwZnOlERhjhuEKU6p0cYZp+EFIaHGyyPKNTuUyYFiUsymzjpL?=
 =?us-ascii?Q?65DUidQbyjn/xLFmxh9X3NOsE5ftXFFv9N6wFAvBXu0nirgs/s5abYo7Tn4p?=
 =?us-ascii?Q?TwJleYqniR7/Aydw7lpaUQ50lG+AYqXGdSOzVGJ64zaRDYjtsXk83wOhWLNg?=
 =?us-ascii?Q?kPTKvWRX5MVfq841MTM7oIyGefgceCzV5rhGKY8i4BP5wMpGVSEOOK8qQiik?=
 =?us-ascii?Q?HtN7SUvHR/o1eO6Q92K+f1m5NJg2Xwg+je9SeR97tv+uRfyJUT/3ux/Dlnnp?=
 =?us-ascii?Q?FYi0t9YEW/VmqGsaLurBI/voSQscDfRlIq4uj3l9h8e+YrGG/61BXitJdUR7?=
 =?us-ascii?Q?jhdiYYwHvq2TdmlIAnffh7vsqjg2bhAyhoYo4WEyAFQfkYNlo9ImAvYfuY7S?=
 =?us-ascii?Q?1Pqffyl0p2bnWdGlGba+mCBXjG4LM8qaZXBfvqLZxAXoRe7YVkPFbnw7vj2H?=
 =?us-ascii?Q?3Ln0ddRS5AvMSm5kpw6G7C2kVZEgAgpnH+Yb3gTojEv3ir+FvfbveO7dQF/e?=
 =?us-ascii?Q?RLLNIqMIPJh/uW50iuNA4mwIOuQPb3moiVkrKWQs7sK/mzRLzfr7Zo0Fs5bN?=
 =?us-ascii?Q?/PUoL61QwOVBvbq4SXE6awL2CGqIFCMA5eEgetIlyFM3vV78oD3f9+VyUPMB?=
 =?us-ascii?Q?ItUfCfNgMOFVaVtTQ++ZYZuYPBqyCVviMFELlFBC183CM+Vvw3HxQlho7ieO?=
 =?us-ascii?Q?podSqJMgXP5NxCcamb6cRGWrcKaULvprbKtfNzxmgkF2SkYLGoi8K7kz9+I3?=
 =?us-ascii?Q?W0wJH64MuruKSjFYJDHxJxYfXHIlI3D9LSEXqi7hi6+fm0YvaFPcRIozj1hQ?=
 =?us-ascii?Q?OLQOjZ6bl63IbD3jJnaqPjnXwjO+qzMSW++EjciN3MdSMAMafKVHRHF+/Eg0?=
 =?us-ascii?Q?kdYM8hObtF2loU7CfhM3iubnsR2WHlrEhznNK10pztfXdxfw+kDObJnq35S2?=
 =?us-ascii?Q?awUHy3vPIMYvTW3GFGUJsm8PTZgl2tKihu2cM2MS88d0Ltxktyxyhi2CaNf8?=
 =?us-ascii?Q?ttAnztcH5ClJB8j2rB3lRWx45EacBVYGzQPF+UcIUyP2uELJEu24UhVkooBI?=
 =?us-ascii?Q?ZMqfoX/gP5PNj5rs5oKVK2k5dmMhxXWT23iZ6dYNenLolU6rfUy9CKfygXCL?=
 =?us-ascii?Q?eNMpQOU3Qshjr2gTLuNYU3Ymr3LnPJ165J9k0F8HzRymLD0uoqQzSnkSwCeP?=
 =?us-ascii?Q?IjjN5qauqqcoOMdQR/p4b4w4aL0y3Gunl6dNc+MEDxod8aj1cUXA5pCKggNc?=
 =?us-ascii?Q?o9Aw5EURZLmJsiJdqP2UchPGVGqAFcG7l9Zg702IzudIlddlBrFRt6uvK4mW?=
 =?us-ascii?Q?2jvDsRQkqCbGgihDnimKm1nEyJtX1MpJghsePmsMGklo9AVIneu44IfvoNpA?=
 =?us-ascii?Q?5A9STt0DiOlVzPtdlcwxpxbU2YjuybRNrzRjcy+IV6xafJvtmLTCqC/PybFb?=
 =?us-ascii?Q?g1GDfuIg70UsGuiIgQLsOadW8Ww+pDHBw1mMQA85?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 936a51ac-62e5-45b4-8065-08daf478b6bb
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6206.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 08:40:52.9714
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: to6Qo3WUQiYj4DMSADRrEct5/DtPPT0ZeE0ni8vCg0Fs9bEE0F3fC5bOyWUo9slO0pTGN99C6fGFyJwAozh5qA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7825
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,
On 2023-01-10 at 17:35:34 +0800, Yuanhan Zhang wrote:
> Hi Petr and Chen,
> Thanks for your emails! Petr's suggestions sure make a lot of sense.
> Please review the following implementation, it would print a new line like:
>  " parent:kthreadd        ppid:2 "
>  after the origin line.
> 
> ---
> 
>  kernel/sched/core.c | 15 ++++++++-------
> 
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> 
> index cb2aa2b54c7a..86ee90404ddb 100644
> 
> --- a/kernel/sched/core.c
> 
> +++ b/kernel/sched/core.c
> 
> @@ -8853,7 +8853,7 @@ SYSCALL_DEFINE2(sched_rr_get_interval_time32, pid_t,
> pid,
> 
>  void sched_show_task(struct task_struct *p)
> 
>  {
> 
>   unsigned long free = 0;
> 
> - int ppid;
> 
> + struct task_struct *parent;
> 
Above line could be moved inside: if (pid_alive(p)).
And the format of this patch seems to be broken, please resend after fixing the issues
reported by scripts/checkpatch.pl

thanks,
Chenyu