Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <db4c34ab-fc52-f078-a87b-aa5037255e6e@amperemail.onmicrosoft.com>
Date:   Thu, 12 Jan 2023 15:40:36 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: [PATCH v3] USB: gadget: Add ID numbers to configfs-gadget driver
 names
Content-Language: en-US
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Chanh Nguyen <chanh@os.amperecomputing.com>
Cc:     OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Frank Li <frank.li@nxp.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Dan Vacura <w36195@motorola.com>,
        Jakob Koschel <jakobkoschel@gmail.com>,
        Alan Stern <stern@rowland.harvard.edu>,
        Vijayavardhan Vennapusa <vvreddy@codeaurora.org>,
        Rondreis <linhaoguo86@gmail.com>,
        Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Open Source Submission <patches@amperecomputing.com>
References: <20230111065105.29205-1-chanh@os.amperecomputing.com>
 <Y7+2ICAKlghDAem2@kuha.fi.intel.com>
From:   Chanh Nguyen <chanh@amperemail.onmicrosoft.com>
In-Reply-To: <Y7+2ICAKlghDAem2@kuha.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TDBmMHVuYWtlZTZqU1k5dngzbWRNdm90R0NjMElsbytUbU1oWkhhTzRNYnNZ?=
 =?utf-8?B?TENJd0pkYUo1enkxNHplQWRPZ2N2WVFyVmNhV0RKV2VJRFdOamgxdGNKWWln?=
 =?utf-8?B?V0VIaXNnczRsOHV2UTdpaC80eEpKTVlha0FTYVVuUXFFeE9HTGpqWTZYcjVh?=
 =?utf-8?B?bG5XdTdOQkpHYlhZeHNSNmI3K2NKNlpWK0NxUXhyMU5mc0xiUXA2NCtkSEk3?=
 =?utf-8?B?dUE2RW9PL25MSXBobWhOVFgycVNPQ0cydDVTSVJuNTNubkJpRXpIb3M4ejYz?=
 =?utf-8?B?R1YvSFdXVUxmU0lDMEF1L21OODNSVHlocVJHWkdCUHA5UnVEcDhvc3JtVU04?=
 =?utf-8?B?TncrdzBSSVJQeXoyS294em1kdFEyRExhbVQ5N3pkOGdxNW5RWGt6NU1oV2VB?=
 =?utf-8?B?aVk5dVMwRDREVkpYWEpKeUhRMGZqN0xHdTlhbk5DYzZBUGt2OVJQcm11RkYy?=
 =?utf-8?B?ZC9GQ0MxbTE3V3VaYVM2Sy9lWXpZVndHMkJPbUtRd0pSSkFJZ1NaVXBjYmti?=
 =?utf-8?B?SnRrU3haN3Voa2NrNm1BZVpTSW94dlB4RjNuZ3VvTmNKbGtaekdkVWZtaHRJ?=
 =?utf-8?B?dEJETnN0Uis4dXJOOU9PVDVKaXNiTEtzUmNqVEl5TFFUbXV2Y0QwUmRuUmZu?=
 =?utf-8?B?MU52VDE2R2t3QnV3bmR2eGUwS1BVVi9aei9Ma1cyd2RsNjNxcFNGMGwwRElI?=
 =?utf-8?B?QlFiZEQ5aU0vM0F4Tm1NZTgvb2RPWEFDTG9GTS8zdDJaVGE5ME83cHZrdW9M?=
 =?utf-8?B?QjhxZUQ1Tm9NZk5WZlUxZG85MGYvY1ZCNEpuT0k3UDZqRHEzRkUvU1V5d0k1?=
 =?utf-8?B?dzRYbnN1d01pcWxSb1JBdnlGK3kyRnBNMTVPekY2TkFSamI5dnFuR3J1dzVC?=
 =?utf-8?B?aGwrQkJibDJoWFhybHJyVitMT2NudzJuSVR6czRaaVAyUS96Vmc3MFduRFBq?=
 =?utf-8?B?eDNKYXNhOGlTWGtGbzNvZnhFREp4bGpKM1N5bVd5czg2ZFZzQjhUSGxpS2xM?=
 =?utf-8?B?WkRqU01RbFpZckpnQnFkMDduUU9LZVc5RnI0SnVZSm9iTWVVU0JyTkpoOTJ1?=
 =?utf-8?B?K2lOak5TeXhPQ1dISnRCU0ViYXpPc1NOWVJNV1oyeWhZL0szcC8rSVZIUnhy?=
 =?utf-8?B?RmtzaGpkQnVtRHZLV3p6RWczNFU4N0JseSsvQnZBRWxsSFVhbEthZ01uSUdE?=
 =?utf-8?B?R2FOZW5HZTdSK1ZkVlBDUkpvejliaTRZRmtzQU5BR09zalV3aENDZXVKQm9o?=
 =?utf-8?B?UE1PemdKTStRQ2tSa1RkVjMxWHArUFN6YlhOZDNlN1BkNXQweTRxYmVqdGNa?=
 =?utf-8?B?YVMvVUg4dzZQbUVaVXNSSStDWldud2FTOVZJaW9oU0E3Y2wva05MeDhBMmor?=
 =?utf-8?B?RFN0ZDk0c0xGcUNZaHhQbG1pU3prTmFhbW5QUEJKRW8vd0ZSc00yZGpaWFVQ?=
 =?utf-8?B?UXJGTWYvUjFKblpxSVIxOFBhakpXWFZkMWJsWTRMYzNWeTB6SmU1ZG53NERj?=
 =?utf-8?B?R25nMHZXVS9ucFkrK0wwVXA4Z053dUNTOERmYS95SVRiRjZCSmJUazVRUGp0?=
 =?utf-8?B?aVNuTDlkMWRKMDFRYVYydFIyMW81bzdDNGdZTlBVajB0dFlrK1p4ZXNrSWN0?=
 =?utf-8?B?ZlJYSXJhY1BWMlFXUXhDd0VhdlNpL2NiSmtiM2Z1NXpLQ09OZEVwd3lnWWRa?=
 =?utf-8?B?OTc2QWJDLy9qdVZ0eHdQZnh4TmRndjFjeERyWnZYZFZNZ3ZPVFJ2a05zR004?=
 =?utf-8?B?Z1dlZzlqUWxSWWVIOGhPb1A4eU1KSmhuVkJkbWZ2U0o2b0VOQjVVVzhhMWJN?=
 =?utf-8?B?WUFTR0ZOZUsyd3hZNy9FT242ZDVnOEs2K0l3WURSYUoycWFpOElBN1BVY1N1?=
 =?utf-8?B?TjJVY3ZQczh3WS9iMDdmVVRGYkVPenZGcGFYR2pBSGxwZTlLaGpqOXl3T09a?=
 =?utf-8?B?dUp6dGFPalp3WDFGbUNhd3hpcHZ1ckN3dWY2R3BVYktkUVRnYjRCc2t1eTBa?=
 =?utf-8?B?R3pwK3A2azdsamRDNng1UTF4U3huaUZUMzNXRnpXRC9XVE43NzR4QVA3NUsw?=
 =?utf-8?B?YmRBeXN3a3RwWWxmVktZQkg3eWFuSUZSL1ZOSGdEcmhETC9NSTc0cUFLOS9T?=
 =?utf-8?B?bkoxNjF4bGhnYkE3TE1VUWFiNFB1dTNPbktTbDJKODdpUmlzWDVDRzM4dVNl?=
 =?utf-8?Q?VbDKcMdfgnwgLqEUkBab3xg=3D?=
X-OriginatorOrg: amperemail.onmicrosoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f17bc304-efbb-4862-0ce0-08daf478b31e
X-MS-Exchange-CrossTenant-AuthSource: SN6PR01MB4973.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 08:40:46.7971
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GI1Q20+C2l8clZNyQqF6rVAcOYpTZQ7xmg+RERkRD8yDSTNA1MqEyFIGE0iGqtpfkK8yGSFKCxJttyWWsQ+emf1yqqomH05pkQaocEhYaRZpzrZ97pEtyQSY5kdM5AEa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR01MB4460
X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIM_INVALID,
        DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,
        HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/01/2023 14:26, Heikki Krogerus wrote:
> On Wed, Jan 11, 2023 at 01:51:05PM +0700, Chanh Nguyen wrote:
>> It is unable to use configfs to attach more than one gadget. When
>> attaching the second gadget, it always fails and the kernel message
>> prints out:
>>
>> Error: Driver 'configfs-gadget' is already registered, aborting...
>> UDC core: g1: driver registration failed: -16
>>
>> This commit fixes the problem by using the gadget name as a suffix
>> to each configfs_gadget's driver name, thus making the names
>> distinct.
>>
>> Fixes: fc274c1e9973 ("USB: gadget: Add a new bus for gadgets")
>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
> 
> Tested-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> 
> Thanks!
> 

Thanks Heikki!

>> ---
>> Changes in v3:
>>    - Use the gadget name as a unique suffix instead     [Andrzej]
>>    - Remove the driver.name allocation by template        [Chanh]
>>    - Update commit message                                [Chanh]
>>
>> Changes in v2:
>>    - Replace scnprintf() by kasprintf() to simplify the code [CJ]
>>    - Move the clean up code from gadgets_drop() to
>>      gadget_info_attr_release()                        [Frank Li]
>>    - Correct the resource free up in gadges_make()   [Alan Stern]
>>    - Remove the unnecessary variable in gadgets_make()    [Chanh]
>>    - Fixes minor grammar issue in commit message          [Chanh]
>> ---
>>   drivers/usb/gadget/configfs.c | 12 ++++++++++--
>>   1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
>> index 96121d1c8df4..0853536cbf2e 100644
>> --- a/drivers/usb/gadget/configfs.c
>> +++ b/drivers/usb/gadget/configfs.c
>> @@ -393,6 +393,7 @@ static void gadget_info_attr_release(struct config_item *item)
>>   	WARN_ON(!list_empty(&gi->string_list));
>>   	WARN_ON(!list_empty(&gi->available_func));
>>   	kfree(gi->composite.gadget_driver.function);
>> +	kfree(gi->composite.gadget_driver.driver.name);
>>   	kfree(gi);
>>   }
>>   
>> @@ -1572,7 +1573,6 @@ static const struct usb_gadget_driver configfs_driver_template = {
>>   	.max_speed	= USB_SPEED_SUPER_PLUS,
>>   	.driver = {
>>   		.owner          = THIS_MODULE,
>> -		.name		= "configfs-gadget",
>>   	},
>>   	.match_existing_only = 1,
>>   };
>> @@ -1623,13 +1623,21 @@ static struct config_group *gadgets_make(
>>   
>>   	gi->composite.gadget_driver = configfs_driver_template;
>>   
>> +	gi->composite.gadget_driver.driver.name = kasprintf(GFP_KERNEL,
>> +							    "configfs-gadget.%s", name);
>> +	if (!gi->composite.gadget_driver.driver.name)
>> +		goto err;
>> +
>>   	gi->composite.gadget_driver.function = kstrdup(name, GFP_KERNEL);
>>   	gi->composite.name = gi->composite.gadget_driver.function;
>>   
>>   	if (!gi->composite.gadget_driver.function)
>> -		goto err;
>> +		goto out_free_driver_name;
>>   
>>   	return &gi->group;
>> +
>> +out_free_driver_name:
>> +	kfree(gi->composite.gadget_driver.driver.name);
>>   err:
>>   	kfree(gi);
>>   	return ERR_PTR(-ENOMEM);
>> -- 
>> 2.17.1
>