Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp10785260rwl; Thu, 12 Jan 2023 02:30:13 -0800 (PST) X-Google-Smtp-Source: AMrXdXvtN0FB9zrodSiyTiqkqdy2b/gwHxlwpJj8NsbdXwuNQN1H9viveALtaLfCxYdhRw4lQ6x7 X-Received: by 2002:aa7:9389:0:b0:589:9b8a:9c71 with SMTP id t9-20020aa79389000000b005899b8a9c71mr11714774pfe.6.1673519413451; Thu, 12 Jan 2023 02:30:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673519413; cv=none; d=google.com; s=arc-20160816; b=rMc2iNCGPHncBW0Xe0eAQQ+DGa/cfKJYZiIcNl5Uan8rC2eh1mGk1wno1CjjLSK2Bg +SVWGXjUln/ncpUmmzGxLxSuK3cXZU3UBeNU+A3dJsvTBNdxOJy7siEVgNSR4Z8a1P+R 2x1zLHYwBPiuH8YwqCxeI0Ce3I+NFMH6yWoIx/y3/SGLJqYGFjUEhoRHHekCDjF95Q4K NBJ7rGpn4v6fo+GctUkIkwNEbmuIJzTntT2G43mOn07TUtCPYPih5qd2gQP+JnmDbwYH jtqTVVpSqM/1Vy/o8spwfPPN3fWvZTyX5B7WejduYNwtokrfaQ56xpzTwfsa1D+kVJeS 4afA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:feedback-id:dkim-signature:dkim-signature; bh=vEhta7zMZrchbjHApsTWQNVEwRZyW+Qr5Tm1UgjUS68=; b=YDT2J16lSoE0YRcLo3Fza3HMF/IwzXc21L9EthjHLh9nr1yKPX1FNJ4Pper4SfrKx1 Omba+Xob/z4Fj72F6cFe72+TJ+3rHXY3J4jS3ZpZJXIaNtjcFLjkjV42Z9fclv729w9J 3bKaLChauTxcL4SJ1N6l7PQizYgS5DiSE10BFwLv+Rv7TqNWWgmvh/7xmt36PmHfeW+9 KH/KQwuEhJ71awcib9i8PHxuvobWUfQvktgWFxOjSZLG1rPUQvwZunGdKIvL+qtNWKCd 02X+i2kS9AfYr+IOpGwAB3/2sgxcI3pf7ep7iEAHKoDkpffdwLkUQ8AivNcb2U4GgZei 73IQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kroah.com header.s=fm3 header.b="S/cdkq7w"; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=IlC3zCD3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j7-20020a056a00234700b005772295cb2csi16891515pfj.271.2023.01.12.02.30.07; Thu, 12 Jan 2023 02:30:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kroah.com header.s=fm3 header.b="S/cdkq7w"; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=IlC3zCD3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239693AbjALKOl (ORCPT + 49 others); Thu, 12 Jan 2023 05:14:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236952AbjALKNm (ORCPT ); Thu, 12 Jan 2023 05:13:42 -0500 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFFCD33D69; Thu, 12 Jan 2023 02:12:27 -0800 (PST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 66E7F5C00FF; Thu, 12 Jan 2023 05:12:24 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 12 Jan 2023 05:12:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1673518344; x= 1673604744; bh=vEhta7zMZrchbjHApsTWQNVEwRZyW+Qr5Tm1UgjUS68=; b=S /cdkq7wd6o/lMcnkf0KzrxSckHt8rkcmgQ/7bjXsCCNu2wzJehxZZiYVCtdHlOux b8BGjlNV8lLg/2uyWXuRnZoT1DkepLgH6K71+CKU6lg1tZNSnxD4swoPEHZNN0dW AWbTNZfm0EQCBiQ3sMxRPxkx+bYZRbsh8Muf032sbyYjDFkGNMlF4aodoQOzOdGC XM81nJSYZMXdYnbhI1s6J7sL1YITcmS/g3SE9aDJyaBFmDM4uWObODbvfYsmPnLk Re3E8mJX6Z10tOILlkCVEj+IyuLnq7kp07LFmQkpg0VPboyCaDBHtdLgXdT3837g W6Hwk/Ltc0TDiq6N4MoCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1673518344; x= 1673604744; bh=vEhta7zMZrchbjHApsTWQNVEwRZyW+Qr5Tm1UgjUS68=; b=I lC3zCD38qxnJMOfi/LxaGEZbv8L542ffFDUM/e/hNEwyFNW0lISQeSc9qwRCBT1X xaiUIaWwaOcnRAPHg3xxKOtz8Olsm2MOfE06FjM23BrSMMgR+6X23pRs9rKVBIzS hn8st4/DL+u3p5ZnXMLhxhtGWQi0vCmWrO5ryuHBs5VrwQQ+CmacoJeGkEedVZ1Z IF2+xL9r6XSy6tAwdYMjhUuLCyJ65Oi/gd8xVoaxEjrRxDP6H89abA+bsk2InuIZ oy/a9FgoySYSlT//wN4csVDM1kmFv6DogVuyNNHshafDzc8aISVUIUvKduDnBN6w 16S3Buj9r7iWu1tn4RuSA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrleeigdduvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtugfgjgesthekredttddtudenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepgeevve etgfevjeffffevleeuhfejfeegueevfeetudejudefudetjedttdehueffnecuffhomhgr ihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomh X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 12 Jan 2023 05:12:23 -0500 (EST) Date: Thu, 12 Jan 2023 11:12:21 +0100 From: Greg KH To: =?iso-8859-1?Q?Bj=F8rn?= Mork Cc: Jakub Kicinski , Andre Przywara , Paolo Abeni , "David S . Miller" , Eric Dumazet , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] r8152; preserve device list format Message-ID: References: <87k01s6tkr.fsf@miraculix.mork.no> <20230112100100.180708-1-bjorn@mork.no> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230112100100.180708-1-bjorn@mork.no> X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 12, 2023 at 11:01:00AM +0100, Bj?rn Mork wrote: > This is a partial revert of commit ec51fbd1b8a2 ("r8152: > add USB device driver for config selection") > > Keep a simplified version of the REALTEK_USB_DEVICE macro > to avoid unnecessary reformatting of the device list. This > makes new device ID additions apply cleanly across driver > versions. > > Fixes: ec51fbd1b8a2 ("r8152: add USB device driver for config selection") > Signed-off-by: Bj?rn Mork > --- > The patch in > https://lore.kernel.org/lkml/20230111133228.190801-1-andre.przywara@arm.com/ > will apply cleanly on top of this. > > This fix will also prevent a lot of stable backporting hassle. No need for this, just backport the original change to older kernels and all will be fine. Don't live with stuff you don't want to because of stable kernels, that's not how this whole process works at all :) thanks, greg k-h