Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <06144828-d1c4-7423-81e3-9c35df996da7@kernel.org>
Date:   Thu, 12 Jan 2023 11:10:52 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [LINUX PATCH 2/3] dt-bindings: timer: Update device tree bindings
 for cadence TTC PWM
To:     Mubin Sayyed <mubin.sayyed@amd.com>, robh+dt@kernel.org,
        treding@nvidia.com, u.kleine-koenig@pengutronix.de,
        linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Cc:     linux-kernel@vger.kernel.org, git@amd.com, michal.simek@amd.com,
        siva.durga.prasad.paladugu@amd.com, mubin10@gmail.com
References: <20230112071526.3035949-1-mubin.sayyed@amd.com>
 <20230112071526.3035949-3-mubin.sayyed@amd.com>
Content-Language: en-US
From:   Krzysztof Kozlowski <krzk@kernel.org>
In-Reply-To: <20230112071526.3035949-3-mubin.sayyed@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/01/2023 08:15, Mubin Sayyed wrote:
> Cadence TTC can act as PWM device, it is supported through

Subject: drop second/last, redundant "device tree bindings". The
"dt-bindings" prefix is already stating that these are bindings.

Anyway subject is poor - every commit is an "update", so basically you
said there nothing...

> separate PWM framework based driver. Decision to configure
> specific TTC device as PWM or clocksource/clockevent would
> be done based on presence of "#pwm-cells" property.
> 
> Also, interrupt property is not required for TTC PWM driver.
> Updated bindings to support TTC PWM configuration.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC.  It might happen, that command when run on an older
kernel, gives you outdated entries.  Therefore please be sure you base
your patches on recent Linux kernel.

> 
> Signed-off-by: Mubin Sayyed <mubin.sayyed@amd.com>
> ---
>  .../devicetree/bindings/timer/cdns,ttc.yaml   | 25 ++++++++++++++++++-
>  1 file changed, 24 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/timer/cdns,ttc.yaml b/Documentation/devicetree/bindings/timer/cdns,ttc.yaml
> index 7d821fd480f6..2855e92e02e3 100644
> --- a/Documentation/devicetree/bindings/timer/cdns,ttc.yaml
> +++ b/Documentation/devicetree/bindings/timer/cdns,ttc.yaml
> @@ -32,12 +32,26 @@ properties:
>      description: |
>        Bit width of the timer, necessary if not 16.
>  
> +  "#pwm-cells":
> +    description: |
> +      Required to configure TTC as PWM device, supported cells are 0 to 3.
> +    minimum: 0
> +    maximum: 3

Better make it const. What's the benefit of flexible cells? You also
should describe the arguments.

> +
>  required:
>    - compatible
>    - reg
> -  - interrupts
>    - clocks
>  
> +allOf:
> +  - if:
> +      not:
> +        required:
> +          - "#pwm-cells"
> +    then:
> +      required:
> +        - interrupts
> +
>  additionalProperties: false
>  
>  examples:
> @@ -50,3 +64,12 @@ examples:
>          clocks = <&cpu_clk 3>;
>          timer-width = <32>;
>      };
> +
> +  - |
> +    ttc1: ttc1@f8002000 {

Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

> +        compatible = "cdns,ttc";
> +        reg = <0xF8002000 0x1000>;

lowercase hex

> +        clocks = <&cpu_clk 3>;
> +        timer-width = <32>;
> +        #pwm-cells = <3>;
> +    };

Best regards,
Krzysztof