Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <374d0e3f-3575-329e-359c-3f900241d642@amd.com>
Date:   Thu, 12 Jan 2023 15:51:03 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH 16/19] soundwire: amd: handle wake enable interrupt
Content-Language: en-US
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        broonie@kernel.org, vkoul@kernel.org, alsa-devel@alsa-project.org
Cc:     Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com,
        Mario.Limonciello@amd.com, Mastan.Katragadda@amd.com,
        arungopal.kondaveeti@amd.com,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Sanyog Kale <sanyog.r.kale@intel.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20230111090222.2016499-1-Vijendar.Mukunda@amd.com>
 <20230111090222.2016499-17-Vijendar.Mukunda@amd.com>
 <612c78ea-335e-a196-247c-9e8f3442c3e5@linux.intel.com>
From:   "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
In-Reply-To: <612c78ea-335e-a196-247c-9e8f3442c3e5@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N05LL2t6L0xrbzdCemswWnhCcDZ0TVhEajBjMWs3dU0vTHVWSzhkSVloOTJj?=
 =?utf-8?B?bCtHNWJCaUo5YjB1Vncwak8zRjNtRXJuamJIY0ZxZ1NKRGd2a01uelFxWEt3?=
 =?utf-8?B?MlBySkROWUJtWWRKYzI1Zlpoajg0RDlEbytpMjNjUVI0N21QeUxrNzZtMzNP?=
 =?utf-8?B?eTEyVTluNGlLMWJ1dkxsM1lZdERrRWU2aGxtQVFibFlhNmVYYmlRUjl4eVRU?=
 =?utf-8?B?MVJnTUFZSFFta3ZmcEhoSGUwa21la2F5NTQrUHhTSVFLa3R0RjJEQ3FiQXJR?=
 =?utf-8?B?Z2xjM3ZJeGU5emQ1Q202NzUzNFEwdC9RTFh6MEJETFgrZXloU3VqbngvdWla?=
 =?utf-8?B?dngxMkMrUmxoeUVvVll0dTNCSkRXTGxUMUJuRFlLMThMZHFEU3dBdmlONlJG?=
 =?utf-8?B?bUJuSUZDYm5FblFwOUNqZUJ2eG9RV010Q0tZeVJUOWY1aExqZEZ6VXpNU0ll?=
 =?utf-8?B?WUVKeTljN2hPZkJBbDlxTUpkNmlRRmdzUnBza0NTTlNoUmJjQy8xaTE4Vnlr?=
 =?utf-8?B?T0FKK01veFpWMVZ0Nmc3SVBLdHVKanVnOTlOVUhzbnJ0TkN0V2NZRGRNU3Yz?=
 =?utf-8?B?Qlp2NE5pZVdKRnBGTE5aQkJiSk9wNjJ1bm5UNG9sYzQ5ZU1sWVIwMVgwNmFT?=
 =?utf-8?B?TnlSUkkzeTZ6VUk1Q1NDQ3RvV1lSTHZiY0VrS0l6MW1rT0RjY2R1UkxzVTlI?=
 =?utf-8?B?UC96Z1BmWnpoWUpjTWFtNmE1eWV1YWV1SW9Sem0xa25MNFBSWTNhaCtEdWxX?=
 =?utf-8?B?TFdtMi9HWElMZFlNZWhGOG1MdEpLV0lCakZ4UDYrenRrOENqV2phUnplQnIw?=
 =?utf-8?B?dUtSaURvYnIxZ2dsTHpTcFlFOHdFN2c5OXN6RWRVWGpXTHJkeWRqRnIrckhB?=
 =?utf-8?B?MkREK00rWFF3UXNXd3FzN2ZHd0NwcmEyZEtsRC94SW9MVDloeEI5cXdWVGhx?=
 =?utf-8?B?cm9HcE5KOEZjbTV1dHJvTFE3RTZzZ3JYNXZ2WWZwc2x2UXFaWWc5SkhrbHlk?=
 =?utf-8?B?a3JBRFdrbkFWS2F2V3U3dklUak9rYTE4SnEzcGFrTHJNbUp3Mmdnc2NSclR0?=
 =?utf-8?B?YlBnRHpxV2hIem9udjAwZTBQRVFUdkx3dmNQd0orZGNmTk5xMlZVdHlqZXZM?=
 =?utf-8?B?TXpjTlhZdCtCeVlleGZUVVNLeTF1Qk5ZM2hsS3NUcmJzejBGbkFXa3RNazhk?=
 =?utf-8?B?Sk9ncUpoYkFacUFWbnBSeElDY1VYeVA0TGM3cU5MTklLUVZFR1l4L05vNDFI?=
 =?utf-8?B?alVnWDUrWGJuMGFwQmxRQSs5NDdJeDJiWUdhSjIwcklzUXZXRFJUeFkrempD?=
 =?utf-8?B?SHR2RnpWZkJEV2crWlN5Y09vL0crbVRnd1R6TGdZY1FpUW81cXVJaXNWdXNW?=
 =?utf-8?B?U1h6cXRvOTZmVTUxQW5kOGp1TXNOVnNFd3AzTFlHQkFPWUpQL0k1Y2xZcCtq?=
 =?utf-8?B?SXorL3NObDAyQjdzdWtjQXYzdVpYdFNsY3IwaFphbmhIbGVuU0lMUTZtRDE1?=
 =?utf-8?B?MmxiVTZ1SDlEay9GZzZpY3VxMUJQY3BMcHVYY2x1WVpEOWpIeHlnMGtxRkNw?=
 =?utf-8?B?bE04OEw3VmJ6TmhiOFF1NVplOWNpY1l1dmhLU2Zkd3IyaEZFNVhzVW1naklG?=
 =?utf-8?B?d1lmOGoxSUZFaWFWdURyNnhCSUhpUnRnL2laTUVvZk9wdzdNcFdXek53SlJu?=
 =?utf-8?B?R3ZmWnBrL1JpMUZyNys5Ukk5SG82aTFRd0JHSTVyai91VGd4UjFnb2VybTQw?=
 =?utf-8?B?QzVyRGdOb2JUamlhL0kzdmxFTXU0ektad25sQ3VPQ1NuQjI2MFdOUEU0OEd1?=
 =?utf-8?B?TVJjdGlkbk5DMXF3NzhuYlFna2RoR3EwcHlRVCtqZVZnajM5WDNiRzZROFpo?=
 =?utf-8?B?ekJPVS94bXVjL0NXNWFPMU5kTWpVeVlFUUxPdjZ5T0J3ZFl6MS9taURES0w2?=
 =?utf-8?B?MXR3YS9RRldSN3BjYUpLNmRpSUdJZUxWOWUrVjFueGYvY1FFU3VITHRGZEl1?=
 =?utf-8?B?cGFXK0dhMkU1M3JGeEIyTytxTmt1QzhPZjRLcUVQMmdjWnZNM2dqcjVaM1Fp?=
 =?utf-8?B?M0VXS0Y3N1FibTFJSnZrZ3JHTmd3bGZ1aWRmVWdhUlg4ZG9hejNwS0FXYUpT?=
 =?utf-8?Q?6F8ECej1PSHzkin413myfkSfy?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4426eb74-bbbe-4026-7855-08daf486428f
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4123.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 10:17:50.6934
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3Wte0VGriYzipz+MMyI7qZ7cNKtdDvPTSDxXAfLH7myCoJkuznVAZHbLFgEjCD46g3Jwcddgd2odhfbE4iGLrQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4399
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/01/23 21:24, Pierre-Louis Bossart wrote:
>
> On 1/11/23 03:02, Vijendar Mukunda wrote:
>> Add wake enable interrupt support for both the soundwire controller
> SoundWire.
>
>> instances.
>>
>> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
>> Signed-off-by: Mastan Katragadda <Mastan.Katragadda@amd.com>
>> ---
>>  drivers/soundwire/amd_master.c    | 9 +++++++++
>>  drivers/soundwire/amd_master.h    | 1 +
>>  include/linux/soundwire/sdw_amd.h | 1 +
>>  3 files changed, 11 insertions(+)
>>
>> diff --git a/drivers/soundwire/amd_master.c b/drivers/soundwire/amd_master.c
>> index 290c59ab7760..2fd77a673c22 100644
>> --- a/drivers/soundwire/amd_master.c
>> +++ b/drivers/soundwire/amd_master.c
>> @@ -1219,6 +1219,13 @@ static void amd_sdwc_update_slave_status_work(struct work_struct *work)
>>  	u32 sw_status_change_mask_0to7_reg;
>>  	u32 sw_status_change_mask_8to11_reg;
>>  
>> +	if (ctrl->wake_event) {
>> +		pm_runtime_resume(ctrl->dev);
>> +		acp_reg_writel(0x00, ctrl->mmio + ACP_SW_WAKE_EN);
>> +		ctrl->wake_event = false;
>> +		return;


>> +	}
> this is surprising.
>
> A wake event typically happens when the bus is in clock-stop mode.
> You cannot deal with wake events while dealing with the peripheral
> status update, because you can only get that status when the manager is
> up-and-running. There's a conceptual miss here, no?
>
> If the wake comes from the PCI side, then it's the same comment: why
> would the wake be handled while updating the peripheral status.
>
> What am I missing?
>
It's a miss. This should be moved out of slave_status_work() even
though when wake enable irq is received we are just returning
from API.
will move wake interrupt handling in to a separate helper function.