Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i787e41f1:Fastmail
Date:   Thu, 12 Jan 2023 11:21:58 +0100
From:   Greg KH <greg@kroah.com>
To:     =?iso-8859-1?Q?Bj=F8rn?= Mork <bjorn@mork.no>
Cc:     Jakub Kicinski <kuba@kernel.org>,
        Andre Przywara <andre.przywara@arm.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>, linux-usb@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] r8152; preserve device list format
Message-ID: <Y7/fRlDqFRUOle7a@kroah.com>
References: <87k01s6tkr.fsf@miraculix.mork.no>
 <20230112100100.180708-1-bjorn@mork.no>
 <Y7/dBXrI2QkiBFlW@kroah.com>
 <87cz7k6ooc.fsf@miraculix.mork.no>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87cz7k6ooc.fsf@miraculix.mork.no>
Precedence: bulk

On Thu, Jan 12, 2023 at 11:18:59AM +0100, Bj?rn Mork wrote:
> Greg KH <greg@kroah.com> writes:
> > On Thu, Jan 12, 2023 at 11:01:00AM +0100, Bj?rn Mork wrote:
> >> This is a partial revert of commit ec51fbd1b8a2 ("r8152:
> >> add USB device driver for config selection")
> >> 
> >> Keep a simplified version of the REALTEK_USB_DEVICE macro
> >> to avoid unnecessary reformatting of the device list. This
> >> makes new device ID additions apply cleanly across driver
> >> versions.
> >> 
> >> Fixes: ec51fbd1b8a2 ("r8152: add USB device driver for config selection")
> >> Signed-off-by: Bj?rn Mork <bjorn@mork.no>
> >> ---
> >> The patch in
> >> https://lore.kernel.org/lkml/20230111133228.190801-1-andre.przywara@arm.com/
> >> will apply cleanly on top of this.
> >> 
> >> This fix will also prevent a lot of stable backporting hassle.
> >
> > No need for this, just backport the original change to older kernels and
> > all will be fine.
> >
> > Don't live with stuff you don't want to because of stable kernels,
> > that's not how this whole process works at all :)
> 
> OK, thanks.  Will prepare a patch for stable instead then.
> 
> But I guess the original patch is unacceptable for stable as-is? It
> changes how Linux react to these devces, and includes a completely new
> USB device driver (i.e not interface driver).

That's up to you all.  We don't add new support for new hardware to
older kernels _UNLESS_ it's just a new device id.  Otherwise it's just
better to tell people to upgrade to the newer kernel.

If you split things up and added a whole new driver, then just leave it
alone, no need to backport anything, sorry, I didn't realize that.

greg k-h