Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i787e41f1:Fastmail
Date:   Thu, 12 Jan 2023 11:36:31 +0100
From:   Greg KH <greg@kroah.com>
To:     =?iso-8859-1?Q?Bj=F8rn?= Mork <bjorn@mork.no>
Cc:     Jakub Kicinski <kuba@kernel.org>,
        Andre Przywara <andre.przywara@arm.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>, linux-usb@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] r8152; preserve device list format
Message-ID: <Y7/ir/zcJQUVec72@kroah.com>
References: <87k01s6tkr.fsf@miraculix.mork.no>
 <20230112100100.180708-1-bjorn@mork.no>
 <Y7/dBXrI2QkiBFlW@kroah.com>
 <87cz7k6ooc.fsf@miraculix.mork.no>
 <878ri86o6j.fsf@miraculix.mork.no>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <878ri86o6j.fsf@miraculix.mork.no>
Precedence: bulk

On Thu, Jan 12, 2023 at 11:29:40AM +0100, Bj?rn Mork wrote:
> Bj?rn Mork <bjorn@mork.no> writes:
> > Greg KH <greg@kroah.com> writes:
> >
> >> No need for this, just backport the original change to older kernels and
> >> all will be fine.
> >>
> >> Don't live with stuff you don't want to because of stable kernels,
> >> that's not how this whole process works at all :)
> >
> > OK, thanks.  Will prepare a patch for stable instead then.
> >
> > But I guess the original patch is unacceptable for stable as-is? It
> > changes how Linux react to these devces, and includes a completely new
> > USB device driver (i.e not interface driver).
> 
> Doh!  I gotta start thinking before I send email.  Will start right
> after sending this one ;-)
> 
> We cannot backport the device-id table change to stable without taking
> the rest of the patch. The strategy used by the old driver needs two
> entries per device ID, which is why the macro was there.
> 
> So the question is: Can commit ec51fbd1b8a2 ("r8152: add USB device
> driver for config selection") be accepted in stable?
> 
> ( Direct link for convenience since it's not yet in mainline:
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/usb/r8152.c?id=ec51fbd1b8a2bca2948dede99c14ec63dc57ff6b
> )
> 
> This is not within the rules as I read them, but it's your call...

Ah, yeah, that's simple enough, I'd take it if you send it to me :)

greg k-h