Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp126979rwb; Thu, 12 Jan 2023 04:24:36 -0800 (PST) X-Google-Smtp-Source: AMrXdXsvxwv3OPdnDSVHELU5UDqF5+jQ0HOwH3h9CbKxtEr0Ob7++/SXlU2OaKyhnBUxTAPT9xcu X-Received: by 2002:a17:907:674f:b0:864:e562:c427 with SMTP id qm15-20020a170907674f00b00864e562c427mr2749470ejc.48.1673526276572; Thu, 12 Jan 2023 04:24:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673526276; cv=none; d=google.com; s=arc-20160816; b=wV1ohi0xmGzK3jKR8rXT6mttPIfipTWB10q94UonItHv4pe9utVDyQTR0LdmoLsgGj 5WNc2cX8ogt5hIIdUTuBkpgoBd5ljIJShinFoUyEiwggr7HFZdHaw0eubIAvde8ohP72 uvMETbnyT2rOOm4qUPihDGkFOtuOZloNJasbpl7dvWjp9PZEKVm8TcrMC1UHgaM7RHRh WTYLFI192zcqZpTNUDW8RRf1DjoNYjm9JZOdQpwqV6xR76CuhJ5b2T0HZdThp6PsIg++ FouiZ5jJk6EZf4AKuLgy7YKiEdMenKZnxn55n5hKaITtOafWq3IIVifQkLPqJTYcVqMn FqOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=BG+fHBqxWABJrZCJncRSe6CbRjngbYvlt+A/PF25LZk=; b=jFkXjowrm6kOl4R+L894hFuR+kNfshEbah5xnfWITFbhwti26e1r2sFm9baJx0XNlQ QVDeh2fMx2slcGR9k9IiDS2xm9CppPD/HOV9ukTJ/UAcS7si8CCaW1N33F9v/ECFReaC DqIb5dOrAXT66n6iyuTBOt3zVbmOfUrsfszo5q9XMeqGWkOU+/rVGKediXnoE+ff9Y6G u8RSweww5bvRyGjWjRHzmyWoncVvaf4bxpHAKcwmFc/uFnSvxJ9wiZkpUMg666L3PB0W KEBMaSV9Fh6U5pvelKQLCVff0/b2uZLoC/4lMbuQkSHsv2iqiil7av0425gMIHObtCkH Vnrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=kWLGTEjx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ga27-20020a1709070c1b00b007c175331850si19564637ejc.428.2023.01.12.04.24.23; Thu, 12 Jan 2023 04:24:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=kWLGTEjx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232853AbjALLzL (ORCPT + 51 others); Thu, 12 Jan 2023 06:55:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232039AbjALLya (ORCPT ); Thu, 12 Jan 2023 06:54:30 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B4B04F11B for ; Thu, 12 Jan 2023 03:44:11 -0800 (PST) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9BBD53F068; Thu, 12 Jan 2023 11:44:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1673523849; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=BG+fHBqxWABJrZCJncRSe6CbRjngbYvlt+A/PF25LZk=; b=kWLGTEjxSQk3Cb2StwWbZFlOWF+YA0LqlBFUAyBw6edbcWEylnNhi9wRjxg8rClMbpA5qa AOYhzkfoqqPp9f1L2jnxxB04530FWTyip9X0augMuZ3x2cON1tmyHUkamLOkQdlNio3YaD uaL2HLvW4kJXyykD1dXM0uBYY4+YR6g= Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 40989136AE; Thu, 12 Jan 2023 11:44:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id nGcODInyv2MyTgAAGKfGzw (envelope-from ); Thu, 12 Jan 2023 11:44:09 +0000 From: Antonio Alvarez Feijoo To: Masami Hiramatsu , linux-kernel@vger.kernel.org Cc: Antonio Alvarez Feijoo Subject: [PATCH] tools/bootconfig: fix single & used for logical condition Date: Thu, 12 Jan 2023 12:42:15 +0100 Message-Id: <20230112114215.17103-1-antonio.feijoo@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A single & will create a background process and return true, so the grep command will run even if the file checked in the first condition does not exist. Signed-off-by: Antonio Alvarez Feijoo --- tools/bootconfig/scripts/ftrace2bconf.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/bootconfig/scripts/ftrace2bconf.sh b/tools/bootconfig/scripts/ftrace2bconf.sh index 6183b36c6846..1603801cf126 100755 --- a/tools/bootconfig/scripts/ftrace2bconf.sh +++ b/tools/bootconfig/scripts/ftrace2bconf.sh @@ -93,7 +93,7 @@ referred_vars() { } event_is_enabled() { # enable-file - test -f $1 & grep -q "1" $1 + test -f $1 && grep -q "1" $1 } per_event_options() { # event-dir -- 2.35.3