Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp162791rwb; Thu, 12 Jan 2023 04:54:49 -0800 (PST) X-Google-Smtp-Source: AMrXdXvgwD0vNds9KrMKrViDJl8MwBey5WEOO5x3kHp+OdZxzs8gWwSUCgqwSIkHeX3tI+jgsmqE X-Received: by 2002:a17:907:73c1:b0:7e7:4dd7:bc0c with SMTP id es1-20020a17090773c100b007e74dd7bc0cmr62016696ejc.66.1673528088941; Thu, 12 Jan 2023 04:54:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673528088; cv=none; d=google.com; s=arc-20160816; b=KJV0/CNUaWfMVv60MbX662vTvOEPxYb9rRj30krMOBUs31AIDLiLhWRkP9KRu4jA5c C6idksghcZLiVizlUZefKCsHUt5zcCTxUbCGDfqBaTr8OKthAzklKnll3K6gFu6W5FjK VheMEPGFMFaR581ySuIRjClUITqX3m+MVhaPWn2M4u9kSFy5aAFpED6ewpb3CbZ8b2gZ p64M9ToNtZJH4r8Md9NIbgAC3eOgfJC8WWyAijh1b3C3GJXBWqafqIz5hFkesdTtND6r jj6uiXpEriUUy5KsFNAL2OfjeLXGS8cgEo9Y092v685rw2VshY9fZfone0YhBi46x4eq +LIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Ka0B6ZRYHP+Z/pIWCv9PAnb+5byUzLYOug/EwehsPSU=; b=Yzs2iW6b0AD0Y/458utKQRI1y7me5SXJAoAL8cLe9Ol9CdCzP+hGlEy7fSikp/q33n RcNCmxL2lGk/cQX2DyoEbpnLDAXKAOSSuWSqRFcZId9EqH3pR2H4QTxL63z1VLVi+v+h rQ5pntFph9SESWTMJFIQbSfbdK1tDVtQcP44m4TO44v63D+Dkm0x+8fOXoitwoCzMuG3 br677FwYDDU7PtzecziGuozilnKr7JjA0Y3w3AFJyxAk7Fz8XXzTW0GzP45HSJBxHM6/ 9cXbAJRAy3ZvhFs4wFSMNifs7XuTADZZD1eQnC2/FCZnT9CCXp8vsPwguhZr7kbxtNhr qILw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=a0M6V+Ak; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id eb14-20020a0564020d0e00b0047ff112ee12si19655325edb.101.2023.01.12.04.54.36; Thu, 12 Jan 2023 04:54:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=a0M6V+Ak; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231240AbjALMv7 (ORCPT + 50 others); Thu, 12 Jan 2023 07:51:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbjALMv4 (ORCPT ); Thu, 12 Jan 2023 07:51:56 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B49131131; Thu, 12 Jan 2023 04:51:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=Ka0B6ZRYHP+Z/pIWCv9PAnb+5byUzLYOug/EwehsPSU=; b=a0M6V+AkuXSXH8M3porhaxRO5u JTD2y44bQVmythEQF8tkoYLs0rSzNzlPatKKr+2Ln1kFfWnkI+12Yp02hGU+EFJkaXkNx0mSExkYg IUsKZW+qmEBsIgjiiJdkt6KhVp6Zscm+ICEjIWjV5BGPp1IIbauiNNZ9LEuzlnRJfi6A=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pFx3P-001rbu-HM; Thu, 12 Jan 2023 13:51:35 +0100 Date: Thu, 12 Jan 2023 13:51:35 +0100 From: Andrew Lunn To: Piergiorgio Beruto Cc: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Oleksij Rempel , mailhol.vincent@wanadoo.fr, sudheer.mogilappagari@intel.com, sbhatta@marvell.com, linux-doc@vger.kernel.org, wangjie125@huawei.com, corbet@lwn.net, lkp@intel.com, gal@nvidia.com, gustavoars@kernel.org, bagasdotme@gmail.com Subject: Re: [PATCH net-next 1/1] plca.c: fix obvious mistake in checking retval Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 11, 2023 at 06:30:48PM +0100, Piergiorgio Beruto wrote: > This patch addresses a wrong fix that was done during the review > process. The intention was to substitute "if(ret < 0)" with > "if(ret)". Unfortunately, in this specific file the intended fix did not > meet the code. > > Signed-off-by: Piergiorgio Beruto Reviewed-by: Andrew Lunn Andrew