Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 12 Jan 2023 08:38:32 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>
Cc:     Bjorn Helgaas <bhelgaas@google.com>,
        Joerg Roedel <jroedel@suse.de>,
        Christian =?utf-8?B?S8O2bmln?= <christian.koenig@amd.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Vasant Hegde <vasant.hegde@amd.com>,
        Tony Zhu <tony.zhu@intel.com>, linux-pci@vger.kernel.org,
        iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
        Matt Fagnani <matt.fagnani@bell.net>
Subject: Re: [PATCH 1/1] PCI: Add translated request only opt-in for
 pci_enable_pasid()
Message-ID: <Y7//SDtnfXGHfior@nvidia.com>
References: <20230112084629.737653-1-baolu.lu@linux.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230112084629.737653-1-baolu.lu@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LGZ0YqmmNkoiIibvLseVvMyPQGhY6EsFhNkztmAO2l/WfC5xVFsXLd9obwrt?=
 =?us-ascii?Q?QvF19fdm4ikmOHu3IFDn1TAbjsG04HTRmUgVo8WHL8TGQe0r9WmKizTL5ySp?=
 =?us-ascii?Q?QrRNYXkAJLy81flecdwlWn+TVlJU5FLIPwn3EvAQ9sd1o85LSs6+2ssSIZEj?=
 =?us-ascii?Q?XHnTKfvpdJplbB93SfwmjhyvNtN4Mke0fhS38hA52S1LmW6y9FjajEaaTKwK?=
 =?us-ascii?Q?ozNzJ95Z7hQRn3crH67NsVDS776bVkXGdYi0Sf/+oDdc4Ywo6UbD8IKbrKq0?=
 =?us-ascii?Q?Hh9ti2Q6Yjfc4TAxOjD8VXJKBN5LcBG02FvHKWghzHri0nWh0nuNOABTbQEO?=
 =?us-ascii?Q?3THk8NVjSW8SCFJOMW/T7SZToAp+4SQYN4jmrCbm5TW3DqI+nka1uvIJGzlz?=
 =?us-ascii?Q?10Z91DoSlL3j7qmKfKPwSRQHhE5Elkws95zlH25purqxmISsks0U3DHH0GtC?=
 =?us-ascii?Q?gwIW0Q2nweAB1g6sgStOGKh4K5/KE9R75FnWo7hq0tgNmEFEebCMLVJNUX7u?=
 =?us-ascii?Q?aGNPg3EJgQwKgd/92v82wS+Gi4W3SUhOsk809Um2iyoEyW4oGjWK20svzU7I?=
 =?us-ascii?Q?dpMLqteSXS/SCY3k1xf2A/NDEemB6PfaSf3bVOrVf1dGBwS5WN18FvlcXywD?=
 =?us-ascii?Q?xybB/Mra0a2sWuR3YDIUu+cwxJPZ0yhymE3hkWVQkZjf0VqrbEVB2cK6SNdH?=
 =?us-ascii?Q?dpx/K0x8wHCrzBFqeVM4grHuvsxymeUOcE3UTJqrUk6whNbctDg9va9Ucq+A?=
 =?us-ascii?Q?0cQYGFR2x27uE/ZpcF0HFJltTiwfxXK6HWO1o6MMB7NgLM5EqrlXGRdtsKmM?=
 =?us-ascii?Q?JTNe23gYnXLewV1eczcaCLXGAjbV+ghSQOdqA5DW5i7xK5wfIcMADyTR6Yo7?=
 =?us-ascii?Q?oa0VCGL9GKNemLp+B9+bqBxi8L+bKb9lrkligbJtpq0XC5LXESZwcXdQfH0R?=
 =?us-ascii?Q?oUOKH4yo3a6EDIhofx96BP29l/M7ON98D0G7PV76lTY2Ni5uWLhRV2Js4kbg?=
 =?us-ascii?Q?Z58KMRwOVOLG4n1b/J0BewKI8vYIbJ4dGtVc0XYnKz25gn5xm5ldJxzB3/P/?=
 =?us-ascii?Q?34GvxAsbc1smQvnSO4QG8oxvAtvSGb6btYxv57c57EwnSg/5gVodaByaAkWq?=
 =?us-ascii?Q?Cy+bsUBAThq4RlsnLveZX8Lq/GBiXTusOU4Ob4D6H7U/5vZXlCg5CYuVBKUu?=
 =?us-ascii?Q?GiDXiw8YsoYxJgvDUA59aU9wYkw5Brd0rn+S0d0NyxCQ05XLpp4qKhR4epXl?=
 =?us-ascii?Q?1yRky7lCL1et9P49flwNakpDaOYGS5SzMi7iycHUfCnWlfU1RQxto7VI2xwB?=
 =?us-ascii?Q?QoyEC+2xila6ct+qOE/5HF/ued6hb/RbTuohqGMHis8ao9v9coYAq0dC7fYX?=
 =?us-ascii?Q?t9SpLEFCcaBKgQQ3asOYwZZIgP68v69EccGLmf71ChIJSe2RXPMOYubjS8mS?=
 =?us-ascii?Q?wLY/cZ+3kuO311FKa+iTr3L6z/1RFS4fC8Orn6GWkc695oJrntrdt78IFNG9?=
 =?us-ascii?Q?TCK2uUfIICsOrpt89Kjax3IwuQbUjjXVJ2Fe8vT2tMV7tjjuWBM9q5M5LYk6?=
 =?us-ascii?Q?MDlr9drK/B8rcoriPacIVJwXLDEmT2/EMjiy8OmK?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa25338e-846e-4f4d-688d-08daf499eaeb
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 12:38:33.5753
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bRdjcNdMpubm3RP8fuR8ma1zfBG6GYwebr2+lHRLx6zrL/yWZtcS3GBFX8AKpSg6
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4370
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 12, 2023 at 04:46:29PM +0800, Lu Baolu wrote:

> -int pci_enable_pasid(struct pci_dev *pdev, int features);
> +int pci_enable_pasid(struct pci_dev *pdev, int features, bool
> transled_only);

Please use a named flag so we can grep for it..

Discuss in the commit message that this is a temporary step and that
pci_enable_pasid() needs to be moved to the drivers

Jason