Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 12 Jan 2023 13:52:28 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     "Isaac J. Manjarres" <isaacmanjarres@google.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        Russell King <rmk+kernel@arm.linux.org.uk>,
        Ulf Hansson <ulf.hansson@linaro.org>, stable@vger.kernel.org,
        Saravana Kannan <saravanak@google.com>,
        kernel-team@android.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH stable-4.14] driver core: Fix bus_type.match() error
 handling in __driver_attach()
Message-ID: <Y8ACjLc272RM0vSP@kroah.com>
References: <20230110021536.1347134-1-isaacmanjarres@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230110021536.1347134-1-isaacmanjarres@google.com>
Precedence: bulk

On Mon, Jan 09, 2023 at 06:15:36PM -0800, Isaac J. Manjarres wrote:
> commit 27c0d217340e47ec995557f61423ef415afba987 upstream.
> 
> When a driver registers with a bus, it will attempt to match with every
> device on the bus through the __driver_attach() function. Currently, if
> the bus_type.match() function encounters an error that is not
> -EPROBE_DEFER, __driver_attach() will return a negative error code, which
> causes the driver registration logic to stop trying to match with the
> remaining devices on the bus.
> 
> This behavior is not correct; a failure while matching a driver to a
> device does not mean that the driver won't be able to match and bind
> with other devices on the bus. Update the logic in __driver_attach()
> to reflect this.
> 
> Fixes: 656b8035b0ee ("ARM: 8524/1: driver cohandle -EPROBE_DEFER from bus_type.match()")
> Cc: stable@vger.kernel.org
> Cc: Saravana Kannan <saravanak@google.com>
> Signed-off-by: Isaac J. Manjarres <isaacmanjarres@google.com>
> ---
>  drivers/base/dd.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

All now queued up, thanks.

greg k-h