Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 12 Jan 2023 21:16:12 +0800
From:   Clay Chang <clayc@hpe.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
CC:     <linux-kernel@vger.kernel.org>, <soc@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <verdun@hpe.com>,
        <nick.hawkins@hpe.com>, <arnd@arndb.de>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <linux@armlinux.org.uk>,
        <olof@lixom.net>
Subject: Re: [PATCH 2/5] dt-bindings: soc: hpe: hpe,gxp-srom.yaml
Message-ID: <Y8AIHDizIqu9u9BR@enigma.ccjz.io>
References: <20230110042533.12894-1-clayc@hpe.com>
 <20230110042533.12894-3-clayc@hpe.com>
 <110af65f-9c18-524d-a073-ef7be60d1f5a@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <110af65f-9c18-524d-a073-ef7be60d1f5a@linaro.org>
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0RUWhXAvQO8Q2RosKo5rbeRLnbNizjL7Gj6eeoXUELEjnhZWNdJzMBTOzU7n?=
 =?us-ascii?Q?HusvHqghoqLI8vWCvlzg9WxuScbQoNsVjNzasto6xQOdiSwrYJCxkM5Q458d?=
 =?us-ascii?Q?SQmBcI0DFsX/xISqdjk53fGAnnhZNm9DHjNsMHFMCrEnXOABbc1P89BLaKU9?=
 =?us-ascii?Q?BxZJHNg0iwK8nsNMcAnzgAd8yuhHAYLE5F8e5ZMNy4wuofCsHmtEZeKUJh/D?=
 =?us-ascii?Q?Enlys0ASUCpdHzjWC2Wd1mOY7eQRTYIkWAnB+CsS4P2Nwd/36dyFzjJOhFCI?=
 =?us-ascii?Q?A0HTuE4xye49mjf98LI6gI/Lxll41pn1UpAX3TS/ghpEQOA29+gpY8eCg9ZY?=
 =?us-ascii?Q?xrCTGSEpaBvw3G25GmVdFkzieBVAg44j+25XIX9MwSbkC4quXAM9SCpwEIsK?=
 =?us-ascii?Q?1+NlUpdcaaPGUWNqq7H9UNRr2bY/TuyeONQsPfUluZaFzjUwTF9UQ+vPLHzv?=
 =?us-ascii?Q?NpVriZ93N/3yu86/S5j9Mgi+yJu8L2zsZ2IDV7QznJgoXwydqIZVVRto/Sl9?=
 =?us-ascii?Q?4ZlPhepwDt4h6DVKQo3ekKlzqTur3AVrqw79+5aZ5tI9vsjqvB3FytuylUjK?=
 =?us-ascii?Q?d06L41SCMGI67bkVDh5z3G8zo1jwyFFWxcwWD8gqJOt1cTPFg9egBx0maWKw?=
 =?us-ascii?Q?lA+dbOlyzGTroQD+HOW+m/9dNXEGmWm5DjRdfFToAGVaZ3LWKcPE9p8PwzH3?=
 =?us-ascii?Q?N7J6OcNll2BpLK59vK10oAsI+ao0o0f5lsop+CPWgG/IDa0ztoPdGnbHs/sH?=
 =?us-ascii?Q?reu3Cfk5OEb3OC42LPP7qJ0yBYwoj5PrfdgR+uTr0+bR28dP9BqI8vv0VcP4?=
 =?us-ascii?Q?UbQJHnD+kmVoOVtHmThSbQcDEDUn8YY7zrISowV4KEsWDObXDJFnZrf3tRuw?=
 =?us-ascii?Q?DcqArsvtXToHAwShZbQv91Ngh7j9qiBL8dD1WPmICYig4pNhR7lZiLLUdf97?=
 =?us-ascii?Q?p4UZhS4hQZOwmVBieMyDrK+CVakPjQdK+aXNsOOQ2F54KN+cZsZxF3CiW1l5?=
 =?us-ascii?Q?1vCNBji5AYeid90ySDbXW0vxBHXjS8OlEBBEoDKzw+XhC/RABY4rV7+q9hdB?=
 =?us-ascii?Q?wEQXa9zgcs3K9ZETI2D1s6AUHMkhiLNQ+mVLbCtKrpNoh7fFxKIUY3SCsqRB?=
 =?us-ascii?Q?al7A/Ct1auZSxJKf1RKkfDHHpqQXBXT1S+tp4L2DHWLmfIl9LFRH9BsACH70?=
 =?us-ascii?Q?Q5/OXHN3QIp0NooAgmZmKYqyhuZPBTsx/cPsRgPLPEtj6PEVcUcllkp/MNA/?=
 =?us-ascii?Q?gyMhsfb2dMItYRlich790NCTpBL1Y4EUD88fsXEAHYNCwB7m2nGYSCk0/bf1?=
 =?us-ascii?Q?5KhrXKSuZ9YhFn3nPSAdrt580nFoDX5TPL85kTC7SwOv9zWZHLC6SbGTrot8?=
 =?us-ascii?Q?DkFxnklrUzyRZ6gpfr5jcyS8OrVDbh3N/FPW8Z+vAvGUDz7VOLUcRLSBh1uk?=
 =?us-ascii?Q?jYkyLWTdNzbh1QmOoy0gDSUYFlCKP2//cK5gp//5I1nint3yqwRo1MXdUiA/?=
 =?us-ascii?Q?oduaKCzHUaj4pPmW0n6CR3TILKxYNLsLYmu8zN8MohpSsWTupzbn8afnA0X2?=
 =?us-ascii?Q?24dquDrQkRtTOFAvPb/5JwKQVXNUUus5pByde+mnqrGlVpcd+u+fGRDT7eMK?=
 =?us-ascii?Q?Yw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ec6901f1-39ff-43a8-3f42-08daf49f3168
X-MS-Exchange-CrossTenant-AuthSource: PH0PR84MB1480.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 13:16:19.4114
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qd6SFSjqq8KRQxLp7bGM5Iib+ONeckweXS8IuxyIHLL6P2QvIO7s9MwOjbUAwmt2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR84MB1658
X-OriginatorOrg: hpe.com
X-Proofpoint-ORIG-GUID: 6qptj6cMRyW3nwowEXMRFAJCTazJl6eh
X-Proofpoint-GUID: 6qptj6cMRyW3nwowEXMRFAJCTazJl6eh
X-Proofpoint-UnRewURL: 2 URL's were un-rewritten
MIME-Version: 1.0
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2023-01-12_08,2023-01-12_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 mlxlogscore=999 suspectscore=0 bulkscore=0 impostorscore=0 malwarescore=0
 lowpriorityscore=0 clxscore=1011 phishscore=0 mlxscore=0 adultscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301120094
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 10, 2023 at 10:49:36AM +0100, Krzysztof Kozlowski wrote:
> On 10/01/2023 05:25, clayc@hpe.com wrote:
> > From: Clay Chang <clayc@hpe.com>
> > 
> > Document binding to support SROM driver in GXP.
> > 
> > Signed-off-by: Clay Chang <clayc@hpe.com>
> > ---
> >  .../bindings/soc/hpe/hpe,gxp-srom.yaml        | 36 +++++++++++++++++++
> >  1 file changed, 36 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/soc/hpe/hpe,gxp-srom.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/soc/hpe/hpe,gxp-srom.yaml b/Documentation/devicetree/bindings/soc/hpe/hpe,gxp-srom.yaml
> > new file mode 100644
> > index 000000000000..14ad97d595c8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/soc/hpe/hpe,gxp-srom.yaml
> 
> Don't drop stuff to soc. Put it in respective directories. This also
> applies to your driver.
> 
> SROM controllers go to memory-controllers. What is this, I have no clue.
> "SROM Control Register" is not helping me.
> 
> > @@ -0,0 +1,36 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/soc/hpe/hpe,gxp-srom.yaml# 
> > +$schema: http://devicetree.org/meta-schemas/core.yaml# 
> > +
> > +title: HPE GXP SoC SROM Control Register
> > +
> > +maintainers:
> > +  - Clay Chang <clayc@hpe.com>
> > +
> > +description: |+
> > +  The SROM control register can be used to configure LPC related legacy
> > +  I/O registers.
> 
> And why this is a hardware? No, you now add fake devices to be able to
> write some stuff from user-space... Otherwise this needs proper hardware
> description.

Thank you for commenting on this. You are right, this is not a real
hardware device, but simply exposes MMIO regions to the user-space.
Maybe we should rewrite this as a syscon driver. Is writing a syscon
driver a right direction?

> 
> > +
> > +properties:
> > +  compatible:
> > +    items:
> 
> Drop items, you have only one item.
> 
> > +      - const: hpe,gxp-srom
> > +
> > +  reg:
> > +    items:
> > +      - description: SROM LPC Configuration Registers
> 
> Drop items and description. Just maxItems: 1
> 
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    srom: srom@80fc0000 {
> > +      compatible = "hpe,gxp-srom";
> > +      reg = <0x80fc0000 0x100>;
> > +    };
> 
> Best regards,
> Krzysztof
> 

Thanks,
Clay