Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <78a15f05-29d7-9dd3-175a-3915e7357c11@linux.intel.com>
Date:   Thu, 12 Jan 2023 21:25:25 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Cc:     baolu.lu@linux.intel.com, Bjorn Helgaas <bhelgaas@google.com>,
        Joerg Roedel <jroedel@suse.de>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Vasant Hegde <vasant.hegde@amd.com>,
        Tony Zhu <tony.zhu@intel.com>, linux-pci@vger.kernel.org,
        iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
        Matt Fagnani <matt.fagnani@bell.net>
Subject: Re: [PATCH 1/1] PCI: Add translated request only opt-in for
 pci_enable_pasid()
Content-Language: en-US
To:     Jason Gunthorpe <jgg@nvidia.com>
References: <20230112084629.737653-1-baolu.lu@linux.intel.com>
 <Y7//SDtnfXGHfior@nvidia.com>
From:   Baolu Lu <baolu.lu@linux.intel.com>
In-Reply-To: <Y7//SDtnfXGHfior@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/1/12 20:38, Jason Gunthorpe wrote:
> On Thu, Jan 12, 2023 at 04:46:29PM +0800, Lu Baolu wrote:
> 
>> -int pci_enable_pasid(struct pci_dev *pdev, int features);
>> +int pci_enable_pasid(struct pci_dev *pdev, int features, bool
>> transled_only);
> 
> Please use a named flag so we can grep for it..

Sure. What do you think of this naming?

+ * @flags: device-specific flags
+ *   - PCI_PASID_TRANSLED_REQ_ONLY: The PCI device only issues PASID
+ *                                  memory requests of translated type.

> Discuss in the commit message that this is a temporary step and that
> pci_enable_pasid() needs to be moved to the drivers

I will add below in commit message:

At present, it is a common practice to enable/disable PCI PASID in the
iommu drivers. Considering that the device driver knows more about the
specific device, we will follow up by moving pci_enable_pasid() into
the specific device drivers.

--
Best regards,
baolu