Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1a14e117-4216-b98d-f972-c9a02cf79d1e@amd.com>
Date:   Thu, 12 Jan 2023 09:29:39 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH 19/19] ASoC: amd: ps: increase runtime suspend delay
Content-Language: en-US
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        "Mukunda,Vijendar" <vijendar.mukunda@amd.com>, broonie@kernel.org,
        vkoul@kernel.org, alsa-devel@alsa-project.org
Cc:     Mastan.Katragadda@amd.com, Sunil-kumar.Dommati@amd.com,
        open list <linux-kernel@vger.kernel.org>,
        Basavaraj.Hiregoudar@amd.com, Takashi Iwai <tiwai@suse.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        arungopal.kondaveeti@amd.com,
        Syed Saba Kareem <Syed.SabaKareem@amd.com>
References: <20230111090222.2016499-1-Vijendar.Mukunda@amd.com>
 <20230111090222.2016499-20-Vijendar.Mukunda@amd.com>
 <c7f018e3-c8be-6819-0ece-244bfb943c62@linux.intel.com>
 <0aaf3fa5-bcf1-ec06-8f78-c61e8809398e@amd.com>
 <5a34e6f7-eaf1-8128-81e4-81f65541d9a8@linux.intel.com>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <5a34e6f7-eaf1-8128-81e4-81f65541d9a8@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a0ZEbFh2MnU4T1pHVWNQUVIzdmNHQmhhMHhHSUVJVm1oNEt6b3lUT1RHVkFU?=
 =?utf-8?B?ZzZFeFVQNG0zajVUdFFXS3BPdWZObWw4TVNyaWlqSlRCK0RQcFJjUTV1RXJt?=
 =?utf-8?B?S2t3RVpCaFlvcVdSbTZSM2ViamhxaFRPalZVeXVLSnNYenlNcjlLREJ1YVZJ?=
 =?utf-8?B?RUxWV1JLczRaczB0ZDVNT3ZRQi8xalhVNDZ4N2Z6bU1vRzFLTXhaWkpVemtP?=
 =?utf-8?B?OU52MzhDcmpQa3hqRHdXRGQzWlpDaG9PZ25sVnl2YUcrV0x4YklkNjRLTjg0?=
 =?utf-8?B?MmJZSGUyaDFLdGhERWl1TWdhTHRoampXSElXdXVkeDh2WWRIdC9salR1dlVU?=
 =?utf-8?B?M0xKOWExeGI2Vzc5UE8wY3gxR1d1T3YrV20ra3ZpUHJDSm1pMHVnTy9iMlB0?=
 =?utf-8?B?cTZoR2VMNXR4aUZiaDl2eVBvWXU3U0lHVGtZRXM5UzJFS1hvQU1FMzllWFE3?=
 =?utf-8?B?d3hhMk5tbGpSNWlsbUZXR3RBYTdteHQweDdOV3lMbXQzREh3dk5MMHg1UVo5?=
 =?utf-8?B?YkttSlA4ckRvc2taa1BpcUJCbnRqd0FPZ2prNXRTZzN3UnVZZU1FSVRvOHFs?=
 =?utf-8?B?Y2tYVW4wekI3UlR2ZC9GeTJsVzF2R25SYyt4TXk1eFg3emlOUzNZaElwN3Fw?=
 =?utf-8?B?am93MXlrTGUxdi9vekVkVVNMRVFqbFlLR3JzOWo5V0tNMXVRZFNGM2tCWVZV?=
 =?utf-8?B?aHpFK3pUdlFuQzNsVU91QlNwV3VacDFaWnlnb0JwTGhFRE9YdVQxcjNTY3lW?=
 =?utf-8?B?K0J5RW9qOC9kV29YeTRaMHdxS1NMYUEzeWdjUEYyaGJVWjhucExIa3Fuenpi?=
 =?utf-8?B?amR0RDRmaFJVSzRwRURQdDVyMjBvUmJta01TTUpvYlRtY0hXbWpJckR0QUNY?=
 =?utf-8?B?elZJS0E0Y3Eva2VNbXJxNy94M1N2TlFIeXlFOHlrdjNGUk94RnZ2aFBvMlE1?=
 =?utf-8?B?N1VZWStyVjZScDFVMWQ5a1ZRMjF6Qkg2V1hEMjN5WnFhc0dXYkQzZno3a3hu?=
 =?utf-8?B?a2JXMkNpNFlzSVkrS01TWUxiQ1A0RzlvNzg0RGdCMTlORlpHY3ZhZXVLaXd3?=
 =?utf-8?B?R09LeGdIeXBFelo5NEZFdkpuV3NwTVRFRDNYMUtxeVkzMDdBSDMwSVdTMm5y?=
 =?utf-8?B?YmhHZGFqVlM4bEJIRlNDaS9qVzNHU1ltYmlFWGxZTDZXQVNqYVNnMFNtbSs3?=
 =?utf-8?B?L01jQWFJRUhhcDZTaE9BYzJRNGo2OW9kS3Nyb2FZZHNzcFQ3a21acmk0U0Zj?=
 =?utf-8?B?S0pnbzhzVFZETzc5N3FYNVJOVzByVVlSNWhwQXEyWUtleXlFSW8xNEFYTU14?=
 =?utf-8?B?dmNGajFSbldjWERpRkxXU3RWbzg5bitBMllZckpKVVJHRThkVnZ4ZzNUR3JG?=
 =?utf-8?B?SkwyV242OFljcDR3VEU2UEQwSU5XSTlkOERGaThKSTlPUk1uZ2U2a1hMNjFX?=
 =?utf-8?B?bHVLTVpweDNTU203MHFmbE1raEJiOHRGd1Ywa0hLS1A1MVg1RVJWVXVMT1lr?=
 =?utf-8?B?NWlDMGdFcmRXcG5IQ2R6K2dGN0YzZ2c5dVJKRDFGTlU0dmtNNHFpbTJDdHpV?=
 =?utf-8?B?cTR3V2lUeTNIbGhjbFo3WURMN0ZBUDRMVlhsbFI2MGtIamFzaGpCRSt6TjFh?=
 =?utf-8?B?ZG03TVF2M212bzk1ZEsyK1I4YVdRWm9lTFA2U3Q3dHl5eUlBcEtGcDYxWGl5?=
 =?utf-8?B?QW41UTh0UVVKTkpUS2p4ZU8zaDZ5c1hxQ1FheUlIbWhqejBVeVNOdmFaQ09C?=
 =?utf-8?B?WmdGRC9VQ0had0YweiszRzBQMHR6aXFPQUIzZXdNTHBvdGlaa29xcUoxTVpi?=
 =?utf-8?B?SzN0R0VYNmVTTnM2bDcxc29WTEhmU1FCb1BBbkoyb05SZGp0czluVlByVlA5?=
 =?utf-8?B?OXA5Q0xjQjhQL0RRZUlxeFBIM0MwSUgwVk1FYXNyVG9ST1BZdDdKdXlyUWtP?=
 =?utf-8?B?U25HVEc5d1FoT1d2NFFRYzA4Lzl5anpWWE5LZEJDOHIxc2IyMWtjSytOS1pD?=
 =?utf-8?B?MllZVnpaNXQ1Y0lTd1c0QVhDODZ3d1k3b1FsY1hhOEZ5R0l2ZmpmYUl5Vmo4?=
 =?utf-8?B?NGI4dC9GTDNteHhXTkJKS2VoYnA0SC95TGc4bmpYRFV5MXNiSDNhajZLeGNk?=
 =?utf-8?Q?A1x74XtgyrRbnc05iDuQ2wc7p?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 28554082-8823-498e-145f-08daf4b1d3a7
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 15:29:42.5708
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wg2lWoC5gOolxQPIHFLcmjFW7NPCvFA2GiCgwP3k6q+bLNRfLgnNOINFH0fP7PX0nLnGK4D0Qf+WQAt8Fqi78g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4236
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/12/2023 08:54, Pierre-Louis Bossart wrote:
> 
> 
> On 1/12/23 05:02, Mukunda,Vijendar wrote:
>> On 11/01/23 21:32, Pierre-Louis Bossart wrote:
>>> On 1/11/23 03:02, Vijendar Mukunda wrote:
>>>> To avoid ACP entering into D3 state during slave enumeration and
>>>> initialization on two soundwire controller instances for multiple codecs,
>>>> increase the runtime suspend delay to 3 seconds.
>>> You have a parent PCI device and a set of child devices for each
>>> manager. The parent PCI device cannot suspend before all its children
>>> are also suspended, so shouldn't the delay be modified at the manager level?
>>>
>>> Not getting what this delay is and how this would deal with a lengthy
>>> enumeration/initialization process.
>> Yes agreed. Until Child devices are suspended, parent device will
>> be in D0 state. We will rephrase the commit message.
>>
>> Machine driver node will be created by ACP PCI driver.
>> We have added delay in machine driver to make sure
>> two manager instances completes codec enumeration and
>> peripheral initialization before registering the sound card.
>> Without adding delay in machine driver will result early card
>> registration before codec initialization is completed. Manager
>> will enter in to bad state due to codec read/write failures.
>> We are intended to keep the ACP in D0 state, till sound card
>> is created and jack controls are initialized. To handle, at manager
>> level increased runtime suspend delay.
> 
> This doesn't look too good. You should not assume any timing
> dependencies in the machine driver probe. I made that mistake in earlier
> versions and we had to revisit all this to make sure drivers could be
> bound/unbound at any time.

Rather than a timing dependency, could you perhaps prohibit runtime PM 
and have a codec make a callback to indicate it's fully initialized and 
then allow runtime PM again?