Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e4392f40-74bc-77c1-6058-941a7788fb02@amd.com>
Date:   Thu, 12 Jan 2023 11:08:08 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH] drm/amd/display: Fix set scaling doesn's work
Content-Language: en-US
To:     Harry Wentland <harry.wentland@amd.com>,
        nicholas.kazlauskas@amd.com, hongao <hongao@uniontech.com>
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        sunpeng.li@amd.com, linux-kernel@vger.kernel.org,
        alexander.deucher@amd.com, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        aurabindo.pillai@amd.com, roman.li@amd.com, Jerry.Zuo@amd.com
References: <20221122112034.30080-1-hongao@uniontech.com>
 <789c2c61-4959-c3c1-0916-d1cc7f659247@amd.com>
 <aea4b937-351a-f036-61e5-790af633f5f2@amd.com>
From:   Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
In-Reply-To: <aea4b937-351a-f036-61e5-790af633f5f2@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NldEaEVwSU1Tc09hYmxUNmNrR25WK0RLc1Ezdm9JSVl0L2FBMFF5bTdvNlpn?=
 =?utf-8?B?eEZrVmE2L2lqV0tmYUwxUzlYdEhsbDUvODBHMnIzOTRQRkZVbnhreVBqQkFw?=
 =?utf-8?B?L3F3RnVMK0FqU2tpOVVha05rcEhMZWFQbHYrSloxY1FvQlNWNFNmYWdHQmhy?=
 =?utf-8?B?Q0phaUFtYVRNTmNvSm8xbFdvU1R1VmZ1bUQ0Q3drS3psdjd6eGJ4clV4b3Ir?=
 =?utf-8?B?NklCb3JRT1E3TFpnL1FzZnZZTytGbHVUcGV2YnpSaEp5Q1lNNzFLVERjZTZM?=
 =?utf-8?B?SmdFNTBSdVc3MlI3MTBhNzNKZGhsUDVWVjdmMmZMaDU3dUlBL2JyV1dScC9Z?=
 =?utf-8?B?SDdGbHJCVlRZbUgvL0lEQnJncU1idVcrWURJRWt6ZVk2NVJCaWgzSXo4Z3R0?=
 =?utf-8?B?ZlBPUTNXWksvbFZ6cDJZWkRUWjF3TE04WUVaanBRdDhXUlE2RkhZcUlVcWxU?=
 =?utf-8?B?NTk4Qkphc01PaGJnV05zblRPNzBFQmdBcFVZOW9VZURpZmF5MENUeTZ1dzI0?=
 =?utf-8?B?eGlnRnI4OXIyTnRSOUsyVndINERRMVBwVmJ0NTZYU0tZLzRrYUtqMUJPcTlT?=
 =?utf-8?B?TDJWczlBK251TTBLbW56R2RPT0ZManI1Q1JOc0tBdWdMSGVmUU04OWVmakQ2?=
 =?utf-8?B?VDlWL1ZQK25MUVozZE81T2FZbldyNVZjb0QrV2xjL25YaW5ZdW9FalVPK0FM?=
 =?utf-8?B?MTR0dDNSeTlEVTd0bFRNa0xWS1FWRXNCdzEzVDQydlJsT0tzU09jcEdQOUZy?=
 =?utf-8?B?anhOZWRvWDdTamU1UEcxUnZURG1Ea285SkVBVHlZQzF3d1hSaHRVdjZHNTlQ?=
 =?utf-8?B?c0luNU5ianVtRVhvVjFjbnNneDdoM0FDSElHSnV6TTZSOTViNE10YmZ5T0hZ?=
 =?utf-8?B?VHNkc3ErN2RhUXEzM2FXQmIyV0hjL2dSUVl4b1N2amN1RVpFN2hGeWlpTWN1?=
 =?utf-8?B?WE9VeU4wYm9rNGpzUEsyRlNYeVJPYzJOc2g1MllGUmcyRm54akNPdm1BZm5T?=
 =?utf-8?B?Vnlhang2dlEvM04veHNxQUp0eG5tQWc5RHZObXdzY2JSblNnRGpEeDMxVmY0?=
 =?utf-8?B?QUF3azI3SGVMYnlYZXAvTWtFbGxrcFhiK0s1bkhUUjI3TVRVNStaSGo3RVRi?=
 =?utf-8?B?cXJtbDd4L3Q0TE5JUzBUTURNUU9JeGxxeHZsZGVCRkJsU0xEQzlSVFl5TzVa?=
 =?utf-8?B?UWpFbmFGNEZpZFdKRERvZ1R6MmpKcFB5VG05T09XMUsxdTk3cjduVy9zcFFX?=
 =?utf-8?B?MTNUYzBmUzZkbElsMHFIQndNMUNSNnl5elF3ZG5nNndPNVdWUlZIcUw1RWEr?=
 =?utf-8?B?RzZuMW5xL25uWEk5b0p0dk5CMW5KWUhLaHV6bUpxUFNGNlhBTlVyUFhCWi9o?=
 =?utf-8?B?UkY4N0NGdGdiN3F2d3c3UlFNKzVUM1VyckpMekFtU2FCWVoyZ0NpSGVRUlhh?=
 =?utf-8?B?YWxjbEhZbkpWQUtxMEdXVHdmTTlJSWw4QTRwaTY2WGJHeFoxSVBzQk12bVFQ?=
 =?utf-8?B?ajNDNkZ4Qk51RVA5QW1JclZKaTJVNWtmY09DTzF0N3dxUmR4TTJjNWRmbXMx?=
 =?utf-8?B?N0NBR3BXc0Y3dWJlNUZWRmVtUllwdFZ1QnRjcXptQjBTNTJFK25wNFJzeXlx?=
 =?utf-8?B?eEE2aFdJaVh6czFvY2oyb2pTbU5HQVFlZy8wenl0dmZWTi8zTlZlNjB6U0c1?=
 =?utf-8?B?VmdXc0FiamtkbzVIL0hGQnVoK3NFbXV1RTYxV0hablJWK09XVEVuc3RpcVYv?=
 =?utf-8?B?WkVYU2w2Y3ZIa1dnRThiS3NmRVZLdGg4UVQ0dWFFY1pWWmMyTlZmZ2VOK21K?=
 =?utf-8?B?SkNjSVdhTERyUnJGYnpYL3dhbitpQW5ZWkl6cE9FQStoRGR2V0RrM3ZBLzU3?=
 =?utf-8?B?REpGanh4cldUTjR4a0ZyeEIwMXFYQ2hORGlwaHprT2d2SzhkZ2w5SGQxTUxD?=
 =?utf-8?B?ZHFtSkNLNzZ4QWhrTStqSm83Nzg2Y3pVdmd4bTlOcXdtUzhrcjJuZ29lQkp1?=
 =?utf-8?B?eW1RblMwQzFGR2pjUE1jM1dTTVoxMk9qU1hFaFk4cXpYOXJ0RnRuYkZJeHJj?=
 =?utf-8?B?YmJxNkVQVHFPc3VCZm1kTldodlMrcGpTU1ZQSCt4ZzNyZ2VkYUJISGVNV0tv?=
 =?utf-8?Q?ePxYUh9vO1AISU2gtODybdmet?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 379fdfc5-e5b9-47a3-9a09-08daf4b73346
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2941.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 16:08:10.5147
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OUZkqxEiC64BCMkmlmfE9tDtyvHk9Q47tRPzhb8IQFA8Lc2JjHRzmzN0ZcEj7cAvHZbpFkc2MRl1ROuHnGycyg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB8616
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/11/23 10:19, Harry Wentland wrote:
> On 1/10/23 10:58, Rodrigo Siqueira Jordao wrote:
>>
>>
>> On 11/22/22 06:20, hongao wrote:
>>> [Why]
>>> Setting scaling does not correctly update CRTC state. As a result
>>> dc stream state's src (composition area) && dest (addressable area)
>>> was not calculated as expected. This causes set scaling doesn's work.
>>>
>>> [How]
>>> Correctly update CRTC state when setting scaling property.
>>>
>>> Signed-off-by: hongao <hongao@uniontech.com>
>>>
>>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>>> index 3e1ecca72430..a88a6f758748 100644
>>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>>> @@ -9386,8 +9386,8 @@ static int amdgpu_dm_atomic_check(struct drm_device *dev,
>>>                goto fail;
>>>            }
>>>    -        if (dm_old_con_state->abm_level !=
>>> -            dm_new_con_state->abm_level)
>>> +        if (dm_old_con_state->abm_level != dm_new_con_state->abm_level ||
>>> +            dm_old_con_state->scaling != dm_new_con_state->scaling)
>>>                new_crtc_state->connectors_changed = true;
>>>        }
>>>    
>>
>> Hi,
>>
>> This change lgtm, and I also run it in our CI, and from IGT perspective, we are good.
>>
>> Harry, do you have any comment about this change?
>>
> 
> LGTM
> 
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
> 
> Harry
> 
>> Thanks
>> Siqueira
> 

Thanks, patch applied to amd-staging-drm-next.