Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b93c319e-b1c9-7488-7f0e-d96a6f98ad79@amd.com>
Date:   Thu, 12 Jan 2023 11:00:50 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH] drm: amd: display: Fix memory leakage
To:     Konstantin Meskhidze <konstantin.meskhidze@huawei.com>,
        harry.wentland@amd.com
Cc:     sunpeng.li@amd.com, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
        daniel@ffwll.ch, Jun.Lei@amd.com, Alvin.Lee2@amd.com,
        meenakshikumar.somasundaram@amd.com, martin.leung@amd.com,
        Dillon.Varone@amd.com, wenjing.liu@amd.com, alex.hung@amd.com,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, yusongping@huawei.com,
        hukeping@huawei.com, artem.kuzin@huawei.com
References: <20221130025046.2667372-1-konstantin.meskhidze@huawei.com>
Content-Language: en-US
From:   Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
In-Reply-To: <20221130025046.2667372-1-konstantin.meskhidze@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXgxV0g5dDdNcER0dXJZcjRmQSt4MVZiTFIweUt1TXp5SXRaeDJlRW9hN1VM?=
 =?utf-8?B?VGlDbXdpWlVaZWpQYUFFWHhvUVJtelhseHJqY3R0UVJzT1lHWWEvaDM0SzB0?=
 =?utf-8?B?ZnBKaWZGVXIxQXNoTytld0VMcEVJYmMwNlRteUhPLy83WW9QTjJCcm1MUk1x?=
 =?utf-8?B?SCtCY2hEUDh2MkNhZVJnQ1R1WUVVVllSRC9KaHpzQXoyVm5aek96Tmh4UWds?=
 =?utf-8?B?WmJaQnRGSngySjNHL1I1S0tQbVp2WEhGdVVHVVM0Y2VXRmtlMGpRS0NPdkw2?=
 =?utf-8?B?eHJoZEJPUUVKaXlTN29OYmlwZ3lOZWtER2tSY01hdDhqV3ljNmxDTkUrN1R2?=
 =?utf-8?B?dnljZk14dmc1ekp3Sm9mZ0NLWEJacThjYTJDbHBBSFl5MkM3NmJtL0YwcHRt?=
 =?utf-8?B?MXRCcnBFNnorNUJTd1NNNVl2dmR2UGRWSk1hb3VZZTFBWWdaS0wrVkc5UUpM?=
 =?utf-8?B?UFkyZkxmdUplMUpSanl0ckVrMW1FcmF1aWZOU0xuRXJHUllKOXlXYzBqaG1E?=
 =?utf-8?B?aTdlc0dERTVqSEp4UENPWEUwQTc1YTc4UEFDUnlYUVpaWU1yVDlYeURKUjVJ?=
 =?utf-8?B?VkVEWVNZVyt6Vy9TZEcwSkpqMTRjSDEvZ3pldVBXQlovSGVuMkcwU3A2dzJk?=
 =?utf-8?B?NWpFclVxamxadWFJT1BGOWhDMEZaMk9jWGkzdXJVejV2OEVSbkdIK2ZTamMr?=
 =?utf-8?B?NFZHK2ZlZFFsMGNPSGlsZldkcysxa2kxdTAyTG9EZ3diVjU1TElCdU1KWEhr?=
 =?utf-8?B?Y3V6WUdPRHFvOUdmR2QvUldaL3I2a2lzL0JpUDFHV2NYVGIzb3BqcTNJQURx?=
 =?utf-8?B?RlhzbngwYWkyWW9YUHIwR0NrUGZOYnVnYWdPK1RXSFBzY0Z0RFMvY2NtTUxk?=
 =?utf-8?B?a0ljNFVCT0d1UC9hMEdRbW16cExwYllXKzVyMStqL3o4bm50YXVzZHVoQVNP?=
 =?utf-8?B?TjlzV0tFTkVRM3g4MFlLMEgwVXpuTDFQb3p0ZGk1YnJJaSt6QzhMSmpwZEVB?=
 =?utf-8?B?M013VjdmWk9OOWVmeksvZGsyMHJrQld6WFpqbGkwK1VDcm01Ym1JOWd0djNn?=
 =?utf-8?B?WWN6aWU4YXozaWN5Q0VmLzhCK0pWK05xT2tVQ3VSRGlybERQTlhqcG8yRUQr?=
 =?utf-8?B?N0NLajUvVHFqazUvSFlocG1tcWdPNmlOOS9jS1dURUozN3RhM0RQdEhWa1p1?=
 =?utf-8?B?L1o2ZVNaWWVYdjZxN09mdi9UOXVmQnYrSUxYT2trYzQ3Y0phc3U1NUtkc1hD?=
 =?utf-8?B?NitKMHM4ZG15Z04ybTF3RFNacmQ4RnIyTzNoVWlRUWhhZytVc3ZGeFVacWZB?=
 =?utf-8?B?empwWkJjQ2tkMDJ6aW9rNHY3aEt5S1ByQjlnS1lhb2t6WUtvSUZkSnF3NTRZ?=
 =?utf-8?B?WmE4c005WStHT3BMckdxd2N1L0trQ08vbm1MSnh5U0M5VnJCMTRRUVJQZm8w?=
 =?utf-8?B?alQ3elo4cEV2WXBRYlR5TXk1eHNmTlh1Z1BGWDBBU1NCbnYyU094MXd2Vm5S?=
 =?utf-8?B?Q2RCY3J6dnhyWVBteTFhNUt2QVdHZi9yU2dvdjBjeTVLOWljYmRTcnBVSTVj?=
 =?utf-8?B?Vkcvdlc5d3duakN3SDluNmVSdytxdVJ0OWlCR1BqTGh3Y3pXbkQxOWtkYTRH?=
 =?utf-8?B?K091QnlzOGh5TTFxbi9OZnB1M09sUEVlWlFFWU16ZUs0WjFvT09FQ3RGZkFn?=
 =?utf-8?B?bklQWmdLdEFLYXNCa1N5a0Z1aFQzcTduVHVhL3ZtOGt5YjRxYUl5dDFNMERP?=
 =?utf-8?B?cjBFTXZYUXZiREx5TjNLaGkzcGxyRStmcGQyMjRWdXYzcDc1N3JyZ2haL0Y3?=
 =?utf-8?B?MG1NQ04xZERFeW43UFhXdnRoMGtrZE5IMDdVRWR6U0ErQkNOcWNmY3pySEN2?=
 =?utf-8?B?TVFpczJ1ZnlrMmx6UUpmVVZsRXo4Z0NQU1F6Z1U1WjVvaXFaalgwb2xraGNV?=
 =?utf-8?B?dVJNTlZKa1dNRFIxYkl6bkhRcDQxZlVIb0g4dDRpRytMVzh3WXZXdThkWlJx?=
 =?utf-8?B?ZUhlNkF0Y0RqNy9xZXJ2bGxtV1BLWnZDNEtGV0RBRm5qbFg2RGorRlFlemZa?=
 =?utf-8?B?dmFNK0swMytZeXROTUVXekIybmpsMUpPaG5WWDd2VnljTFdCVHNjSHB2N0VX?=
 =?utf-8?Q?wmSRrN4S+nCNY80d/zXkTB8/R?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e3e20839-87a7-4297-7837-08daf4b62e2f
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2941.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2023 16:00:52.5715
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wMGsj4/+vBwPQeZha5hWFp0qyC7+xMJD7SQNINhov0NsPB761h6wz29FW418MbY/KV6Eb+LkTfZTfL9p7zIzzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7425
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/29/22 21:50, Konstantin Meskhidze wrote:
> This commit fixes memory leakage in dc_construct_ctx() function.
> 
> Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
> ---
>   drivers/gpu/drm/amd/display/dc/core/dc.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 997ab031f816..359e28d3567e 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -878,6 +878,7 @@ static bool dc_construct_ctx(struct dc *dc,
>   
>   	dc_ctx->perf_trace = dc_perf_trace_create();
>   	if (!dc_ctx->perf_trace) {
> +		kfree(dc_ctx);
>   		ASSERT_CRITICAL(false);
>   		return false;
>   	}

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>

And applied to amd-staging-drm-next.

Thanks
Siqueira