Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 12 Jan 2023 08:16:34 -0800
From:   Isaku Yamahata <isaku.yamahata@gmail.com>
To:     "Wang, Lei" <lei4.wang@intel.com>
Cc:     isaku.yamahata@intel.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com,
        Paolo Bonzini <pbonzini@redhat.com>, erdemaktas@google.com,
        Sean Christopherson <seanjc@google.com>,
        Sagi Shahar <sagis@google.com>,
        David Matlack <dmatlack@google.com>
Subject: Re: [PATCH v10 000/108] KVM TDX basic feature support
Message-ID: <20230112161634.GD2034518@ls.amr.corp.intel.com>
References: <cover.1667110240.git.isaku.yamahata@intel.com>
 <44e77307-8c49-e350-49e4-d5fa3261db27@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <44e77307-8c49-e350-49e4-d5fa3261db27@intel.com>
Precedence: bulk

On Tue, Jan 03, 2023 at 04:26:59PM +0800,
"Wang, Lei" <lei4.wang@intel.com> wrote:

> On 10/30/2022 2:22 PM, isaku.yamahata@intel.com wrote:
> 
> > ** Detecting the TDX module readiness.
> > TDX host patch series implements the detection of the TDX module availability
> > and its initialization so that KVM can use it.  Also it manages Host KeyID
> > (HKID) assigned to guest TD.
> > The assumed APIs the TDX host patch series provides are
> > - int seamrr_enabled()
> >   Check if required cpu feature (SEAM mode) is available. This only check CPU
> >   feature availability.  At this point, the TDX module may not be ready for KVM
> >   to use.
> > - int init_tdx(void);
> >   Initialization of TDX module so that the TDX module is ready for KVM to use.
> > - const struct tdsysinfo_struct *tdx_get_sysinfo(void);
> >   Return the system wide information about the TDX module.  NULL if the TDX
> >   isn't initialized.
> > - u32 tdx_get_global_keyid(void);
> >   Return global key id that is used for the TDX module itself.
> > - int tdx_keyid_alloc(void);
> >   Allocate HKID for guest TD.
> > - void tdx_keyid_free(int keyid);
> >   Free HKID for guest TD.
> 
> tdx_enable() is introduced by TDX host patch series and used in patch 5, should
> it be added to this list too?

Thanks, I've updated the cover letter to catch up the host tdx patch series v10.
-- 
Isaku Yamahata <isaku.yamahata@gmail.com>